From: "Pierre-Clément Tosi" <ptosi@google.com>
To: u-boot@lists.denx.de
Cc: "Tom Rini" <trini@konsulko.com>,
"Pierre-Clément Tosi" <ptosi@google.com>,
"Matthias Weisser" <weisserm@arcor.de>
Subject: [PATCH] arm: Fix bad memcpy.S str8w macro argument count
Date: Wed, 10 Nov 2021 15:04:40 +0100 [thread overview]
Message-ID: <20211110140440.2116503-1-ptosi@google.com> (raw)
Remove the extra (empty) argument passed to str8w, causing the following
error:
<instantiation>:40:47: error: too many positional arguments
str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, , abort=19f
^
u-boot/arch/arm/lib/memcpy.S:240:5: note: while in macro instantiation
17: forward_copy_shift pull=16 push=16
^
Note: no functional change intended.
Fixes: d8834a1323af ("arm: Use optimized memcpy and memset from linux")
Signed-off-by: Pierre-Clément Tosi <ptosi@google.com>
---
arch/arm/lib/memcpy.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/memcpy.S b/arch/arm/lib/memcpy.S
index f7fb77235c..eee7a219ce 100644
--- a/arch/arm/lib/memcpy.S
+++ b/arch/arm/lib/memcpy.S
@@ -210,7 +210,7 @@ ENTRY(memcpy)
orr r9, r9, ip, lspush #\push
mov ip, ip, lspull #\pull
orr ip, ip, lr, lspush #\push
- str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, , abort=19f
+ str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, abort=19f
bge 12b
PLD( cmn r2, #96 )
PLD( bge 13b )
--
2.34.0.rc0.344.g81b53c2807-goog
next reply other threads:[~2021-11-10 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 14:04 Pierre-Clément Tosi [this message]
2021-11-10 14:14 ` [PATCH] arm: Fix bad memcpy.S str8w macro argument count Tom Rini
2021-11-10 14:51 ` Pierre-Clément Tosi
2021-11-10 14:58 ` Tom Rini
2021-11-16 19:26 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110140440.2116503-1-ptosi@google.com \
--to=ptosi@google.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=weisserm@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox