From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Stefan Roese" <sr@denx.de>,
u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message
Date: Tue, 14 Dec 2021 12:10:30 +0100 [thread overview]
Message-ID: <20211214111030.p44erpox4jicvykr@pali> (raw)
In-Reply-To: <20211126143738.23830-7-kabel@kernel.org>
On Friday 26 November 2021 15:37:35 Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
>
> Print the wrong srcaddr (spl_image->offset) in error message also for
> SATA case.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> arch/arm/mach-mvebu/spl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c
> index af9e45ac7a..8c8cbc833f 100644
> --- a/arch/arm/mach-mvebu/spl.c
> +++ b/arch/arm/mach-mvebu/spl.c
> @@ -190,7 +190,8 @@ int spl_parse_board_header(struct spl_image_info *spl_image,
> */
> if (mhdr->blockid == IBR_HDR_SATA_ID) {
> if (spl_image->offset < 1) {
> - printf("ERROR: Wrong SATA srcaddr in kwbimage\n");
> + printf("ERROR: Wrong SATA srcaddr (%u) in kwbimage\n",
Maybe change message to "ERROR: Wrong srcaddr (%u) in SATA kwbimage" for
consistency with other newly added error messages in this patch series?
> + spl_image->offset);
> return -EINVAL;
> }
> spl_image->offset -= 1;
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-12-14 11:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 14:37 [PATCH u-boot-marvell v2 0/9] More verifications for kwbimage in SPL Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 1/9] arm: mvebu: Check that kwbimage offset and blocksize are valid Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 2/9] SPL: Add struct spl_boot_device parameter into spl_parse_board_header() Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 3/9] arm: mvebu: Check that kwbimage blockid matches boot mode Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 4/9] SPL: Add support for checking board / BootROM specific image types Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 5/9] arm: mvebu: Check for kwbimage data checksum Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message Marek Behún
2021-11-30 6:20 ` Stefan Roese
2021-12-14 11:10 ` Pali Rohár [this message]
2021-12-14 13:11 ` Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 7/9] arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_t Marek Behún
2021-11-30 6:20 ` Stefan Roese
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 8/9] arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible Marek Behún
2021-11-30 6:22 ` Stefan Roese
2021-12-14 9:36 ` Pali Rohár
2021-12-14 9:45 ` Marek Behún
2021-12-14 11:12 ` Pali Rohár
2021-12-14 12:45 ` Marek Behún
2021-12-14 12:48 ` Stefan Roese
2021-12-14 13:01 ` Marek Behún
2021-12-16 18:16 ` Pali Rohár
2021-12-16 22:09 ` Marek Behún
2021-12-16 22:17 ` Marek Behún
2021-11-26 14:37 ` [PATCH u-boot-marvell v2 9/9] arm: mvebu: spl: Fix 100 column exceeds Marek Behún
2021-11-30 6:22 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214111030.p44erpox4jicvykr@pali \
--to=pali@kernel.org \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox