Re: [PATCH 1/8] arm: kirkwood: Pogoplug-V4 : Add DTS files

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 17 Dec 2021 20:23:27 -0800
Tony Dinh <mibodhi@gmail.com> wrote:

Hi,

> Add DTS files for Pogoplug V4 board

is there any reason you didn't take the kirkwood-pogoplug-series-4.dts
file from the Linux tree? That is the same device, isn't it?

Tom will ask you about the upstream status anyway...

Cheers,
Andre

> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> ---
> 
>  arch/arm/dts/Makefile                 |   1 +
>  arch/arm/dts/kirkwood-pogoplug_v4.dts | 145 ++++++++++++++++++++++++++
>  2 files changed, 146 insertions(+)
>  create mode 100644 arch/arm/dts/kirkwood-pogoplug_v4.dts
> 
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 7f622fedbd..716c6c0ed2 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -68,6 +68,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += \
>  	kirkwood-openrd-client.dtb \
>  	kirkwood-openrd-ultimate.dtb \
>  	kirkwood-pogo_e02.dtb \
> +	kirkwood-pogoplug_v4.dtb \
>  	kirkwood-sheevaplug.dtb
>  
>  dtb-$(CONFIG_MACH_S900) += \
> diff --git a/arch/arm/dts/kirkwood-pogoplug_v4.dts b/arch/arm/dts/kirkwood-pogoplug_v4.dts
> new file mode 100644
> index 0000000000..b4754f600e
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-pogoplug_v4.dts
> @@ -0,0 +1,145 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2014-2021 Tony Dinh <mibodhi@gmail.com>
> + *
> + * Device tree file for the Pogoplug V4/Mobile
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6192.dtsi"
> +
> +/ {
> +	model = "Pogoplug v4";
> +	compatible = "cloudengines,pogoplug-v4", "cloudengines,pogoplug-mobile",
> +		"marvell,kirkwood-88f6192", "marvell,kirkwood";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x8000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200";
> +		stdout-path = &uart0;
> +	};
> +
> +	ocp@f1000000 {
> +		pinctrl: pin-controller@10000 {
> +			pmx_led_green: pmx-led-green {
> +				marvell,pins = "mpp22";
> +				marvell,function = "gpio";
> +			};
> +			pmx_led_red: pmx-led-red {
> +				marvell,pins = "mpp24";
> +				marvell,function = "gpio";
> +			};
> +			pmx_button_eject: pmx-button-eject {
> +				marvell,pins = "mpp29";
> +				marvell,function = "gpio";
> +			};
> +		};
> +
> +		serial@12000 {
> +			status = "ok";
> +		};
> +
> +		sata@80000 {
> +			status = "okay";
> +			nr-ports = <2>;
> +		};
> +
> +		mvsdio@90000 {
> +			pinctrl-0 = <&pmx_sdio>;
> +			pinctrl-names = "default";
> +			status = "okay";
> +			cd-gpios = <&gpio0 27 GPIO_ACTIVE_HIGH>;
> +			/* No WP GPIO */
> +		};
> +	};
> +
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_led_red &pmx_led_green>;
> +		pinctrl-names = "default";
> +
> +		health {
> +			label = "status:green:health";
> +			gpios = <&gpio0 22 GPIO_ACTIVE_LOW>;
> +			default-state = "keep";
> +		};
> +		fault {
> +			label = "status:red:fault";
> +			gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
> +		};
> +	};
> +
> +	gpio_keys {
> +		compatible = "gpio-keys";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		pinctrl-0 = <&pmx_button_eject>;
> +		pinctrl-names = "default";
> +
> +		button@1 {
> +			label = "Eject Button";
> +			linux,code = <KEY_EJECTCD>;
> +			gpios = <&gpio0 29 GPIO_ACTIVE_LOW>;
> +		};
> +	};
> +
> +};
> +
> +&nand {
> +	status = "okay";
> +
> +	partition@0 {
> +		label = "u-boot";
> +		reg = <0x0000000 0x200000>;
> +	};
> +
> +	partition@200000 {
> +		label = "uImage";
> +		reg = <0x200000 0x300000>;
> +	};
> +
> +	partition@500000 {
> +		label = "uImage2";
> +		reg = <0x500000 0x300000>;
> +	};
> +
> +	partition@800000 {
> +		label = "failsafe";
> +		reg = <0x800000 0x800000>;
> +	};
> +
> +	partition@1000000 {
> +		label = "root";
> +		reg = <0x1000000 0x7000000>;
> +	};
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	ethphy0: ethernet-phy@0 {
> +		reg = <0>;
> +	};
> +};
> +
> +&eth0 {
> +	status = "okay";
> +	ethernet0-port@0 {
> +		phy-handle = <&ethphy0>;
> +	};
> +};
> +
> +&pciec {
> +	status = "okay";
> +};
> +
> +&pcie0 {
> +	status = "okay";
> +};