From: Tom Rini <trini@konsulko.com>
To: Sven Schwermer <sven@svenschwermer.de>
Cc: u-boot@lists.denx.de, Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Artem Lapkin <email2tema@gmail.com>,
Ramon Fried <rfried.dev@gmail.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2 1/2] cmd: source: Use script from default config
Date: Mon, 24 Jan 2022 13:08:07 -0500 [thread overview]
Message-ID: <20220124180807.GH7515@bill-the-cat> (raw)
In-Reply-To: <d285ce73-8f2e-005a-6091-41a746416a53@svenschwermer.de>
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
On Sat, Jan 22, 2022 at 09:36:58PM +0100, Sven Schwermer wrote:
> Hi Tom,
>
> I didn't think this would result in a size increase. Could you elaborate?
Alright. So for background, if you build with tools/buildman/buildman
rather than just "make" directly there's some handy tools like "bloat"
detection, which shows function size changes from build A to build B.
Doing something like this will show the changes for pine64_plus for
example
export SOURCE_DATE_EPOCH=`date +%s`
./tools/buildman/buildman -o /tmp/pine64_plus -devl -SBC pine64_plus
./tools/buildman/buildman -o /tmp/pine64_plus -devl -SsB pine64_plus
That shows in the end:
aarch64: (for 1/1 boards) all +551.0 rodata +107.0 text +444.0
pine64_plus : all +551 rodata +107 text +444
u-boot: add: 2/0, grow: 0/-1 bytes: 452/-8 (444)
function old new delta
fit_find_config_node - 264 +264
board_fit_config_name_match - 188 +188
image_source_script 520 512 -8
And it's that growth, over 722 configs, that I'm concerned with.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-24 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 18:45 [PATCH v2 1/2] cmd: source: Use script from default config Sven Schwermer
2022-01-01 18:45 ` [PATCH v2 2/2] f_sdp: Retry sourcing default FIT script Sven Schwermer
2022-01-18 13:29 ` [PATCH v2 1/2] cmd: source: Use script from default config Tom Rini
2022-01-22 20:36 ` Sven Schwermer
2022-01-24 18:08 ` Tom Rini [this message]
2022-01-24 20:31 ` Sven Schwermer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124180807.GH7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=email2tema@gmail.com \
--cc=mr.nuke.me@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@chromium.org \
--cc=sven@svenschwermer.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox