From: Tom Rini <trini@konsulko.com>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: u-boot@lists.denx.de, Lukasz Majewski <lukma@denx.de>,
U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] dfu: mtd: skip empty pages when writing page for UBI partition
Date: Sat, 29 Jan 2022 13:49:43 -0500 [thread overview]
Message-ID: <20220129184943.GC7515@bill-the-cat> (raw)
In-Reply-To: <20220118102619.1.I161a621b6f151ada380bedac41d2a2bd67d47933@changeid>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On Tue, Jan 18, 2022 at 10:26:21AM +0100, Patrick Delaunay wrote:
> Align the DFU MTD backend for the UBI partitions with the mtd command write
> behavior when the option .dontskipff is not used: don't write the empty
> pages (full of 0xFF); it is not required for UBI, see [1] for details.
>
> This patch avoids the "free space fixup" procedure in the kernel [2]
> and allows to program a UBIFS volume generated by mkfs.ubifs without the
> option -F, --space-fixup.
>
> The MTD DFU backend implements this behavior introduced on DFU NAND
> backend by the commit 13cb7cc9e8e4 ("dfu: Add option to skip empty pages
> when flashing UBI images to NAND") and also supported by the command nand
> by CONFIG_CMD_NAND_TRIMFFS and by commit c9494866df83 ("cmd_nand: add nand
> write.trimffs command").
>
> [1] http://www.linux-mtd.infradead.org/doc/ubi.html#L_flasher_algo
> [2] http://www.linux-mtd.infradead.org/faq/ubifs.html#L_free_space_fixup
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-01-29 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 9:26 [PATCH] dfu: mtd: skip empty pages when writing page for UBI partition Patrick Delaunay
2022-01-29 18:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220129184943.GC7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=lukma@denx.de \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox