From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: "Simon Glass" <sjg@chromium.org>, "Stefan Roese" <sr@denx.de>,
"Michael Walle" <michael@walle.cc>,
"Alison Wang" <alison.wang@nxp.com>,
"Andre Przywara" <andre.przywara@arm.com>,
"Biwen Li" <biwen.li@nxp.com>,
"Dennis Gilmore" <dgilmore@redhat.com>,
"Heiko Schocher" <hs@denx.de>,
"Igor Opaniuk" <igor.opaniuk@foundries.io>,
"Marek Behún" <marek.behun@nic.cz>,
"Mario Six" <mario.six@gdsys.cc>,
"Meenakshi Aggarwal" <meenakshi.aggarwal@nxp.com>,
"Mian Yousaf Kaukab" <ykaukab@suse.de>,
"Mingkai Hu" <mingkai.hu@nxp.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Pramod Kumar" <pramod.kumar_1@nxp.com>,
"Priyanka Jain" <priyanka.jain@nxp.com>,
"Rajesh Bhagat" <rajesh.bhagat@nxp.com>,
"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
"Rick Chen" <rick@andestech.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Tang Yuantian" <andy.tang@nxp.com>,
"Wasim Khan" <wasim.khan@nxp.com>,
"Yangbo Lu" <yangbo.lu@nxp.com>, liuhao <liuhao@phytium.com.cn>,
shuyiqi <shuyiqi@phytium.com.cn>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"U-Boot Mailing List" <u-boot@lists.denx.de>
Subject: Re: [PATCH 6/8] scsi: Drop CONFIG_SYS_SCSI_MAX_DEVICE
Date: Mon, 31 Jan 2022 11:04:35 -0500 [thread overview]
Message-ID: <20220131160435.GY7515@bill-the-cat> (raw)
In-Reply-To: <a5423ad2-76df-5ec6-fcc7-1e38d9def4eb@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On Mon, Jan 31, 2022 at 04:58:46PM +0100, Heinrich Schuchardt wrote:
> On 1/31/22 15:49, Simon Glass wrote:
> > This is defined based on two other CONFIGs for all boards except sandbox
> > and durian.
> >
> > For sandbox the value does not matter. For durian the value seems
> > excessive.
> >
> > Drop the option completely, to simplify configuration and reduce the
> > number of things we need to convert to Kconfig.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
[snip]
> > diff --git a/include/configs/helios4.h b/include/configs/helios4.h
> > index de1ebbf3751..c1d42f17ca6 100644
> > --- a/include/configs/helios4.h
> > +++ b/include/configs/helios4.h
> > @@ -40,8 +40,6 @@
> > #define CONFIG_SCSI_AHCI_PLAT
> > #define CONFIG_SYS_SCSI_MAX_SCSI_ID 1
>
> This should be Kconfig too. 1 seems to be a reasonable default value as it
> covers most boards. The minimum should be enforced as 1 in Kconfig.
>
> > #define CONFIG_SYS_SCSI_MAX_LUN 1
>
> Make this Kconfig, please. Let it default to 1 and enforce a minimum of 1
> and a maximum of 256 in Kconfig.
As the series title notes this is "some" options, so yes, a good
follow-up would be to cover more of them. I believe the end goal here
is that we can drop dead code and more easily check/complain about
unmigrated boards.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-01-31 16:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 14:49 [PATCH 0/8] scsi: Convert some options to Kconfig Simon Glass
2022-01-31 14:49 ` [PATCH 1/8] sata: Drop Silicon Image SIL3114 SATA driver Simon Glass
2022-02-01 6:08 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 2/8] sata: Only support BLK Simon Glass
2022-02-01 6:08 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 3/8] sata: Rearrange Kconfig for SATA Simon Glass
2022-02-01 6:09 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 4/8] sata: sata_sil: Only support BLK Simon Glass
2022-02-01 6:13 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 5/8] ahci: Make ahci drivers depend on AHCI Simon Glass
2022-02-01 6:14 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 6/8] scsi: Drop CONFIG_SYS_SCSI_MAX_DEVICE Simon Glass
2022-01-31 15:58 ` Heinrich Schuchardt
2022-01-31 16:04 ` Tom Rini [this message]
2022-01-31 16:13 ` Simon Glass
2022-02-01 6:14 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 7/8] Convert CONFIG_SCSI_AHCI_PLAT et al to Kconfig Simon Glass
2022-02-01 6:14 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
2022-01-31 14:49 ` [PATCH 8/8] dm: scsi: Add a migration deadline for scsi Simon Glass
2022-02-01 6:15 ` Stefan Roese
2022-02-09 16:39 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131160435.GY7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=alison.wang@nxp.com \
--cc=andre.przywara@arm.com \
--cc=andy.tang@nxp.com \
--cc=biwen.li@nxp.com \
--cc=dgilmore@redhat.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=hs@denx.de \
--cc=igor.opaniuk@foundries.io \
--cc=liuhao@phytium.com.cn \
--cc=marek.behun@nic.cz \
--cc=mario.six@gdsys.cc \
--cc=meenakshi.aggarwal@nxp.com \
--cc=michael@walle.cc \
--cc=mingkai.hu@nxp.com \
--cc=patrick.delaunay@foss.st.com \
--cc=pramod.kumar_1@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=rajesh.bhagat@nxp.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rick@andestech.com \
--cc=rob.herring@calxeda.com \
--cc=shuyiqi@phytium.com.cn \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=wasim.khan@nxp.com \
--cc=xypron.glpk@gmx.de \
--cc=yangbo.lu@nxp.com \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox