From: Nishanth Menon <nm@ti.com>
To: Hari Nagalla <hnagalla@ti.com>
Cc: <u-boot@lists.denx.de>
Subject: Re: [PATCH v1 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes
Date: Thu, 3 Feb 2022 15:42:19 -0600 [thread overview]
Message-ID: <20220203214219.gehtg2vg2flf7mp2@grumble> (raw)
In-Reply-To: <20220202182223.16521-4-hnagalla@ti.com>
On 12:22-20220202, Hari Nagalla wrote:
One additional comment independent of Christian's comment..
[...]
> diff --git a/arch/arm/mach-k3/am642_init.c b/arch/arm/mach-k3/am642_init.c
> index 543dea02bc..cb9495e525 100644
> --- a/arch/arm/mach-k3/am642_init.c
> +++ b/arch/arm/mach-k3/am642_init.c
> @@ -24,6 +24,8 @@
> #include <dm/root.h>
>
> #if defined(CONFIG_SPL_BUILD)
> +#define MCU_CTRL_MMR0_BASE 0x04500000
> +#define CTRLMMR_MCU_RST_CTRL 0x04518170
>
> static void ctrl_mmr_unlock(void)
> {
> @@ -42,6 +44,17 @@ static void ctrl_mmr_unlock(void)
> mmr_unlock(MCU_PADCFG_MMR1_BASE, 1);
> }
>
> +static void mcu_ctrl_mmr_unlock(void)
> +{
There is no real point in spliting this up into mcu_ctrl_mmr_unlock.
I'd suggest putting it part of ctrl_mmr_unlock (we already do unlock MCU
padconf mmrs there)
[...]
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-02-03 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:22 [PATCH v1 0/4] Add ESM driver support for AM64x R5 Hari Nagalla
2022-02-02 18:22 ` [PATCH v1 1/4] misc: k3_esm: Add functionality to set and route error events within K3SoC Hari Nagalla
2022-02-03 21:44 ` Nishanth Menon
2022-02-02 18:22 ` [PATCH v1 2/4] arm: dts: k3-am64: Add support for ESM device nodes Hari Nagalla
2022-02-03 21:46 ` Nishanth Menon
2022-02-11 7:20 ` Christian Gmeiner
2022-02-02 18:22 ` [PATCH v1 3/4] arch: arm: mach-k3: am642_init: Probe ESM nodes Hari Nagalla
2022-02-03 8:40 ` Christian Gmeiner
2022-02-03 21:42 ` Nishanth Menon [this message]
2022-02-02 18:22 ` [PATCH v1 4/4] configs: am64x_evm_r5_defconfig: Add support for ESM Hari Nagalla
2022-02-11 7:22 ` Christian Gmeiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203214219.gehtg2vg2flf7mp2@grumble \
--to=nm@ti.com \
--cc=hnagalla@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox