* [PATCH] imx: ventana: correct splashimage load address
@ 2022-01-17 11:31 Andrey Zhizhikin
2022-01-18 11:51 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrey Zhizhikin @ 2022-01-17 11:31 UTC (permalink / raw)
To: u-boot; +Cc: tharvey, Andrey Zhizhikin
Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
SYS_LOADADDR.
Use the correct macro in environment by replacing CONFIG_LOADADDR with
CONFIG_SYS_LOADADDR.
Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Cc: Tim Harvey <tharvey@gateworks.com>
---
include/configs/gw_ventana.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
index 513b2d4679..acd495f234 100644
--- a/include/configs/gw_ventana.h
+++ b/include/configs/gw_ventana.h
@@ -105,7 +105,7 @@
#define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
"splashpos=m,m\0" \
- "splashimage=" __stringify(CONFIG_LOADADDR) "\0" \
+ "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
"usb_pgood_delay=2000\0" \
"console=ttymxc1\0" \
"bootdevs=usb mmc sata flash\0" \
base-commit: d71dbe657c3c22f50ecb3df133e5cdd884daae7d
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] imx: ventana: correct splashimage load address
2022-01-17 11:31 [PATCH] imx: ventana: correct splashimage load address Andrey Zhizhikin
@ 2022-01-18 11:51 ` Fabio Estevam
2022-01-18 16:40 ` Tim Harvey
2022-02-05 16:41 ` sbabic
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2022-01-18 11:51 UTC (permalink / raw)
To: Andrey Zhizhikin; +Cc: U-Boot-Denx, Tim Harvey
Hi Andrey,
On Mon, Jan 17, 2022 at 8:32 AM Andrey Zhizhikin
<andrey.zhizhikin@leica-geosystems.com> wrote:
>
> Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
> CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
> SYS_LOADADDR.
>
> Use the correct macro in environment by replacing CONFIG_LOADADDR with
> CONFIG_SYS_LOADADDR.
>
> Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
Thanks for the fix:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] imx: ventana: correct splashimage load address
2022-01-17 11:31 [PATCH] imx: ventana: correct splashimage load address Andrey Zhizhikin
2022-01-18 11:51 ` Fabio Estevam
@ 2022-01-18 16:40 ` Tim Harvey
2022-01-27 23:19 ` Tim Harvey
2022-02-05 16:41 ` sbabic
2 siblings, 1 reply; 6+ messages in thread
From: Tim Harvey @ 2022-01-18 16:40 UTC (permalink / raw)
To: Andrey Zhizhikin; +Cc: u-boot
On Mon, Jan 17, 2022 at 3:32 AM Andrey Zhizhikin
<andrey.zhizhikin@leica-geosystems.com> wrote:
>
> Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
> CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
> SYS_LOADADDR.
>
> Use the correct macro in environment by replacing CONFIG_LOADADDR with
> CONFIG_SYS_LOADADDR.
>
> Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
> include/configs/gw_ventana.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> index 513b2d4679..acd495f234 100644
> --- a/include/configs/gw_ventana.h
> +++ b/include/configs/gw_ventana.h
> @@ -105,7 +105,7 @@
>
> #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
> "splashpos=m,m\0" \
> - "splashimage=" __stringify(CONFIG_LOADADDR) "\0" \
> + "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
> "usb_pgood_delay=2000\0" \
> "console=ttymxc1\0" \
> "bootdevs=usb mmc sata flash\0" \
>
> base-commit: d71dbe657c3c22f50ecb3df133e5cdd884daae7d
> --
> 2.25.1
>
Acked-By: Tim Harvey <tharvey@gateworks.com>
Thanks,
Tim
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] imx: ventana: correct splashimage load address
2022-01-18 16:40 ` Tim Harvey
@ 2022-01-27 23:19 ` Tim Harvey
2022-01-28 18:31 ` ZHIZHIKIN Andrey
0 siblings, 1 reply; 6+ messages in thread
From: Tim Harvey @ 2022-01-27 23:19 UTC (permalink / raw)
To: Andrey Zhizhikin; +Cc: u-boot
On Tue, Jan 18, 2022 at 8:40 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Mon, Jan 17, 2022 at 3:32 AM Andrey Zhizhikin
> <andrey.zhizhikin@leica-geosystems.com> wrote:
> >
> > Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
> > CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
> > SYS_LOADADDR.
> >
> > Use the correct macro in environment by replacing CONFIG_LOADADDR with
> > CONFIG_SYS_LOADADDR.
> >
> > Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
> > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > Cc: Tim Harvey <tharvey@gateworks.com>
> > ---
> > include/configs/gw_ventana.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> > index 513b2d4679..acd495f234 100644
> > --- a/include/configs/gw_ventana.h
> > +++ b/include/configs/gw_ventana.h
> > @@ -105,7 +105,7 @@
> >
> > #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
> > "splashpos=m,m\0" \
> > - "splashimage=" __stringify(CONFIG_LOADADDR) "\0" \
> > + "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
> > "usb_pgood_delay=2000\0" \
> > "console=ttymxc1\0" \
> > "bootdevs=usb mmc sata flash\0" \
> >
> > base-commit: d71dbe657c3c22f50ecb3df133e5cdd884daae7d
> > --
> > 2.25.1
> >
>
> Acked-By: Tim Harvey <tharvey@gateworks.com>
>
Andrey,
While this does restore the custom logo on the gwventana boards there
is now a default U-Boot logo in the top left corner. I assume this is
some new addition... how do I disable the U-Boot logo?
Best Regards,
Tim
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] imx: ventana: correct splashimage load address
2022-01-27 23:19 ` Tim Harvey
@ 2022-01-28 18:31 ` ZHIZHIKIN Andrey
0 siblings, 0 replies; 6+ messages in thread
From: ZHIZHIKIN Andrey @ 2022-01-28 18:31 UTC (permalink / raw)
To: Tim Harvey; +Cc: u-boot
Hello Tim,
> -----Original Message-----
> From: Tim Harvey <tharvey@gateworks.com>
> Sent: Friday, January 28, 2022 12:20 AM
> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>
> Cc: u-boot <u-boot@lists.denx.de>
> Subject: Re: [PATCH] imx: ventana: correct splashimage load address
>
>
> On Tue, Jan 18, 2022 at 8:40 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Mon, Jan 17, 2022 at 3:32 AM Andrey Zhizhikin
> > <andrey.zhizhikin@leica-geosystems.com> wrote:
> > >
> > > Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
> > > CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
> > > SYS_LOADADDR.
> > >
> > > Use the correct macro in environment by replacing CONFIG_LOADADDR with
> > > CONFIG_SYS_LOADADDR.
> > >
> > > Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
> > > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> > > Cc: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > > include/configs/gw_ventana.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/configs/gw_ventana.h b/include/configs/gw_ventana.h
> > > index 513b2d4679..acd495f234 100644
> > > --- a/include/configs/gw_ventana.h
> > > +++ b/include/configs/gw_ventana.h
> > > @@ -105,7 +105,7 @@
> > >
> > > #define CONFIG_EXTRA_ENV_SETTINGS_COMMON \
> > > "splashpos=m,m\0" \
> > > - "splashimage=" __stringify(CONFIG_LOADADDR) "\0" \
> > > + "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
> > > "usb_pgood_delay=2000\0" \
> > > "console=ttymxc1\0" \
> > > "bootdevs=usb mmc sata flash\0" \
> > >
> > > base-commit: d71dbe657c3c22f50ecb3df133e5cdd884daae7d
> > > --
> > > 2.25.1
> > >
> >
> > Acked-By: Tim Harvey <tharvey@gateworks.com>
> >
>
> Andrey,
>
> While this does restore the custom logo on the gwventana boards there
> is now a default U-Boot logo in the top left corner. I assume this is
> some new addition... how do I disable the U-Boot logo?
THB, this I do not know. I stumbled upon the incorrect variable while
I was working on imx8mq-evk, and thought that this patch would be
beneficial for gwventana since this was the only place where the old
variable name was used.
I guess the question of suppression of default U-Boot logo is for a
bigger audience here.
>
> Best Regards,
>
> Tim
-- andrey
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: ventana: correct splashimage load address
2022-01-17 11:31 [PATCH] imx: ventana: correct splashimage load address Andrey Zhizhikin
2022-01-18 11:51 ` Fabio Estevam
2022-01-18 16:40 ` Tim Harvey
@ 2022-02-05 16:41 ` sbabic
2 siblings, 0 replies; 6+ messages in thread
From: sbabic @ 2022-02-05 16:41 UTC (permalink / raw)
To: Andrey Zhizhikin, u-boot
> Commit 72d81360aabd ("global: Convert CONFIG_LOADADDR to
> CONFIG_SYS_LOADADDR") dropped the usage of LOADADDR and replaced it with
> SYS_LOADADDR.
> Use the correct macro in environment by replacing CONFIG_LOADADDR with
> CONFIG_SYS_LOADADDR.
> Fixes: d75ebf3482c3 ("imx: ventana: fix splash logo drawing")
> Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Acked-By: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-05 16:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-17 11:31 [PATCH] imx: ventana: correct splashimage load address Andrey Zhizhikin
2022-01-18 11:51 ` Fabio Estevam
2022-01-18 16:40 ` Tim Harvey
2022-01-27 23:19 ` Tim Harvey
2022-01-28 18:31 ` ZHIZHIKIN Andrey
2022-02-05 16:41 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox