* [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled
@ 2022-01-01 18:50 Marek Vasut
2022-01-12 20:03 ` Simon Glass
2022-02-05 16:43 ` sbabic
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2022-01-01 18:50 UTC (permalink / raw)
To: u-boot; +Cc: Marek Vasut, Peng Fan, Simon Glass
Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
the flash.bin again and produces corrupted result.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Peng Fan <peng.fan@oss.nxp.com>
Cc: Simon Glass <sjg@chromium.org>
---
Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile b/Makefile
index ae9bfab91ac..c04caaebc8e 100644
--- a/Makefile
+++ b/Makefile
@@ -1517,7 +1517,6 @@ else
ifeq ($(CONFIG_BINMAN),y)
flash.bin: spl/u-boot-spl.bin $(INPUTS-y) FORCE
$(call if_changed,binman)
- $(Q)$(MAKE) $(build)=arch/arm/mach-imx $@
else
flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE
$(Q)$(MAKE) $(build)=arch/arm/mach-imx $@
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled
2022-01-01 18:50 [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled Marek Vasut
@ 2022-01-12 20:03 ` Simon Glass
2022-02-05 16:43 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2022-01-12 20:03 UTC (permalink / raw)
To: Marek Vasut; +Cc: U-Boot Mailing List, Peng Fan
On Sat, 1 Jan 2022 at 11:50, Marek Vasut <marex@denx.de> wrote:
>
> Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
> enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
> the flash.bin again and produces corrupted result.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Peng Fan <peng.fan@oss.nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> Makefile | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled
2022-01-01 18:50 [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled Marek Vasut
2022-01-12 20:03 ` Simon Glass
@ 2022-02-05 16:43 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: sbabic @ 2022-02-05 16:43 UTC (permalink / raw)
To: Marek Vasut, u-boot
> Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
> enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
> the flash.bin again and produces corrupted result.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Peng Fan <peng.fan@oss.nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-05 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-01 18:50 [PATCH] Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled Marek Vasut
2022-01-12 20:03 ` Simon Glass
2022-02-05 16:43 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox