From: Adam Ford <aford173@gmail.com>
To: u-boot@lists.denx.de
Cc: marex@denx.de, trini@konsulko.com, woods.technical@gmail.com,
Adam Ford <aford173@gmail.com>
Subject: [PATCH 2/7] usb: ehci-omap: Move omap_ehci_hcd_init to omap_ehci_probe
Date: Sat, 19 Feb 2022 17:08:42 -0600 [thread overview]
Message-ID: <20220219230847.798484-3-aford173@gmail.com> (raw)
In-Reply-To: <20220219230847.798484-1-aford173@gmail.com>
The OMAP3 hierarchy has the ehci node as a sub-node of the
usbhshost. The usbhshost node contains an ohci and an ehci
subnode. The configuration of the ehci belongs in the
EHCI node and not its parent. Move it to the proper probe.
usb start
starting USB...
Bus ehci@48064800: USB EHCI 1.00
Bus usb_otg_hs@480ab000: Port not available.
scanning bus ehci@48064800 for devices... 3 USB Device(s) found
scanning usb for storage devices... 1 Storage Device(s) found
Signed-off-by: Adam Ford <aford173@gmail.com>
---
drivers/usb/host/ehci-omap.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index d34c0add4a..5f79279fe2 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -312,7 +312,7 @@ static int omap_usbhs_probe(struct udevice *dev)
omap_usbhs_set_mode(i, mode);
}
- return omap_ehci_hcd_init(0, &usbhs_bdata);
+ return 0;
}
static const struct udevice_id omap_usbhs_dt_ids[] = {
@@ -355,6 +355,7 @@ static int omap_ehci_probe(struct udevice *dev)
struct ehci_omap_priv_data *priv = dev_get_priv(dev);
struct ehci_hccr *hccr;
struct ehci_hcor *hcor;
+ int ret;
priv->ehci = dev_read_addr_ptr(dev);
priv->portnr = dev_seq(dev);
@@ -363,6 +364,10 @@ static int omap_ehci_probe(struct udevice *dev)
hccr = (struct ehci_hccr *)&priv->ehci->hccapbase;
hcor = (struct ehci_hcor *)&priv->ehci->usbcmd;
+ ret = omap_ehci_hcd_init(0, &usbhs_bdata);
+ if (ret)
+ return ret;
+
return ehci_register(dev, hccr, hcor, NULL, 0, USB_INIT_HOST);
}
--
2.32.0
next prev parent reply other threads:[~2022-02-19 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 23:08 [PATCH 0/7] Migrate omap_ehci to use phy driver Adam Ford
2022-02-19 23:08 ` [PATCH 1/7] usb: ehci-omap: Drop dead code Adam Ford
2022-02-19 23:08 ` Adam Ford [this message]
2022-02-19 23:08 ` [PATCH 3/7] phy: nop-phy: Fix enabling reset Adam Ford
2022-02-19 23:08 ` [PATCH 4/7] usb: ehci-omap: Make Kconfig select PHY if USB_EHCI_OMAP Adam Ford
2022-02-19 23:08 ` [PATCH 5/7] usb: ehci-omap: Use PHY system to manage phy resets Adam Ford
2022-02-23 4:28 ` Marek Vasut
2022-02-19 23:08 ` [PATCH 6/7] usb: ehci-omap: Remove OMAP_EHCI_PHYx_RESET_GPIO from Kconfig Adam Ford
2022-02-19 23:08 ` [PATCH 7/7] configs: omap various: Remove OMAP_EHCI_PHY from defconfigs Adam Ford
2022-02-22 0:24 ` [PATCH 0/7] Migrate omap_ehci to use phy driver Derald Woods
2022-02-23 4:28 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220219230847.798484-3-aford173@gmail.com \
--to=aford173@gmail.com \
--cc=marex@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=woods.technical@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox