public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: u-boot@lists.denx.de
Cc: marex@denx.de, trini@konsulko.com, woods.technical@gmail.com,
	Adam Ford <aford173@gmail.com>
Subject: [PATCH 3/7] phy: nop-phy: Fix enabling reset
Date: Sat, 19 Feb 2022 17:08:43 -0600	[thread overview]
Message-ID: <20220219230847.798484-4-aford173@gmail.com> (raw)
In-Reply-To: <20220219230847.798484-1-aford173@gmail.com>

The reset function should place the phy into reset, while the
init function should take the phy out of reset.  Currently the
reset function takes it out of reset, and the init calls the
reset.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
 drivers/phy/nop-phy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/nop-phy.c b/drivers/phy/nop-phy.c
index b08eedd4d4..e2ee6e9206 100644
--- a/drivers/phy/nop-phy.c
+++ b/drivers/phy/nop-phy.c
@@ -28,7 +28,7 @@ static int nop_phy_reset(struct phy *phy)
 	if (!dm_gpio_is_valid(&priv->reset_gpio))
 		return 0;
 
-	return dm_gpio_set_value(&priv->reset_gpio, false);
+	return dm_gpio_set_value(&priv->reset_gpio, true);
 }
 #endif
 
@@ -44,7 +44,8 @@ static int nop_phy_init(struct phy *phy)
 	}
 
 #if CONFIG_IS_ENABLED(DM_GPIO)
-	ret = nop_phy_reset(phy);
+	/* Take phy out of reset */
+	ret = dm_gpio_set_value(&priv->reset_gpio, false);
 	if (ret) {
 		if (CONFIG_IS_ENABLED(CLK))
 			clk_disable_bulk(&priv->bulk);
-- 
2.32.0


  parent reply	other threads:[~2022-02-19 23:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19 23:08 [PATCH 0/7] Migrate omap_ehci to use phy driver Adam Ford
2022-02-19 23:08 ` [PATCH 1/7] usb: ehci-omap: Drop dead code Adam Ford
2022-02-19 23:08 ` [PATCH 2/7] usb: ehci-omap: Move omap_ehci_hcd_init to omap_ehci_probe Adam Ford
2022-02-19 23:08 ` Adam Ford [this message]
2022-02-19 23:08 ` [PATCH 4/7] usb: ehci-omap: Make Kconfig select PHY if USB_EHCI_OMAP Adam Ford
2022-02-19 23:08 ` [PATCH 5/7] usb: ehci-omap: Use PHY system to manage phy resets Adam Ford
2022-02-23  4:28   ` Marek Vasut
2022-02-19 23:08 ` [PATCH 6/7] usb: ehci-omap: Remove OMAP_EHCI_PHYx_RESET_GPIO from Kconfig Adam Ford
2022-02-19 23:08 ` [PATCH 7/7] configs: omap various: Remove OMAP_EHCI_PHY from defconfigs Adam Ford
2022-02-22  0:24 ` [PATCH 0/7] Migrate omap_ehci to use phy driver Derald Woods
2022-02-23  4:28   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220219230847.798484-4-aford173@gmail.com \
    --to=aford173@gmail.com \
    --cc=marex@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=woods.technical@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox