* [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code
@ 2022-02-26 16:13 Adam Ford
2022-02-27 1:54 ` Derald Woods
2022-03-14 13:07 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Adam Ford @ 2022-02-26 16:13 UTC (permalink / raw)
To: u-boot; +Cc: woods.technical, Adam Ford
The ethernet controller is DM compliant, and the device tree
defines it. There is no need to manually handle pulling
the ethernet out of reset.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/board/logicpd/am3517evm/am3517evm.c b/board/logicpd/am3517evm/am3517evm.c
index f014165928..e787441c74 100644
--- a/board/logicpd/am3517evm/am3517evm.c
+++ b/board/logicpd/am3517evm/am3517evm.c
@@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void)
*/
int misc_init_r(void)
{
- u32 reset;
-
omap_die_id_display();
am3517_evm_musb_init();
- /* ensure that the Ethernet module is out of reset */
- reset = readl(AM3517_IP_SW_RESET);
- reset &= (~CPGMACSS_SW_RST);
- writel(reset, AM3517_IP_SW_RESET);
-
return 0;
}
@@ -142,7 +135,6 @@ void set_muxconf_regs(void)
MUX_AM3517EVM();
}
-
#if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)
int board_eth_init(struct bd_info *bis)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code
2022-02-26 16:13 [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code Adam Ford
@ 2022-02-27 1:54 ` Derald Woods
2022-03-14 13:07 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Derald Woods @ 2022-02-27 1:54 UTC (permalink / raw)
To: Adam Ford; +Cc: U-Boot Mailing List
On Sat, Feb 26, 2022 at 10:13 AM Adam Ford <aford173@gmail.com> wrote:
> The ethernet controller is DM compliant, and the device tree
> defines it. There is no need to manually handle pulling
> the ethernet out of reset.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/board/logicpd/am3517evm/am3517evm.c
> b/board/logicpd/am3517evm/am3517evm.c
> index f014165928..e787441c74 100644
> --- a/board/logicpd/am3517evm/am3517evm.c
> +++ b/board/logicpd/am3517evm/am3517evm.c
> @@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void)
> */
> int misc_init_r(void)
> {
> - u32 reset;
> -
> omap_die_id_display();
>
> am3517_evm_musb_init();
>
> - /* ensure that the Ethernet module is out of reset */
> - reset = readl(AM3517_IP_SW_RESET);
> - reset &= (~CPGMACSS_SW_RST);
> - writel(reset, AM3517_IP_SW_RESET);
> -
> return 0;
> }
>
> @@ -142,7 +135,6 @@ void set_muxconf_regs(void)
> MUX_AM3517EVM();
> }
>
> -
> #if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)
> int board_eth_init(struct bd_info *bis)
> {
> --
> 2.34.1
>
>
Ethernet continues to work on AM3517 Zoom eXperimenter.
Tested-by: Derald D. Woods <woods.technical@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code
2022-02-26 16:13 [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code Adam Ford
2022-02-27 1:54 ` Derald Woods
@ 2022-03-14 13:07 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-03-14 13:07 UTC (permalink / raw)
To: Adam Ford; +Cc: u-boot, woods.technical
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Sat, Feb 26, 2022 at 10:13:09AM -0600, Adam Ford wrote:
> The ethernet controller is DM compliant, and the device tree
> defines it. There is no need to manually handle pulling
> the ethernet out of reset.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Tested-by: Derald D. Woods <woods.technical@gmail.com>
>
> diff --git a/board/logicpd/am3517evm/am3517evm.c b/board/logicpd/am3517evm/am3517evm.c
> index f014165928..e787441c74 100644
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-14 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-26 16:13 [PATCH] ARM: am3517-evm: Remove more non-DM legacy ethernet reset code Adam Ford
2022-02-27 1:54 ` Derald Woods
2022-03-14 13:07 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox