Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO

["Pali Rohár" <pali@kernel.org>]

On Friday 11 March 2022 22:02:39 Simon Glass wrote:
> Hi Pali,
> 
> On Fri, 11 Mar 2022 at 11:58, Pali Rohár <pali@kernel.org> wrote:
> >
> > On Wednesday 09 March 2022 23:20:11 Anatolij Gustschin wrote:
> > > Hi Pali,
> > >
> > > On Wed, 9 Mar 2022 20:44:50 +0100
> > > Pali Rohár pali@kernel.org wrote:
> > >
> > > > On Sunday 06 March 2022 11:44:22 Simon Glass wrote:
> > > > > Hi Pali,
> > > > >
> > > > > On Sun, 6 Mar 2022 at 08:25, Pali Rohár <pali@kernel.org> wrote:
> > > > > >
> > > > > > On Sunday 06 March 2022 07:42:03 Simon Glass wrote:
> > > > > > > Yes let's go with that.
> > > > > >
> > > > > > Done, I sent final version of the patch.
> > > > > >
> > > > > > > > > > > > > Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it
> > > > > > > > > > > > > is enabled in config file. I do not know why too.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Any idea?
> > > > > > > > > > > >
> > > > > > > > > > > > Not yet. There were some logo related changes recently, but if I
> > > > > > > > > > > > remember correctly, I tested them on wandboard and nitrogen6q
> > > > > > > > > > > > targets and with sandbox, and logo drawing worked there.
> > > > > > > > >
> > > > > > > > > Can you be more specific than 'broken'? What is broken about it?
> > > > > > > >
> > > > > > > > Does not work, logo is not drown on the screen.
> > > > > > >
> > > > > > > See video_bmp_display()  - I wonder if the particular depth you are
> > > > > > > using is not supported?
> > > > > >
> > > > > > Depth is 16bit which should be supported.
> > > > >
> > > > > But apparently isn't , at least in this case :-)
> > > >
> > > > Yea, something is broken there.
> > > >
> > > > > >
> > > > > > > Anyway you should be able to debug it there or
> > > > > > > using the bmp command. The file is drivers/video/u_boot_logo.bmp
> > > > > >
> > > > > > CONFIG_CMD_BMP=y is broken too. When I enable it then U-Boot freeze
> > > > > > after the line 'Loading Environment from <NULL>... OK'.
> > > > >
> > > > > OK I'm not sure why, but please investigate if you have time.
> > > >
> > > > I have looked at it and do not know. But probably it is because I
> > > > somehow have not caught how this new video code works...
> > > >
> > > > Anyway, I sent documentation update how to run u-boot for n900 in qemu:
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20220308175956.4522-1-pali@kernel.org/
> > > >
> > > > So it could help other people to look at issues which do not work
> > > > correctly in n900's u-boot without need to have n900 hardware.
> > >
> > > I've tested your v2 patches, and logo drawing works, but the logo
> > > appears for short time. Then it is later overwritten by boot menu.
> > >
> > > --
> > > Anatolij
> >
> > Hello! Thank you for checking. It is possible that qemu rending is
> > slower and reason why I did not see any logo.
> >
> > Anyway, this is now how CONFIG_VIDEO_LOGO worked. In previous U-Boot
> > version it drew logo on the screen and it was visible also in the boot
> > menu.
> >
> > Any idea what was changed? Or is there missing some another config
> > option to make logo visible?
> 
> I believe the cfb_console code had a way to keep the logo at the top
> with the text scrolling underneath. This has not been implemented in
> the video/vidconsole uclasses, although I suppose it could be.
> 
> Regards,
> Simon

Ok!