From: Tom Rini <trini@konsulko.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Simon Glass <sjg@chromium.org>,
Liviu Dudau <liviu.dudau@foss.arm.com>,
u-boot@lists.denx.de, Linus Walleij <linus.walleij@linaro.org>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 1/4] serial: Fix _serial_puts using \n\r instead of \r\n
Date: Fri, 15 Apr 2022 08:08:17 -0400 [thread overview]
Message-ID: <20220415120817.GP14282@bill-the-cat> (raw)
In-Reply-To: <20220404181800.2258698-2-sean.anderson@seco.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Mon, Apr 04, 2022 at 02:17:57PM -0400, Sean Anderson wrote:
> A string like "test\n" would be broken up into the following sequence of
> prints by _serial_puts:
>
> puts("test\n")
> putc('\r')
>
> Although functionally this is the same as \r\n, it is not the standard
> sequence and caused tests to fail. Fix this by excluding the '\n' from
> the initial print. The above string will now be broken up like
>
> puts("test")
> puts("\r\n")
>
> Since we may now need to call ops->puts twice (with the associated retry
> logic), break that part of the function off into a helper.
>
> Fixes: 7a76347189 ("serial: dm: Add support for puts")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-04-15 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 18:17 [PATCH 0/4] serial: Finish adding puts support Sean Anderson
2022-04-04 18:17 ` [PATCH 1/4] serial: Fix _serial_puts using \n\r instead of \r\n Sean Anderson
2022-04-15 12:08 ` Tom Rini [this message]
2022-04-04 18:17 ` [PATCH 2/4] serial: sandbox: Implement puts Sean Anderson
2022-04-15 12:08 ` Tom Rini
2022-04-04 18:17 ` [PATCH 3/4] test: serial: Add test for putc/puts Sean Anderson
2022-04-15 12:08 ` Tom Rini
2022-04-04 18:18 ` [PATCH 4/4] serial: smh: Implement puts for DM Sean Anderson
2022-04-15 12:08 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415120817.GP14282@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=linus.walleij@linaro.org \
--cc=liviu.dudau@foss.arm.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox