From: Tom Rini <trini@konsulko.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: ryan_chen@aspeedtech.com, chiawei_wang@aspeedtech.com,
BMC-SW@aspeedtech.com, andrew@aj.id.au, u-boot@lists.denx.de
Subject: Re: [PATCH] gpio: aspeed: Fix incorrect offset of read back register.
Date: Wed, 20 Apr 2022 09:12:02 -0400 [thread overview]
Message-ID: <20220420131202.GG3045430@bill-the-cat> (raw)
In-Reply-To: <20220413053451.2975-1-billy_tsai@aspeedtech.com>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Wed, Apr 13, 2022 at 01:34:51PM +0800, Billy Tsai wrote:
> The offset of the current read back register is the value of the gpio pin,
> not the value written for the gpio output.
> This patch fix it to avoid the other gpio output value controlled by the
> same register being set incorrectly.
>
> Fixes: 7ad889b0f37a ("gpio: Add Aspeed GPIO driver")
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2022-04-20 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 5:34 [PATCH] gpio: aspeed: Fix incorrect offset of read back register Billy Tsai
2022-04-14 6:40 ` Ryan Chen
2022-04-20 13:12 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420131202.GG3045430@bill-the-cat \
--to=trini@konsulko.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=ryan_chen@aspeedtech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox