* [PATCH] spl_imx_romapi: Remove extraneous character
@ 2022-04-21 14:01 Fabio Estevam
2022-04-21 14:09 ` Marek Vasut
2022-04-28 8:59 ` Peng Fan (OSS)
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-04-21 14:01 UTC (permalink / raw)
To: sbabic; +Cc: uboot-imx, u-boot, marex, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...
Remove the extraneous "&" character, so that the correct output
can be seen.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/spl_imx_romapi.c b/arch/arm/mach-imx/spl_imx_romapi.c
index c47f5a6bdb44..2996d2761690 100644
--- a/arch/arm/mach-imx/spl_imx_romapi.c
+++ b/arch/arm/mach-imx/spl_imx_romapi.c
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
}
imagesize = img_info_size(phdr);
- printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+ printf("Find img info 0x%p, size %d\n", phdr, imagesize);
if (p - phdr < imagesize) {
imagesize -= p - phdr;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] spl_imx_romapi: Remove extraneous character
2022-04-21 14:01 [PATCH] spl_imx_romapi: Remove extraneous character Fabio Estevam
@ 2022-04-21 14:09 ` Marek Vasut
2022-04-28 8:59 ` Peng Fan (OSS)
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2022-04-21 14:09 UTC (permalink / raw)
To: Fabio Estevam, sbabic; +Cc: uboot-imx, u-boot, Fabio Estevam
On 4/21/22 16:01, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Currently the following output is shown:
> ...
> Trying to boot from BOOTROM
> Find img info 0x&48020a00, size 872
> ...
>
> Remove the extraneous "&" character, so that the correct output
> can be seen.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spl_imx_romapi: Remove extraneous character
2022-04-21 14:01 [PATCH] spl_imx_romapi: Remove extraneous character Fabio Estevam
2022-04-21 14:09 ` Marek Vasut
@ 2022-04-28 8:59 ` Peng Fan (OSS)
2022-07-12 20:02 ` Tim Harvey
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan (OSS) @ 2022-04-28 8:59 UTC (permalink / raw)
To: Fabio Estevam, sbabic@denx.de
Cc: dl-uboot-imx, u-boot@lists.denx.de, marex@denx.de, Fabio Estevam
On 2022/4/21 22:01, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Currently the following output is shown:
> ...
> Trying to boot from BOOTROM
> Find img info 0x&48020a00, size 872
> ...
>
> Remove the extraneous "&" character, so that the correct output
> can be seen.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/spl_imx_romapi.c b/arch/arm/mach-imx/spl_imx_romapi.c
> index c47f5a6bdb44..2996d2761690 100644
> --- a/arch/arm/mach-imx/spl_imx_romapi.c
> +++ b/arch/arm/mach-imx/spl_imx_romapi.c
> @@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
> }
>
> imagesize = img_info_size(phdr);
> - printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
> + printf("Find img info 0x%p, size %d\n", phdr, imagesize);
>
> if (p - phdr < imagesize) {
> imagesize -= p - phdr;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] spl_imx_romapi: Remove extraneous character
2022-04-28 8:59 ` Peng Fan (OSS)
@ 2022-07-12 20:02 ` Tim Harvey
0 siblings, 0 replies; 4+ messages in thread
From: Tim Harvey @ 2022-07-12 20:02 UTC (permalink / raw)
To: Fabio Estevam, sbabic@denx.de
Cc: Peng Fan (OSS), dl-uboot-imx, u-boot@lists.denx.de, marex@denx.de,
Fabio Estevam
On Thu, Apr 28, 2022 at 2:00 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
>
>
> On 2022/4/21 22:01, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Currently the following output is shown:
> > ...
> > Trying to boot from BOOTROM
> > Find img info 0x&48020a00, size 872
> > ...
> >
> > Remove the extraneous "&" character, so that the correct output
> > can be seen.
> >
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
>
> Acked-by: Peng Fan <peng.fan@nxp.com>
>
> > ---
> > arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-imx/spl_imx_romapi.c b/arch/arm/mach-imx/spl_imx_romapi.c
> > index c47f5a6bdb44..2996d2761690 100644
> > --- a/arch/arm/mach-imx/spl_imx_romapi.c
> > +++ b/arch/arm/mach-imx/spl_imx_romapi.c
> > @@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct spl_image_info *spl_image,
> > }
> >
> > imagesize = img_info_size(phdr);
> > - printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
> > + printf("Find img info 0x%p, size %d\n", phdr, imagesize);
> >
> > if (p - phdr < imagesize) {
> > imagesize -= p - phdr;
> >
Stefano and Fabio,
This patch was ack'd but never seemed to make it into the imx tree and
I don't see it in Peng's queue on patchwork any more.
Now that the merge window is open, when are you planning on working
through the current imx patch queue? I believe there are several
patches that will need to be rebased due to collisions.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-12 20:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-21 14:01 [PATCH] spl_imx_romapi: Remove extraneous character Fabio Estevam
2022-04-21 14:09 ` Marek Vasut
2022-04-28 8:59 ` Peng Fan (OSS)
2022-07-12 20:02 ` Tim Harvey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox