public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michael Trimarchi <michael@amarulasolutions.com>
To: Han Xu <han.xu@nxp.com>, U-Boot-Denx <u-boot@lists.denx.de>
Cc: Ye Li <ye.li@nxp.com>, Stefano Babic <sbabic@denx.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Fabio Estevam <festevam@denx.de>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Sean Anderson <sean.anderson@seco.com>,
	linux-amarula@amarulasolutions.com,
	Jagan Teki <jagan@amarulasolutions.com>,
	Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
	Tom Rini <trini@konsulko.com>, Fabio Estevam <festevam@gmail.com>,
	Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH V4 1/5] nand: raw: mxs_nand: Fix specific hook registration
Date: Sun, 15 May 2022 11:35:30 +0200	[thread overview]
Message-ID: <20220515093534.1737172-2-michael@amarulasolutions.com> (raw)
In-Reply-To: <20220515093534.1737172-1-michael@amarulasolutions.com>

Move the hook after nand_scan_tail is called. The hook must be replaced
to the mxs specific one but those must to be assignment later in the
probe function.

With this fix markbad is working again. Before this change:

nand markbad 0xDEC00
NXS NAND: Writing OOB isn't supported
NXS NAND: Writing OOB isn't supported
block 0x000dec00 NOT marked as bad! ERROR 0

Cc: Han Xu <han.xu@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>
Acked-by: Han Xu <han.xu@nxp.com>
Tested-By: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
V3->V4:
	- none
V2->V3:
	- Add tested-by from Tim
	- Add ack from Han Xu
V1->V2:
	- Adjust the commit message
	- Add Cc Han Xu and Fabio
---
 drivers/mtd/nand/raw/mxs_nand.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
index ee5d7fde9c..53f24b9c4b 100644
--- a/drivers/mtd/nand/raw/mxs_nand.c
+++ b/drivers/mtd/nand/raw/mxs_nand.c
@@ -1246,22 +1246,6 @@ int mxs_nand_setup_ecc(struct mtd_info *mtd)
 	/* Enable BCH complete interrupt */
 	writel(BCH_CTRL_COMPLETE_IRQ_EN, &bch_regs->hw_bch_ctrl_set);
 
-	/* Hook some operations at the MTD level. */
-	if (mtd->_read_oob != mxs_nand_hook_read_oob) {
-		nand_info->hooked_read_oob = mtd->_read_oob;
-		mtd->_read_oob = mxs_nand_hook_read_oob;
-	}
-
-	if (mtd->_write_oob != mxs_nand_hook_write_oob) {
-		nand_info->hooked_write_oob = mtd->_write_oob;
-		mtd->_write_oob = mxs_nand_hook_write_oob;
-	}
-
-	if (mtd->_block_markbad != mxs_nand_hook_block_markbad) {
-		nand_info->hooked_block_markbad = mtd->_block_markbad;
-		mtd->_block_markbad = mxs_nand_hook_block_markbad;
-	}
-
 	return 0;
 }
 
@@ -1467,6 +1451,22 @@ int mxs_nand_init_ctrl(struct mxs_nand_info *nand_info)
 	if (err)
 		goto err_free_buffers;
 
+	/* Hook some operations at the MTD level. */
+	if (mtd->_read_oob != mxs_nand_hook_read_oob) {
+		nand_info->hooked_read_oob = mtd->_read_oob;
+		mtd->_read_oob = mxs_nand_hook_read_oob;
+	}
+
+	if (mtd->_write_oob != mxs_nand_hook_write_oob) {
+		nand_info->hooked_write_oob = mtd->_write_oob;
+		mtd->_write_oob = mxs_nand_hook_write_oob;
+	}
+
+	if (mtd->_block_markbad != mxs_nand_hook_block_markbad) {
+		nand_info->hooked_block_markbad = mtd->_block_markbad;
+		mtd->_block_markbad = mxs_nand_hook_block_markbad;
+	}
+
 	err = nand_register(0, mtd);
 	if (err)
 		goto err_free_buffers;
-- 
2.25.1


  reply	other threads:[~2022-05-15  9:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15  9:35 [PATCH V4 0/5] MXS nand fixes in SPL Michael Trimarchi
2022-05-15  9:35 ` Michael Trimarchi [this message]
2022-05-20 13:42   ` [PATCH V4 1/5] nand: raw: mxs_nand: Fix specific hook registration sbabic
2022-05-15  9:35 ` [PATCH V4 2/5] mtd: nand: mxs_nand_spl: Fix bad block skipping Michael Trimarchi
2022-05-20 13:43   ` sbabic
2022-05-15  9:35 ` [PATCH V4 3/5] arm: mach-imx: cmd_nandbcb fix bad block handling Michael Trimarchi
2022-05-20 13:42   ` sbabic
2022-05-15  9:35 ` [PATCH V4 4/5] spl: spl_nand: Fix bad block handling in fitImage Michael Trimarchi
2022-05-20 13:41   ` sbabic
2022-05-15  9:35 ` [PATCH V4 5/5] board: bsh: Switch to nand spl load instead of romapi Michael Trimarchi
2022-05-18 10:17   ` Michael Nazzareno Trimarchi
2022-05-18 11:53     ` Stefano Babic
2022-05-15 12:54 ` [PATCH V4 0/5] MXS nand fixes in SPL Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220515093534.1737172-2-michael@amarulasolutions.com \
    --to=michael@amarulasolutions.com \
    --cc=ariel.dalessandro@collabora.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=sbabic@denx.de \
    --cc=sean.anderson@seco.com \
    --cc=tharvey@gateworks.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox