From: Michael Trimarchi <michael@amarulasolutions.com>
To: Han Xu <han.xu@nxp.com>, U-Boot-Denx <u-boot@lists.denx.de>
Cc: Ye Li <ye.li@nxp.com>, Stefano Babic <sbabic@denx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Fabio Estevam <festevam@denx.de>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Sean Anderson <sean.anderson@seco.com>,
linux-amarula@amarulasolutions.com,
Jagan Teki <jagan@amarulasolutions.com>,
Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
Tom Rini <trini@konsulko.com>, Fabio Estevam <festevam@gmail.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH V4 4/5] spl: spl_nand: Fix bad block handling in fitImage
Date: Sun, 15 May 2022 11:35:33 +0200 [thread overview]
Message-ID: <20220515093534.1737172-5-michael@amarulasolutions.com> (raw)
In-Reply-To: <20220515093534.1737172-1-michael@amarulasolutions.com>
If the fitImage has some bad block in fit image area, the
offset must be recalulcated. This should be done always.
After implementing it in mxs now is possible to call the function
even for that platform.
Cc: Fabio Estevam <festevam@gmail.com>
Tested-By: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
V3->V4:
- none
V2->V3:
- Add tested-by from Tim
- Add ack from Han Xu
V1->V2:
- move out from RFC
---
common/spl/spl_nand.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c
index fc61b447a5..82a10ffa63 100644
--- a/common/spl/spl_nand.c
+++ b/common/spl/spl_nand.c
@@ -43,15 +43,12 @@ static ulong spl_nand_fit_read(struct spl_load_info *load, ulong offs,
ulong size, void *dst)
{
int err;
-#ifdef CONFIG_SYS_NAND_BLOCK_SIZE
ulong sector;
sector = *(int *)load->priv;
- offs = sector + nand_spl_adjust_offset(sector, offs - sector);
-#else
offs *= load->bl_len;
size *= load->bl_len;
-#endif
+ offs = sector + nand_spl_adjust_offset(sector, offs - sector);
err = nand_spl_load_image(offs, size, dst);
if (err)
return 0;
--
2.25.1
next prev parent reply other threads:[~2022-05-15 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 9:35 [PATCH V4 0/5] MXS nand fixes in SPL Michael Trimarchi
2022-05-15 9:35 ` [PATCH V4 1/5] nand: raw: mxs_nand: Fix specific hook registration Michael Trimarchi
2022-05-20 13:42 ` sbabic
2022-05-15 9:35 ` [PATCH V4 2/5] mtd: nand: mxs_nand_spl: Fix bad block skipping Michael Trimarchi
2022-05-20 13:43 ` sbabic
2022-05-15 9:35 ` [PATCH V4 3/5] arm: mach-imx: cmd_nandbcb fix bad block handling Michael Trimarchi
2022-05-20 13:42 ` sbabic
2022-05-15 9:35 ` Michael Trimarchi [this message]
2022-05-20 13:41 ` [PATCH V4 4/5] spl: spl_nand: Fix bad block handling in fitImage sbabic
2022-05-15 9:35 ` [PATCH V4 5/5] board: bsh: Switch to nand spl load instead of romapi Michael Trimarchi
2022-05-18 10:17 ` Michael Nazzareno Trimarchi
2022-05-18 11:53 ` Stefano Babic
2022-05-15 12:54 ` [PATCH V4 0/5] MXS nand fixes in SPL Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515093534.1737172-5-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=ariel.dalessandro@collabora.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=han.xu@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=miquel.raynal@bootlin.com \
--cc=sbabic@denx.de \
--cc=sean.anderson@seco.com \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox