Re: [PATCH 4/8] board: qualcomm: Add support for dragonboard845c

[Daniel Thompson <daniel.thompson@linaro.org>]

On Mon, Jul 04, 2022 at 06:28:41PM +0530, Sumit Garg wrote:
> diff --git a/arch/arm/dts/dragonboard845c-uboot.dtsi b/arch/arm/dts/dragonboard845c-uboot.dtsi
> new file mode 100644
> index 0000000000..8b5a7ee573
> --- /dev/null
> +++ b/arch/arm/dts/dragonboard845c-uboot.dtsi
> @@ -0,0 +1,37 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * U-Boot addition to handle Qualcomm Robotics RB3 Development Platform
> + * (dragonboard845c) pins
> + *
> + * (C) Copyright 2022 Sumit Garg <sumit.garg@linaro.org>
> + */
> +
> +/
> +{
> +	soc {
> +		u-boot,dm-pre-reloc;
> +
> +		serial@a84000 {
> +			u-boot,dm-pre-reloc;
> +		};
> +
> +		clock-controller@100000 {
> +			u-boot,dm-pre-reloc;
> +		};
> +
> +		pinctrl_north@3900000 {
> +			u-boot,dm-pre-reloc;
> +		};
> +	};
> +};

These additional u-boot,dm-pre-reloc changes are different to the ones
that appear in starqltechn-uboot.dtsi . That suggests that either patch 1
is not actually removing redundant properties or that the DB845C port is
wrong.


> +config TARGET_DRAGONBOARD845C
> +	bool "96Boards Dragonboard 845C"
> +	help
> +	  Support for 96Boards Dragonboard 845C aka Robotics RB3 Development
> +	  Platform. This board complies with 96Board Open Platform

Nitpicking but... s/96Board/96Boards/


Daniel.