From: Tom Rini <trini@konsulko.com>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Marek Vasut <marex@denx.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [PATCH 04/11] board: ti: j721s2: Add support to update board_name for am68-sk
Date: Thu, 27 Oct 2022 08:59:45 -0400 [thread overview]
Message-ID: <20221027125945.GI2020586@bill-the-cat> (raw)
In-Reply-To: <20221027104846.11820-5-sinthu.raja@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
On Thu, Oct 27, 2022 at 04:18:39PM +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> Update setup_board_eeprom_env() to choose the right board name
> for am68-sk.
>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
> board/ti/j721s2/evm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/board/ti/j721s2/evm.c b/board/ti/j721s2/evm.c
> index e09adc8ad3..e3c75b35b6 100644
> --- a/board/ti/j721s2/evm.c
> +++ b/board/ti/j721s2/evm.c
> @@ -28,6 +28,8 @@
>
> #define board_is_j721s2_som() board_ti_k3_is("J721S2X-PM1-SOM")
>
> +#define board_is_am68_sk_som() board_ti_k3_is("AM68-SK-SOM")
> +
> DECLARE_GLOBAL_DATA_PTR;
>
> int board_init(void)
> @@ -136,6 +138,8 @@ static void setup_board_eeprom_env(void)
>
> if (board_is_j721s2_som())
> name = "j721s2";
> + else if (board_is_am68_sk_som())
> + name = "am68-sk";
> else
> printf("Unidentified board claims %s in eeprom header\n",
> board_ti_get_name());
What I'd like to see is moving the board_is_XXX defines moved down to by
do_board_detect() and then a comment inside the start of that block to
explain that all of this functionality is specific to the EVM family
designs. This will hopefully make it clearer that when making a custom
board that doesn't have this EEPROM all of this can be omitted and we
don't loose the "mini" U-Boot concept for this SoC.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-10-27 12:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 10:48 [PATCH 00/11] AM68 SK: Add initial support for AM68 Starter Kit Sinthu Raja
2022-10-27 10:48 ` [PATCH 01/11] configs: j721s2_evm_r5: Enable support for building multiple dtbs into FIT Sinthu Raja
2022-10-27 10:48 ` [PATCH 02/11] configs: j721s2_evm_a72: " Sinthu Raja
2022-10-27 10:48 ` [PATCH 03/11] configs: j721s2_evm: Enable configs to store env in MMC FAT partition Sinthu Raja
2022-10-27 10:48 ` [PATCH 04/11] board: ti: j721s2: Add support to update board_name for am68-sk Sinthu Raja
2022-10-27 12:59 ` Tom Rini [this message]
2022-10-27 10:48 ` [PATCH 05/11] board: ti: j721s2: Enable support for reading EEPROM at next alternate address Sinthu Raja
2022-10-27 10:48 ` [PATCH 06/11] board: ti: j721s2: Add support for detecting multiple device trees Sinthu Raja
2022-10-27 13:02 ` Tom Rini
2022-10-27 10:48 ` [PATCH 07/11] arm: j721s2: Add support for selecting DT based on EEPROM Sinthu Raja
2022-10-27 13:04 ` Tom Rini
2022-10-27 10:48 ` [PATCH 08/11] arm: dts: Add initial support for AM68 Starter Kit System on Module Sinthu Raja
2022-10-27 13:06 ` Tom Rini
2022-10-27 10:48 ` [PATCH 09/11] arm: dts: Add support for A72 specific AM68 Starter Kit Base Board Sinthu Raja
2022-10-27 10:48 ` [PATCH 10/11] arm: dts: k3-am68-sk: Add r5 specific dt support Sinthu Raja
2022-10-27 10:48 ` [PATCH 11/11] include: configs: Update env for selecting right dtb Sinthu Raja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027125945.GI2020586@bill-the-cat \
--to=trini@konsulko.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox