Re: [PATCH v2 1/2] wandboard: Pass mmc aliases

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3195 bytes --]

On Sun, Jan 08, 2023 at 08:36:21AM -0300, Fabio Estevam wrote:
> Hi Tom,
> 
> On Tue, Jan 3, 2023 at 8:00 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Hi Tom and Stefano,
> >
> > On Fri, Nov 4, 2022 at 8:13 AM Fabio Estevam <festevam@gmail.com> wrote:
> > >
> > > From: Fabio Estevam <festevam@denx.de>
> > >
> > > Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi.
> > >
> > > After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl:
> > > synchronise device trees with linux"), the aliases node is gone as
> > > the upstream version does not have it.
> > >
> > > This causes a regression in which the SD card cannot be found anymore:
> > >
> > > Since commit  the aliases node has been removed
> > > U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -0300)
> > >
> > > CPU:   Freescale i.MX6QP rev1.0 at 792 MHz
> > > Reset cause: POR
> > > DRAM:  2 GiB
> > > Core:  62 devices, 17 uclasses, devicetree: separate
> > > PMIC:  PFUZE100 ID=0x10
> > > MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
> > > Loading Environment from MMC... MMC: no card present
> > > *** Warning - No block device, using default environment
> > >
> > > Fix it by passing the alias node in the u-boot.dtsi file to
> > > restore the original behaviour where the SD card (esdhc3) was
> > > mapped to mmc0.
> > >
> > > Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux")
> > > Signed-off-by: Fabio Estevam <festevam@denx.de>
> > > ---
> > > Changes since v1:
> > > - Add patch numbering.
> >
> > Please consider applying this one to 2023.01 to fix the boot regression.
> 
> Could you please apply this one directly to 2023.01 to fix the boot regression?

It's already been merged:
commit f827f84d3f5607d0b33e927f6127a888e7bd664f
Author:     Fabio Estevam <festevam@denx.de>
AuthorDate: Fri Nov 4 08:12:54 2022 -0300
Commit:     Stefano Babic <sbabic@denx.de>
CommitDate: Wed Nov 9 17:12:31 2022 +0100

    wandboard: Pass mmc aliases
    
    Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi.
    
    After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl:
    synchronise device trees with linux"), the aliases node is gone as
    the upstream version does not have it.
    
    This causes a regression in which the SD card cannot be found anymore:
    
    Since commit  the aliases node has been removed
    U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -0300)
    
    CPU:   Freescale i.MX6QP rev1.0 at 792 MHz
    Reset cause: POR
    DRAM:  2 GiB
    Core:  62 devices, 17 uclasses, devicetree: separate
    PMIC:  PFUZE100 ID=0x10
    MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
    Loading Environment from MMC... MMC: no card present
    *** Warning - No block device, using default environment
    
    Fix it by passing the alias node in the u-boot.dtsi file to
    restore the original behaviour where the SD card (esdhc3) was
    mapped to mmc0.
    
    Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with linux")
    Signed-off-by: Fabio Estevam <festevam@denx.de>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]