From: Tom Rini <trini@konsulko.com>
To: Nikhil M Jain <n-jain1@ti.com>
Cc: u-boot@lists.denx.de, vigneshr@ti.com, nm@ti.com
Subject: Re: [PATCH] include: configs: am62x_evm: Add .env file for Am62x
Date: Mon, 23 Jan 2023 14:20:02 -0500 [thread overview]
Message-ID: <20230123192002.GA631605@bill-the-cat> (raw)
In-Reply-To: <20230123063018.6061-1-n-jain1@ti.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Mon, Jan 23, 2023 at 12:00:18PM +0530, Nikhil M Jain wrote:
> Use .env file for setting board related environment variables,
> in place of am62x_evm.h file. Except for BOOTENV settings, as
> config_distro_boot.env file doesn't exist.
>
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
> ---
> board/ti/am62x/am62x.env | 105 ++++++++++++++++++++++++++++++++++++
> include/configs/am62x_evm.h | 43 ---------------
> 2 files changed, 105 insertions(+), 43 deletions(-)
> create mode 100644 board/ti/am62x/am62x.env
>
> diff --git a/board/ti/am62x/am62x.env b/board/ti/am62x/am62x.env
> new file mode 100644
> index 0000000000..3d4ab84fa3
> --- /dev/null
> +++ b/board/ti/am62x/am62x.env
> @@ -0,0 +1,105 @@
> +#define CFG_SYS_SDRAM_BASE1 0x880000000
This isn't used, please remove. Otherwise looks good, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-01-23 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 6:30 [PATCH] include: configs: am62x_evm: Add .env file for Am62x Nikhil M Jain
2023-01-23 19:20 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123192002.GA631605@bill-the-cat \
--to=trini@konsulko.com \
--cc=n-jain1@ti.com \
--cc=nm@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox