* [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads
@ 2022-12-15 14:51 Arnaud Ferraris
2022-12-15 15:07 ` Fabio Estevam
2023-01-31 20:33 ` sbabic
0 siblings, 2 replies; 3+ messages in thread
From: Arnaud Ferraris @ 2022-12-15 14:51 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot,
angus.ainslie
Cc: Arnaud Ferraris
When routing UART4 using the ECSPI2 pads, register
IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only
when dealing with RX, as its name suggests.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
---
arch/arm/include/asm/arch-imx8m/imx8mq_pins.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
index c71913f209..16d418c687 100644
--- a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
+++ b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
@@ -538,7 +538,7 @@ enum {
IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10 = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0),
IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0),
- IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0),
+ IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0),
IMX8MQ_PAD_ECSPI2_MOSI__GPIO5_IO11 = IOMUX_PAD(0x0470, 0x0208, 5, 0x0000, 0, 0),
IMX8MQ_PAD_ECSPI2_MISO__ECSPI2_MISO = IOMUX_PAD(0x0474, 0x020C, 0, 0x0000, 0, 0),
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads
2022-12-15 14:51 [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads Arnaud Ferraris
@ 2022-12-15 15:07 ` Fabio Estevam
2023-01-31 20:33 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-12-15 15:07 UTC (permalink / raw)
To: Arnaud Ferraris
Cc: Stefano Babic, NXP i . MX U-Boot Team, u-boot, angus.ainslie
On Thu, Dec 15, 2022 at 11:51 AM Arnaud Ferraris
<arnaud.ferraris@collabora.com> wrote:
> diff --git a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
> index c71913f209..16d418c687 100644
> --- a/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
> +++ b/arch/arm/include/asm/arch-imx8m/imx8mq_pins.h
> @@ -538,7 +538,7 @@ enum {
> IMX8MQ_PAD_ECSPI2_SCLK__GPIO5_IO10 = IOMUX_PAD(0x046C, 0x0204, 5, 0x0000, 0, 0),
>
> IMX8MQ_PAD_ECSPI2_MOSI__ECSPI2_MOSI = IOMUX_PAD(0x0470, 0x0208, 0, 0x0000, 0, 0),
> - IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x050C, 1, 0),
> + IMX8MQ_PAD_ECSPI2_MOSI__UART4_TX = IOMUX_PAD(0x0470, 0x0208, 1, 0x0000, 0, 0),
Yes, the DT definition does the same:
#define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DCE_TX
0x208 0x470 0x000 0x1 0x0
#define MX8MQ_IOMUXC_ECSPI2_MOSI_UART4_DTE_RX
0x208 0x470 0x50C 0x1 0x1
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads
2022-12-15 14:51 [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads Arnaud Ferraris
2022-12-15 15:07 ` Fabio Estevam
@ 2023-01-31 20:33 ` sbabic
1 sibling, 0 replies; 3+ messages in thread
From: sbabic @ 2023-01-31 20:33 UTC (permalink / raw)
To: Arnaud Ferraris, u-boot
> When routing UART4 using the ECSPI2 pads, register
> IOMUXC_UART4_RXD_SELECT_INPUT (offset 0x050C) should be changed only
> when dealing with RX, as its name suggests.
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-31 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 14:51 [PATCH] imx8mq_pins: fix configuration for UART4 on ECSPI2 pads Arnaud Ferraris
2022-12-15 15:07 ` Fabio Estevam
2023-01-31 20:33 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox