* [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs
@ 2023-02-08 8:15 Dario Binacchi
2023-02-13 13:28 ` Michael Nazzareno Trimarchi
2023-03-31 8:52 ` sbabic
0 siblings, 2 replies; 4+ messages in thread
From: Dario Binacchi @ 2023-02-08 8:15 UTC (permalink / raw)
To: u-boot
Cc: Tom Rini, Fabio Estevam, Stefano Babic, Dario Binacchi,
Fabio Estevam, Ariel D'Alessandro, Michael Trimarchi,
linux-amarula
The Linux kernel device tree already specifies the device to be used for
boot console output with a stdout-path property under /chosen.
Commit 36b661dc919da ("Merge branch 'next'") re-added the console
setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove
console from bootargs") had previously removed.
Fixes: 36b661dc919da ("Merge branch 'next'")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
---
Changes in v2:
- Add the 'Reviewed-by' tag.
- Improve commit message.
include/configs/imx8mn_bsh_smm_s2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
index e97b8e871d22..deeed9c2f582 100644
--- a/include/configs/imx8mn_bsh_smm_s2.h
+++ b/include/configs/imx8mn_bsh_smm_s2.h
@@ -14,7 +14,7 @@
#include <config_distro_bootcmd.h>
#define NANDARGS \
- "nandargs=setenv bootargs console=${console} " \
+ "nandargs=setenv bootargs " \
"${optargs} " \
"mtdparts=${mtdparts} " \
"root=${nandroot} " \
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-02-08 8:15 [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs Dario Binacchi
@ 2023-02-13 13:28 ` Michael Nazzareno Trimarchi
2023-02-13 13:35 ` Stefano Babic
2023-03-31 8:52 ` sbabic
1 sibling, 1 reply; 4+ messages in thread
From: Michael Nazzareno Trimarchi @ 2023-02-13 13:28 UTC (permalink / raw)
To: Dario Binacchi
Cc: u-boot, Tom Rini, Fabio Estevam, Stefano Babic, Fabio Estevam,
Ariel D'Alessandro, linux-amarula
Hi Stefano
On Wed, Feb 8, 2023 at 9:15 AM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:
>
> The Linux kernel device tree already specifies the device to be used for
> boot console output with a stdout-path property under /chosen.
>
> Commit 36b661dc919da ("Merge branch 'next'") re-added the console
> setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove
> console from bootargs") had previously removed.
>
> Fixes: 36b661dc919da ("Merge branch 'next'")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
>
> ---
>
> Changes in v2:
> - Add the 'Reviewed-by' tag.
> - Improve commit message.
>
> include/configs/imx8mn_bsh_smm_s2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
> index e97b8e871d22..deeed9c2f582 100644
> --- a/include/configs/imx8mn_bsh_smm_s2.h
> +++ b/include/configs/imx8mn_bsh_smm_s2.h
> @@ -14,7 +14,7 @@
> #include <config_distro_bootcmd.h>
>
> #define NANDARGS \
> - "nandargs=setenv bootargs console=${console} " \
> + "nandargs=setenv bootargs " \
> "${optargs} " \
> "mtdparts=${mtdparts} " \
> "root=${nandroot} " \
> --
This patch is a regression fix, can you pick it?
Michael
> 2.32.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-02-13 13:28 ` Michael Nazzareno Trimarchi
@ 2023-02-13 13:35 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2023-02-13 13:35 UTC (permalink / raw)
To: Michael Nazzareno Trimarchi, Dario Binacchi
Cc: u-boot, Tom Rini, Fabio Estevam, Stefano Babic, Fabio Estevam,
Ariel D'Alessandro, linux-amarula
On 13.02.23 14:28, Michael Nazzareno Trimarchi wrote:
> Hi Stefano
>
> On Wed, Feb 8, 2023 at 9:15 AM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
>>
>> The Linux kernel device tree already specifies the device to be used for
>> boot console output with a stdout-path property under /chosen.
>>
>> Commit 36b661dc919da ("Merge branch 'next'") re-added the console
>> setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove
>> console from bootargs") had previously removed.
>>
>> Fixes: 36b661dc919da ("Merge branch 'next'")
>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>> Reviewed-by: Fabio Estevam <festevam@denx.de>
>>
>> ---
>>
>> Changes in v2:
>> - Add the 'Reviewed-by' tag.
>> - Improve commit message.
>>
>> include/configs/imx8mn_bsh_smm_s2.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/imx8mn_bsh_smm_s2.h b/include/configs/imx8mn_bsh_smm_s2.h
>> index e97b8e871d22..deeed9c2f582 100644
>> --- a/include/configs/imx8mn_bsh_smm_s2.h
>> +++ b/include/configs/imx8mn_bsh_smm_s2.h
>> @@ -14,7 +14,7 @@
>> #include <config_distro_bootcmd.h>
>>
>> #define NANDARGS \
>> - "nandargs=setenv bootargs console=${console} " \
>> + "nandargs=setenv bootargs " \
>> "${optargs} " \
>> "mtdparts=${mtdparts} " \
>> "root=${nandroot} " \
>> --
>
> This patch is a regression fix, can you pick it?
I'll do it, thanks !
Stefano
>
> Michael
>
>> 2.32.0
>>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs
2023-02-08 8:15 [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs Dario Binacchi
2023-02-13 13:28 ` Michael Nazzareno Trimarchi
@ 2023-03-31 8:52 ` sbabic
1 sibling, 0 replies; 4+ messages in thread
From: sbabic @ 2023-03-31 8:52 UTC (permalink / raw)
To: Dario Binacchi, u-boot
> The Linux kernel device tree already specifies the device to be used for
> boot console output with a stdout-path property under /chosen.
> Commit 36b661dc919da ("Merge branch 'next'") re-added the console
> setting that commit bede82f750752 ("configs: imx8mn_bsh_smm_s2: remove
> console from bootargs") had previously removed.
> Fixes: 36b661dc919da ("Merge branch 'next'")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-31 8:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 8:15 [RESEND PATCH v2] configs: imx8mn_bsh_smm_s2: remove console from bootargs Dario Binacchi
2023-02-13 13:28 ` Michael Nazzareno Trimarchi
2023-02-13 13:35 ` Stefano Babic
2023-03-31 8:52 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox