From: Tom Rini <trini@konsulko.com>
To: Evgeny Bachinin <EABachinin@sberdevices.ru>
Cc: Simon Glass <sjg@chromium.org>,
Hector Palacios <hector.palacios@digi.com>,
Marek Vasut <marex@denx.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
John Keeping <john@metanate.com>,
u-boot@lists.denx.de, kernel@sberdevices.ru,
evgen89bachinin@gmail.com
Subject: Re: [PATCH v2 1/4] cli: run_commandf(): small fixups
Date: Fri, 31 Mar 2023 10:15:13 -0400 [thread overview]
Message-ID: <20230331141513.GD13222@bill-the-cat> (raw)
In-Reply-To: <20230320082314.2018-2-EABachinin@sberdevices.ru>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Mon, Mar 20, 2023 at 11:23:11AM +0300, Evgeny Bachinin wrote:
> * vsnprintf() can truncate cmd, hence it makes no sense to launch such
> command (it's broken). Moreover, it's better to signalize to the caller
> about such case (for facilitating debugging or bug hunting).
>
> * Fix kernel-doc warnings:
> include/command.h:264: info: Scanning doc for run_commandf
> include/command.h:268: warning: contents before sections
> include/command.h:271: warning: No description found for return value
> of 'run_commandf'
>
> * Add printf-like format attribute to validate at compile-time the format
> string against parameters's type.
>
> * Fix compilation error in case of -Wall, -Werror, -Wextra:
> error: variable ‘i’ set but not used [-Werror=unused-but-set-variable]
>
> * Drop extra ret variable.
>
> Signed-off-by: Evgeny Bachinin <EABachinin@sberdevices.ru>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-03-31 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:23 [PATCH v2 0/4] cli: run_commandf() coverage and small fixups Evgeny Bachinin
2023-03-20 8:23 ` [PATCH v2 1/4] cli: run_commandf(): " Evgeny Bachinin
2023-03-20 18:40 ` Simon Glass
2023-03-31 14:15 ` Tom Rini [this message]
2023-03-20 8:23 ` [PATCH v2 2/4] unit-test: cover run_commandf() by test-cases Evgeny Bachinin
2023-03-20 18:40 ` Simon Glass
2023-03-31 14:15 ` Tom Rini
2023-03-20 8:23 ` [PATCH v2 3/4] test: fdt: fix run_commandf() warnings Evgeny Bachinin
2023-03-20 18:40 ` Simon Glass
2023-03-31 14:15 ` Tom Rini
2023-03-20 8:23 ` [PATCH v2 4/4] test: exit: " Evgeny Bachinin
2023-03-20 18:40 ` Simon Glass
2023-03-31 14:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331141513.GD13222@bill-the-cat \
--to=trini@konsulko.com \
--cc=EABachinin@sberdevices.ru \
--cc=evgen89bachinin@gmail.com \
--cc=hector.palacios@digi.com \
--cc=john@metanate.com \
--cc=kernel@sberdevices.ru \
--cc=marex@denx.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox