public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: joe.hershberger@ni.com, rfried.dev@gmail.com, sjg@chromium.org,
	u-boot@lists.denx.de, s-anna@ti.com, srk@ti.com
Subject: Re: [PATCH 3/6] net: ti: am65-cpsw-nuss: Add logic to support MDIO reset
Date: Fri, 21 Jul 2023 15:36:17 -0400	[thread overview]
Message-ID: <20230721193617.GA722016@bill-the-cat> (raw)
In-Reply-To: <20230708104523.228257-4-s-vadapalli@ti.com>

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On Sat, Jul 08, 2023 at 04:15:20PM +0530, Siddharth Vadapalli wrote:

> From: Suman Anna <s-anna@ti.com>
> 
> Enhance the AM65 CPSW NUSS driver to perform a MDIO reset using a GPIO
> line. Logic is also added to perform a pre and post delay around reset
> using the optional 'reset-delay-us' and 'reset-post-delay-us' properties.
> This is similar to the reset being performed in the Linux kernel. The
> reset is done once when the CPSW MDIO bus is being initialized.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>  drivers/net/ti/am65-cpsw-nuss.c | 34 ++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)

So this breaks building on am62x_evm_a53 because now TI_AM65_CPSW_NUSS
needs to select DM_GPIO.  And the next problem is that we don't enable a
GPIO driver on that platform as we should I suspect make DA8XX_GPIO
default y if K3.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-07-21 19:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-08 10:45 [PATCH 0/6] Add SGMII support for MAIN CPSW on TI's J7200 SoC Siddharth Vadapalli
2023-07-08 10:45 ` [PATCH 1/6] dma: ti: Update J21E PSIL endpoint information for MAIN CPSW0 Siddharth Vadapalli
2023-07-08 10:45 ` [PATCH 2/6] net: ti: am65-cpsw-nuss: Add support for SGMII mode Siddharth Vadapalli
2023-07-08 10:45 ` [PATCH 3/6] net: ti: am65-cpsw-nuss: Add logic to support MDIO reset Siddharth Vadapalli
2023-07-21 19:36   ` Tom Rini [this message]
2023-07-31  4:43     ` Siddharth Vadapalli
2023-07-31  8:36       ` Siddharth Vadapalli
2023-07-31 15:12         ` Tom Rini
2023-07-08 10:45 ` [PATCH 4/6] phy: ti: phy-j721e-wiz: Add SGMII support in wiz driver for J7200 Siddharth Vadapalli
2023-07-08 10:45 ` [PATCH 5/6] phy: ti: j721e-wiz: Add SGMII support in WIZ driver for J721E Siddharth Vadapalli
2023-07-08 10:45 ` [PATCH 6/6] configs: j7200_evm_a72: Enable configs for SGMII support with MAIN CPSW0 Siddharth Vadapalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721193617.GA722016@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=joe.hershberger@ni.com \
    --cc=rfried.dev@gmail.com \
    --cc=s-anna@ti.com \
    --cc=s-vadapalli@ti.com \
    --cc=sjg@chromium.org \
    --cc=srk@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox