From: Tom Rini <trini@konsulko.com>
To: Michal Simek <michal.simek@amd.com>
Cc: u-boot@lists.denx.de, git@xilinx.com,
Etienne Carriere <etienne.carriere@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH] fwu: Allow code to properly decode trial state
Date: Tue, 25 Jul 2023 17:13:03 -0400 [thread overview]
Message-ID: <20230725211303.GK3630934@bill-the-cat> (raw)
In-Reply-To: <ccc095539d48c22b4874ead60eb9a1e6dc52fe97.1689258921.git.michal.simek@amd.com>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Thu, Jul 13, 2023 at 04:35:24PM +0200, Michal Simek wrote:
> Current code after capsule update (mtd write) is not changing active_index
> in mdata to previous_active_index.
> On the reboot this is shown but showing message
> "Boot idx 1 is not matching active idx 0, changing active_idx"
> which is changing active_idx and writing mdata to flash.
>
> But when this message is visible it is not checking which state that images
> are. If they have acceptance bit setup to yes everything is fine and valid
> images are booted (doesn't mean the latest one).
> But if acceptance bit is no and images are in trial state in_trial variable
> is never setup. Which means that from new flashed image stable image can be
> rewritten because in_trial is not setup properly.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-07-25 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:35 [PATCH] fwu: Allow code to properly decode trial state Michal Simek
2023-07-15 14:45 ` Jassi Brar
2023-07-25 21:13 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725211303.GK3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=etienne.carriere@linaro.org \
--cc=git@xilinx.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=masahisa.kojima@linaro.org \
--cc=michal.simek@amd.com \
--cc=patrick.delaunay@foss.st.com \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox