From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Glass <sjg@chromium.org>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] test: avoid function name 'setup'
Date: Tue, 25 Jul 2023 17:13:25 -0400 [thread overview]
Message-ID: <20230725211325.GO3630934@bill-the-cat> (raw)
In-Reply-To: <20230715090522.205205-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
On Sat, Jul 15, 2023 at 11:05:22AM +0200, Heinrich Schuchardt wrote:
> pytest 7.3.2 treats the function name 'setup' as a fixture [1].
>
> This leads to errors like:
>
> TypeError: setup() missing 2 required positional arguments:
> 'disk_img' and 'osindications'
>
> Rename setup() to capsule_setup().
>
> [1] How to run tests written for nose
> https://docs.pytest.org/en/7.3.x/how-to/nose.html
>
> Fixes: 482ef90aeb4c ("test: efi_capsule: refactor efi_capsule test")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-07-25 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 9:05 [PATCH 1/1] test: avoid function name 'setup' Heinrich Schuchardt
2023-07-15 23:40 ` Simon Glass
2023-07-16 13:37 ` Heinrich Schuchardt
2023-07-24 13:58 ` Ilias Apalodimas
2023-07-25 21:13 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725211325.GO3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=ilias.apalodimas@linaro.org \
--cc=masahisa.kojima@linaro.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox