Re: [PATCH v3 0/7] clk: Switch from soc_clk_dump to clk_ops function

[Igor Prusov <ivprusov@sberdevices.ru>]

+Simon Glass

Hi Simon,

Apologies for the ping, but could you please take a look at this series?
There was not much feedback after a while, so I'd like to understand
whether proposed fix is viable or not.         

On Fri, Jul 14, 2023 at 06:24:37PM +0300, Igor Prusov wrote:
> Currently clock providers may override default implementation of
> soc_clk_dump function to replace clk dump command output. This causes
> confusing behaviour when u-boot is built with one of such drivers
> enabled but still has clocks defined using CCF. For example, enabling
> CMD_CLK and using clk dump on sandbox target will not show CCF clocks
> because k210 driver overrides common soc_clk_dump.
> 
> Changelog:
>  v1 -> v2:
>  - Add missing static to dump functions
>  v2 -> v3:
>  - Make soc_clk_dump in cmd/clk.c static instead of removing __weak
> 
> Igor Prusov (7):
>   clk: zynq: Move soc_clk_dump to Zynq clock driver
>   clk: ast2600: Move soc_clk_dump function
>   clk: k210: Move soc_clk_dump function
>   clk: Add dump operation to clk_ops
>   cmd: clk: Use dump function from clk_ops
>   clk: treewide: switch to clock dump from clk_ops
>   cmd: clk: Make soc_clk_dump static
> 
>  arch/arm/mach-zynq/clk.c               |  57 --------------
>  arch/mips/mach-pic32/cpu.c             |  23 ------
>  cmd/clk.c                              |  13 +++-
>  drivers/clk/aspeed/clk_ast2600.c       |  83 ++++++++++----------
>  drivers/clk/clk_k210.c                 | 103 ++++++++++++-------------
>  drivers/clk/clk_pic32.c                |  39 ++++++++++
>  drivers/clk/clk_versal.c               |   7 +-
>  drivers/clk/clk_zynq.c                 |  51 ++++++++++++
>  drivers/clk/clk_zynqmp.c               |  13 ++--
>  drivers/clk/imx/clk-imx8.c             |  11 +--
>  drivers/clk/mvebu/armada-37xx-periph.c |   5 +-
>  drivers/clk/stm32/clk-stm32mp1.c       |  29 ++-----
>  include/clk-uclass.h                   |   3 +
>  include/clk.h                          |   2 -
>  14 files changed, 223 insertions(+), 216 deletions(-)
> 
> -- 
> 2.34.1
> 

-- 
Best Regards,
Igor Prusov