From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: "Simon Glass" <sjg@chromium.org>, "Pali Rohár" <pali@kernel.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] common: fix detection of SYS_MALLOC_F_LEN=0x0
Date: Tue, 1 Aug 2023 11:14:12 -0400 [thread overview]
Message-ID: <20230801151412.GP3630934@bill-the-cat> (raw)
In-Reply-To: <20230801133341.105298-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Tue, Aug 01, 2023 at 03:33:41PM +0200, Heinrich Schuchardt wrote:
> CONFIG_$(SPL_TPL_)SYS_MALLOC_F_LEN is defined as hex. If set to zero
> manually, .config contains '0x0' and not '0' as value.
>
> The default value for CONFIG_SPL_SYS_MALLOC_F_LEN should not be set to 0
> but to 0x0 if CONFIG_SPL_FRAMEWORK=n to match a manually set value.
>
> Fixes: c0126bd862a0 ("spl: Support bootstage, log, hash and early malloc in TPL")
> Fixes: b61694705217 ("SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SPL_FRAMEWORK by default")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
And I see a number of other cases where a "hex" option has a default of
"0" and not "0x0" so I'll have a patch soon.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-08-01 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 13:33 [PATCH 1/1] common: fix detection of SYS_MALLOC_F_LEN=0x0 Heinrich Schuchardt
2023-08-01 15:14 ` Tom Rini [this message]
2023-08-07 19:28 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801151412.GP3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox