U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: <trini@konsulko.com>, <vigneshr@ti.com>, <m-chawdhry@ti.com>,
	<sjg@chromium.org>, <jonas@kwiboo.se>, <srk@ti.com>, <afd@ti.com>,
	<bb@ti.com>, <praneeth@ti.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/6] arm: dts: k3-am64-evm: Fix boot
Date: Mon, 2 Oct 2023 10:19:33 -0500	[thread overview]
Message-ID: <20231002151933.vxjpor26m6g4pgm3@compactor> (raw)
In-Reply-To: <20230929134646.214781-2-rogerq@kernel.org>

On 16:46-20230929, Roger Quadros wrote:
> Since commit [1] A53 u-boot proper is broken.
> This is because nodes marked as 'bootph-pre-ram' are
> not available at u-boot proper before relocation.
> 
> To fix this we mark all nodes in sk-u-boot.dtsi as
> 'bootph-all'.
> 
> Move vtt_supply and cbass_mcu node to -r5-evm.dts as
> it is only required for R5 SPL.
> 
> [1]
> 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  arch/arm/dts/k3-am642-evm-u-boot.dtsi | 56 ++++++++++++---------------
>  arch/arm/dts/k3-am642-r5-evm.dts      |  8 ++++
>  2 files changed, 32 insertions(+), 32 deletions(-)
> 
> diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> index c85f57d40f..d06955dfbc 100644
> --- a/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am642-evm-u-boot.dtsi
> @@ -11,109 +11,101 @@
>  	};
>  
>  	memory@80000000 {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
> -&vtt_supply {
> -	bootph-pre-ram;
> -};
> -
>  &cbass_main {
> -	bootph-pre-ram;
> -};
> -
> -&cbass_mcu {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_timer0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  	clock-frequency = <200000000>;
>  };
>  
>  &main_conf {
> -	bootph-pre-ram;
> +	bootph-all;
>  	chipid@14 {
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &main_pmx0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_i2c0_pins_default {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_i2c0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_uart0_pins_default {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_uart0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &usb0 {
>  	dr_mode="peripheral";
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &usbss0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_mmc1_pins_default {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &main_usb0_pins_default {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &dmss {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &secure_proxy_main {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &dmsc {
> -	bootph-pre-ram;
> +	bootph-all;
>  	k3_sysreset: sysreset-controller {
>  		compatible = "ti,sci-sysreset";
> -		bootph-pre-ram;
> +		bootph-all;
>  	};
>  };
>  
>  &k3_pds {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &k3_clks {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &k3_reset {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &sdhci0 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &sdhci1 {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &cpsw3g {
> -	bootph-pre-ram;
> +	bootph-all;
>  };
>  
>  &cpsw_port2 {
> diff --git a/arch/arm/dts/k3-am642-r5-evm.dts b/arch/arm/dts/k3-am642-r5-evm.dts
> index 73461f8f6c..696735d8e2 100644
> --- a/arch/arm/dts/k3-am642-r5-evm.dts
> +++ b/arch/arm/dts/k3-am642-r5-evm.dts
> @@ -40,6 +40,10 @@
>  	};
>  };
>  
> +&vtt_supply {
> +	bootph-pre-ram;
> +};
> +
>  &cbass_main {
>  	sysctrler: sysctrler {
>  		compatible = "ti,am654-system-controller";
> @@ -53,6 +57,10 @@
>  	bootph-pre-ram;
>  };
>  
> +&cbass_mcu {
> +	bootph-pre-ram;
> +};

A bit superfluous, but ok - we just need this atm for esm.
> +
>  &mcu_esm {
>  	bootph-pre-ram;
>  };
> -- 
> 2.34.1
> 

Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2023-10-02 15:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 13:46 [RESEND PATCH 0/6] arm: dts: k3-am64 / k3-am62: Fix boot Roger Quadros
2023-09-29 13:46 ` [PATCH 1/6] arm: dts: k3-am64-evm: " Roger Quadros
2023-10-02 15:19   ` Nishanth Menon [this message]
2023-10-02 16:14     ` Roger Quadros
2023-10-02 16:19       ` Nishanth Menon
2023-10-05 14:49   ` Tom Rini
2023-09-29 13:46 ` [PATCH 2/6] arm: dts: k3-am64-evm: Mark dependent nodes for pre-relocation phase Roger Quadros
2023-10-02 15:20   ` Nishanth Menon
2023-09-29 13:46 ` [PATCH 3/6] arm: dts: k3-am642-sk: Fix boot Roger Quadros
2023-10-02 15:20   ` Nishanth Menon
2023-09-29 13:46 ` [PATCH 4/6] arm: dts: k3-am642-sk: Mark dependent nodes for pre-relocation phase Roger Quadros
2023-10-02 15:20   ` Nishanth Menon
2023-09-29 13:46 ` [PATCH 5/6] arm: dts: k3-am625-sk: Fix boot Roger Quadros
2023-10-02 15:20   ` Nishanth Menon
2023-09-29 13:46 ` [PATCH 6/6] arm: dts: k3-am625-sk: Mark dependent nodes for pre-relocation phase Roger Quadros
2023-10-02 15:20   ` Nishanth Menon
2023-10-03 20:26 ` [PATCH] arm: dts: k3-am625-beagleplay: Fix boot Jan Kiszka
2023-10-04 10:01   ` Roger Quadros
2023-10-04 12:15   ` Nishanth Menon
2023-10-05  4:18     ` Jan Kiszka
2023-10-05 11:27       ` Nishanth Menon
2023-10-05 14:49       ` Tom Rini
2023-10-05 14:52         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231002151933.vxjpor26m6g4pgm3@compactor \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=jonas@kwiboo.se \
    --cc=m-chawdhry@ti.com \
    --cc=praneeth@ti.com \
    --cc=rogerq@kernel.org \
    --cc=sjg@chromium.org \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox