* [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot
@ 2023-10-02 15:00 Nishanth Menon
2023-10-03 9:07 ` Roger Quadros
2023-10-05 14:49 ` Tom Rini
0 siblings, 2 replies; 10+ messages in thread
From: Nishanth Menon @ 2023-10-02 15:00 UTC (permalink / raw)
To: trini
Cc: vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth, u-boot,
Roger Quadros, Robert Nelson, Nishanth Menon
Since commit [1] A53 u-boot proper is broken. This is because nodes
marked as 'bootph-pre-ram' are not available at u-boot proper before
relocation.
To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
[1]
9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
Reported-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Based on Roger's series:
https://lore.kernel.org/all/20230929134646.214781-1-rogerq@kernel.org/
Based on:
next e29b932aa07f Merge branch '2023-09-30-Kconfig-updates' into next
See discussion thread:
https://lore.kernel.org/all/CAPnjgZ3MgWX8T0A0SofphEr_Xd77pE3hte9DNye1RuBVeB9N8Q@mail.gmail.com/
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 70 ++++++++++----------
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
index f8c04e8a300a..d6c6baa5518b 100644
--- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
+++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
@@ -14,143 +14,143 @@
};
memory@80000000 {
- bootph-pre-ram;
+ bootph-all;
};
/* Keep the LEDs on by default to indicate life */
leds {
- bootph-pre-ram;
+ bootph-all;
led-0 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-1 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-2 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-3 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-4 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
};
};
&cbass_main {
- bootph-pre-ram;
+ bootph-all;
};
&main_timer0 {
clock-frequency = <25000000>;
- bootph-pre-ram;
+ bootph-all;
};
&dmss {
- bootph-pre-ram;
+ bootph-all;
};
&secure_proxy_main {
- bootph-pre-ram;
+ bootph-all;
};
&dmsc {
- bootph-pre-ram;
+ bootph-all;
};
&k3_pds {
- bootph-pre-ram;
+ bootph-all;
};
&k3_clks {
- bootph-pre-ram;
+ bootph-all;
};
&k3_reset {
- bootph-pre-ram;
+ bootph-all;
};
&dmsc {
- bootph-pre-ram;
+ bootph-all;
k3_sysreset: sysreset-controller {
compatible = "ti,sci-sysreset";
- bootph-pre-ram;
+ bootph-all;
};
};
&wkup_conf {
- bootph-pre-ram;
+ bootph-all;
};
&chipid {
- bootph-pre-ram;
+ bootph-all;
};
&main_pmx0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_uart0 {
- bootph-pre-ram;
+ bootph-all;
};
&console_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&cbass_mcu {
- bootph-pre-ram;
+ bootph-all;
};
&cbass_wakeup {
- bootph-pre-ram;
+ bootph-all;
};
&mcu_pmx0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_i2c0 {
- bootph-pre-ram;
+ bootph-all;
};
&local_i2c_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&gpio0_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&main_gpio0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_gpio1 {
- bootph-pre-ram;
+ bootph-all;
};
&sdhci0 {
/* EMMC */
- bootph-pre-ram;
+ bootph-all;
};
&emmc_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&sd_pins_default {
- bootph-pre-ram;
+ bootph-all;
/* Force to use SDCD card detect pin */
pinctrl-single,pins = <
AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
@@ -164,11 +164,11 @@
};
&tps65219 {
- bootph-pre-ram;
+ bootph-all;
};
&sdhci1 {
- bootph-pre-ram;
+ bootph-all;
};
#ifdef CONFIG_TARGET_AM625_A53_EVM
--
2.40.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot
2023-10-02 15:00 [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot Nishanth Menon
@ 2023-10-03 9:07 ` Roger Quadros
2023-10-05 14:49 ` Tom Rini
1 sibling, 0 replies; 10+ messages in thread
From: Roger Quadros @ 2023-10-03 9:07 UTC (permalink / raw)
To: Nishanth Menon, trini
Cc: vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth, u-boot,
Robert Nelson
On 02/10/2023 18:00, Nishanth Menon wrote:
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
>
> To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
>
> [1]
> 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
>
> Reported-by: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
> ---
>
> Based on Roger's series:
> https://lore.kernel.org/all/20230929134646.214781-1-rogerq@kernel.org/
>
> Based on:
> next e29b932aa07f Merge branch '2023-09-30-Kconfig-updates' into next
>
> See discussion thread:
> https://lore.kernel.org/all/CAPnjgZ3MgWX8T0A0SofphEr_Xd77pE3hte9DNye1RuBVeB9N8Q@mail.gmail.com/
>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot
2023-10-02 15:00 [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot Nishanth Menon
2023-10-03 9:07 ` Roger Quadros
@ 2023-10-05 14:49 ` Tom Rini
1 sibling, 0 replies; 10+ messages in thread
From: Tom Rini @ 2023-10-05 14:49 UTC (permalink / raw)
To: Nishanth Menon
Cc: vigneshr, m-chawdhry, sjg, jonas, afd, bb, praneeth, u-boot,
Roger Quadros, Robert Nelson
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Mon, Oct 02, 2023 at 10:00:53AM -0500, Nishanth Menon wrote:
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
>
> To fix this we mark all nodes in u-boot.dtsi as 'bootph-all'.
>
> [1]
> 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
>
> Reported-by: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH 0/6] arm: dts: k3-am64 / k3-am62: Fix boot
@ 2023-09-29 13:46 Roger Quadros
2023-10-03 20:26 ` [PATCH] arm: dts: k3-am625-beagleplay: " Jan Kiszka
0 siblings, 1 reply; 10+ messages in thread
From: Roger Quadros @ 2023-09-29 13:46 UTC (permalink / raw)
To: trini, nm
Cc: vigneshr, m-chawdhry, sjg, jonas, srk, afd, bb, praneeth, u-boot,
Roger Quadros
Hi,
(Apologies for resend as I missed the u-boot list the last time.
Thanks Vignesh for catching this :) )
Since commit [1] A53 u-boot proper is broken.
This is because nodes marked as 'bootph-pre-ram' are
not availble at u-boot proper before relocation.
To fix this we mark all nodes in sk-u-boot.dtsi as
'bootph-all'.
Move cbass_mcu node to -r5-sk.dts as it is only required
for R5 SPL.
[1]
9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
In addition to this we also fix some dts warnings related
to CPSW nodes in R5 SPL DTBs.
cheers,
-roger
Roger Quadros (6):
arm: dts: k3-am64-evm: Fix boot
arm: dts: k3-am64-evm: Mark dependent nodes for pre-relocation phase
arm: dts: k3-am642-sk: Fix boot
arm: dts: k3-am642-sk: Mark dependent nodes for pre-relocation phase
arm: dts: k3-am625-sk: Fix boot
arm: dts: k3-am625-sk: Mark dependent nodes for pre-relocation phase
arch/arm/dts/k3-am625-sk-u-boot.dtsi | 93 ++++++++++++++-------
arch/arm/dts/k3-am642-evm-u-boot.dtsi | 104 ++++++++++++++++--------
arch/arm/dts/k3-am642-r5-evm.dts | 16 ++++
arch/arm/dts/k3-am642-r5-sk.dts | 4 +
arch/arm/dts/k3-am642-sk-u-boot.dtsi | 112 +++++++++++++++++---------
5 files changed, 230 insertions(+), 99 deletions(-)
base-commit: 90c81f407dd4a7747385b10f9b8f732202c45cde
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-09-29 13:46 [RESEND PATCH 0/6] arm: dts: k3-am64 / k3-am62: Fix boot Roger Quadros
@ 2023-10-03 20:26 ` Jan Kiszka
2023-10-04 10:01 ` Roger Quadros
2023-10-04 12:15 ` Nishanth Menon
0 siblings, 2 replies; 10+ messages in thread
From: Jan Kiszka @ 2023-10-03 20:26 UTC (permalink / raw)
To: Roger Quadros, trini, nm
Cc: vigneshr, m-chawdhry, sjg, jonas, srk, afd, bb, praneeth, u-boot
From: Jan Kiszka <jan.kiszka@siemens.com>
Since commit [1] A53 u-boot proper is broken. This is because nodes
marked as 'bootph-pre-ram' are not available at u-boot proper before
relocation.
To fix this we mark all nodes as 'bootph-all'.
[1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
This may overshoot, but at least the board boots again. Could it be that
[1] broke even more boards?
arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 70 ++++++++++----------
arch/arm/dts/k3-am625-r5-beagleplay.dts | 12 ++--
2 files changed, 41 insertions(+), 41 deletions(-)
diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
index f8c04e8a300..d6c6baa5518 100644
--- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
+++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
@@ -14,143 +14,143 @@
};
memory@80000000 {
- bootph-pre-ram;
+ bootph-all;
};
/* Keep the LEDs on by default to indicate life */
leds {
- bootph-pre-ram;
+ bootph-all;
led-0 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-1 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-2 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-3 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
led-4 {
default-state = "on";
- bootph-pre-ram;
+ bootph-all;
};
};
};
&cbass_main {
- bootph-pre-ram;
+ bootph-all;
};
&main_timer0 {
clock-frequency = <25000000>;
- bootph-pre-ram;
+ bootph-all;
};
&dmss {
- bootph-pre-ram;
+ bootph-all;
};
&secure_proxy_main {
- bootph-pre-ram;
+ bootph-all;
};
&dmsc {
- bootph-pre-ram;
+ bootph-all;
};
&k3_pds {
- bootph-pre-ram;
+ bootph-all;
};
&k3_clks {
- bootph-pre-ram;
+ bootph-all;
};
&k3_reset {
- bootph-pre-ram;
+ bootph-all;
};
&dmsc {
- bootph-pre-ram;
+ bootph-all;
k3_sysreset: sysreset-controller {
compatible = "ti,sci-sysreset";
- bootph-pre-ram;
+ bootph-all;
};
};
&wkup_conf {
- bootph-pre-ram;
+ bootph-all;
};
&chipid {
- bootph-pre-ram;
+ bootph-all;
};
&main_pmx0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_uart0 {
- bootph-pre-ram;
+ bootph-all;
};
&console_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&cbass_mcu {
- bootph-pre-ram;
+ bootph-all;
};
&cbass_wakeup {
- bootph-pre-ram;
+ bootph-all;
};
&mcu_pmx0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_i2c0 {
- bootph-pre-ram;
+ bootph-all;
};
&local_i2c_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&gpio0_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&main_gpio0 {
- bootph-pre-ram;
+ bootph-all;
};
&main_gpio1 {
- bootph-pre-ram;
+ bootph-all;
};
&sdhci0 {
/* EMMC */
- bootph-pre-ram;
+ bootph-all;
};
&emmc_pins_default {
- bootph-pre-ram;
+ bootph-all;
};
&sd_pins_default {
- bootph-pre-ram;
+ bootph-all;
/* Force to use SDCD card detect pin */
pinctrl-single,pins = <
AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
@@ -164,11 +164,11 @@
};
&tps65219 {
- bootph-pre-ram;
+ bootph-all;
};
&sdhci1 {
- bootph-pre-ram;
+ bootph-all;
};
#ifdef CONFIG_TARGET_AM625_A53_EVM
diff --git a/arch/arm/dts/k3-am625-r5-beagleplay.dts b/arch/arm/dts/k3-am625-r5-beagleplay.dts
index 9c9d0570592..ac5461a32c0 100644
--- a/arch/arm/dts/k3-am625-r5-beagleplay.dts
+++ b/arch/arm/dts/k3-am625-r5-beagleplay.dts
@@ -31,7 +31,7 @@
ti,sci = <&dmsc>;
ti,sci-proc-id = <32>;
ti,sci-host-id = <10>;
- bootph-pre-ram;
+ bootph-all;
};
dm_tifs: dm-tifs {
@@ -41,7 +41,7 @@
mbox-names = "rx", "tx";
mboxes= <&secure_proxy_main 22>,
<&secure_proxy_main 23>;
- bootph-pre-ram;
+ bootph-all;
};
};
@@ -55,11 +55,11 @@
};
&mcu_esm {
- bootph-pre-ram;
+ bootph-all;
};
&secure_proxy_sa3 {
- bootph-pre-ram;
+ bootph-all;
/* We require this for boot handshake */
status = "okay";
};
@@ -69,12 +69,12 @@
compatible = "ti,am654-system-controller";
mboxes= <&secure_proxy_main 1>, <&secure_proxy_main 0>, <&secure_proxy_sa3 0>;
mbox-names = "tx", "rx", "boot_notify";
- bootph-pre-ram;
+ bootph-all;
};
};
&main_esm {
- bootph-pre-ram;
+ bootph-all;
};
&main_pktdma {
--
2.35.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-03 20:26 ` [PATCH] arm: dts: k3-am625-beagleplay: " Jan Kiszka
@ 2023-10-04 10:01 ` Roger Quadros
2023-10-04 12:15 ` Nishanth Menon
1 sibling, 0 replies; 10+ messages in thread
From: Roger Quadros @ 2023-10-04 10:01 UTC (permalink / raw)
To: Jan Kiszka, trini, nm
Cc: vigneshr, m-chawdhry, sjg, jonas, srk, afd, bb, praneeth, u-boot
Hi Jan,
On 03/10/2023 23:26, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
>
> To fix this we mark all nodes as 'bootph-all'.
>
> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Nishanth already send a fix earlier
https://lore.kernel.org/all/20231002150053.2930710-1-nm@ti.com/
> ---
>
> This may overshoot, but at least the board boots again. Could it be that
> [1] broke even more boards?
>
> arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 70 ++++++++++----------
> arch/arm/dts/k3-am625-r5-beagleplay.dts | 12 ++--
> 2 files changed, 41 insertions(+), 41 deletions(-)
>
--
cheers,
-roger
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-03 20:26 ` [PATCH] arm: dts: k3-am625-beagleplay: " Jan Kiszka
2023-10-04 10:01 ` Roger Quadros
@ 2023-10-04 12:15 ` Nishanth Menon
2023-10-05 4:18 ` Jan Kiszka
1 sibling, 1 reply; 10+ messages in thread
From: Nishanth Menon @ 2023-10-04 12:15 UTC (permalink / raw)
To: Jan Kiszka
Cc: Roger Quadros, trini, vigneshr, m-chawdhry, sjg, jonas, srk, afd,
bb, praneeth, u-boot
On 22:26-20231003, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Since commit [1] A53 u-boot proper is broken. This is because nodes
> marked as 'bootph-pre-ram' are not available at u-boot proper before
> relocation.
>
> To fix this we mark all nodes as 'bootph-all'.
>
> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> This may overshoot, but at least the board boots again. Could it be that
> [1] broke even more boards?
Jan: https://lore.kernel.org/all/b1c62a7d-a90e-4212-8972-9b622e147975@kernel.org/
I got boot without r5-beagleplay.dts modified. and it is in line with
the changes in linux-next commit 944adefc7f88 ("arm64: dts: ti:
k3-am625-beagleplay: Add boot phase tags marking")
>
> arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 70 ++++++++++----------
> arch/arm/dts/k3-am625-r5-beagleplay.dts | 12 ++--
> 2 files changed, 41 insertions(+), 41 deletions(-)
>
> diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> index f8c04e8a300..d6c6baa5518 100644
> --- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> @@ -14,143 +14,143 @@
> };
> memory@80000000 {
> - bootph-pre-ram;
> + bootph-all;
> };
> /* Keep the LEDs on by default to indicate life */
> leds {
> - bootph-pre-ram;
> + bootph-all;
> led-0 {
> default-state = "on";
> - bootph-pre-ram;
> + bootph-all;
> };
> led-1 {
> default-state = "on";
> - bootph-pre-ram;
> + bootph-all;
> };
> led-2 {
> default-state = "on";
> - bootph-pre-ram;
> + bootph-all;
> };
> led-3 {
> default-state = "on";
> - bootph-pre-ram;
> + bootph-all;
> };
> led-4 {
> default-state = "on";
> - bootph-pre-ram;
> + bootph-all;
> };
> };
> };
> &cbass_main {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_timer0 {
> clock-frequency = <25000000>;
> - bootph-pre-ram;
> + bootph-all;
> };
> &dmss {
> - bootph-pre-ram;
> + bootph-all;
> };
> &secure_proxy_main {
> - bootph-pre-ram;
> + bootph-all;
> };
> &dmsc {
> - bootph-pre-ram;
> + bootph-all;
> };
> &k3_pds {
> - bootph-pre-ram;
> + bootph-all;
> };
> &k3_clks {
> - bootph-pre-ram;
> + bootph-all;
> };
> &k3_reset {
> - bootph-pre-ram;
> + bootph-all;
> };
> &dmsc {
> - bootph-pre-ram;
> + bootph-all;
> k3_sysreset: sysreset-controller {
> compatible = "ti,sci-sysreset";
> - bootph-pre-ram;
> + bootph-all;
> };
> };
> &wkup_conf {
> - bootph-pre-ram;
> + bootph-all;
> };
> &chipid {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_pmx0 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_uart0 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &console_pins_default {
> - bootph-pre-ram;
> + bootph-all;
> };
> &cbass_mcu {
> - bootph-pre-ram;
> + bootph-all;
> };
> &cbass_wakeup {
> - bootph-pre-ram;
> + bootph-all;
> };
> &mcu_pmx0 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_i2c0 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &local_i2c_pins_default {
> - bootph-pre-ram;
> + bootph-all;
> };
> &gpio0_pins_default {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_gpio0 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_gpio1 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &sdhci0 {
> /* EMMC */
> - bootph-pre-ram;
> + bootph-all;
> };
> &emmc_pins_default {
> - bootph-pre-ram;
> + bootph-all;
> };
> &sd_pins_default {
> - bootph-pre-ram;
> + bootph-all;
> /* Force to use SDCD card detect pin */
> pinctrl-single,pins = <
> AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
> @@ -164,11 +164,11 @@
> };
> &tps65219 {
> - bootph-pre-ram;
> + bootph-all;
> };
> &sdhci1 {
> - bootph-pre-ram;
> + bootph-all;
> };
> #ifdef CONFIG_TARGET_AM625_A53_EVM
> diff --git a/arch/arm/dts/k3-am625-r5-beagleplay.dts b/arch/arm/dts/k3-am625-r5-beagleplay.dts
> index 9c9d0570592..ac5461a32c0 100644
> --- a/arch/arm/dts/k3-am625-r5-beagleplay.dts
> +++ b/arch/arm/dts/k3-am625-r5-beagleplay.dts
> @@ -31,7 +31,7 @@
> ti,sci = <&dmsc>;
> ti,sci-proc-id = <32>;
> ti,sci-host-id = <10>;
> - bootph-pre-ram;
> + bootph-all;
> };
> dm_tifs: dm-tifs {
> @@ -41,7 +41,7 @@
> mbox-names = "rx", "tx";
> mboxes= <&secure_proxy_main 22>,
> <&secure_proxy_main 23>;
> - bootph-pre-ram;
> + bootph-all;
> };
> };
> @@ -55,11 +55,11 @@
> };
> &mcu_esm {
> - bootph-pre-ram;
> + bootph-all;
> };
> &secure_proxy_sa3 {
> - bootph-pre-ram;
> + bootph-all;
> /* We require this for boot handshake */
> status = "okay";
> };
> @@ -69,12 +69,12 @@
> compatible = "ti,am654-system-controller";
> mboxes= <&secure_proxy_main 1>, <&secure_proxy_main 0>, <&secure_proxy_sa3 0>;
> mbox-names = "tx", "rx", "boot_notify";
> - bootph-pre-ram;
> + bootph-all;
> };
> };
> &main_esm {
> - bootph-pre-ram;
> + bootph-all;
> };
> &main_pktdma {
> --
> 2.35.3
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-04 12:15 ` Nishanth Menon
@ 2023-10-05 4:18 ` Jan Kiszka
2023-10-05 11:27 ` Nishanth Menon
2023-10-05 14:49 ` Tom Rini
0 siblings, 2 replies; 10+ messages in thread
From: Jan Kiszka @ 2023-10-05 4:18 UTC (permalink / raw)
To: Nishanth Menon
Cc: Roger Quadros, trini, vigneshr, m-chawdhry, sjg, jonas, srk, afd,
bb, praneeth, u-boot
On 04.10.23 14:15, Nishanth Menon wrote:
> On 22:26-20231003, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Since commit [1] A53 u-boot proper is broken. This is because nodes
>> marked as 'bootph-pre-ram' are not available at u-boot proper before
>> relocation.
>>
>> To fix this we mark all nodes as 'bootph-all'.
>>
>> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> This may overshoot, but at least the board boots again. Could it be that
>> [1] broke even more boards?
>
> Jan: https://lore.kernel.org/all/b1c62a7d-a90e-4212-8972-9b622e147975@kernel.org/
>
> I got boot without r5-beagleplay.dts modified. and it is in line with
> the changes in linux-next commit 944adefc7f88 ("arm64: dts: ti:
> k3-am625-beagleplay: Add boot phase tags marking")
>
Yeah, no problem, missed that.
Meanwhile, I can fix our IOT2050 because I was unfortunatenly right:
more havoc in sight. Did anyone tried to look at the fallouts
systematically already? Is it only affecting the TI family?
Jan
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-05 4:18 ` Jan Kiszka
@ 2023-10-05 11:27 ` Nishanth Menon
2023-10-05 14:49 ` Tom Rini
1 sibling, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2023-10-05 11:27 UTC (permalink / raw)
To: Jan Kiszka
Cc: Roger Quadros, trini, vigneshr, m-chawdhry, sjg, jonas, srk, afd,
bb, praneeth, u-boot
On 06:18-20231005, Jan Kiszka wrote:
> On 04.10.23 14:15, Nishanth Menon wrote:
> > On 22:26-20231003, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Since commit [1] A53 u-boot proper is broken. This is because nodes
> >> marked as 'bootph-pre-ram' are not available at u-boot proper before
> >> relocation.
> >>
> >> To fix this we mark all nodes as 'bootph-all'.
> >>
> >> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>
> >> This may overshoot, but at least the board boots again. Could it be that
> >> [1] broke even more boards?
> >
> > Jan: https://lore.kernel.org/all/b1c62a7d-a90e-4212-8972-9b622e147975@kernel.org/
> >
> > I got boot without r5-beagleplay.dts modified. and it is in line with
> > the changes in linux-next commit 944adefc7f88 ("arm64: dts: ti:
> > k3-am625-beagleplay: Add boot phase tags marking")
> >
>
> Yeah, no problem, missed that.
>
> Meanwhile, I can fix our IOT2050 because I was unfortunatenly right:
> more havoc in sight. Did anyone tried to look at the fallouts
> systematically already? Is it only affecting the TI family?
>
I know all of TI K3 platforms are broken, but I don't think (based on
discussions on the list so far), anyone actually went around non-TI
platforms to identify the ones that are broken.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-05 4:18 ` Jan Kiszka
2023-10-05 11:27 ` Nishanth Menon
@ 2023-10-05 14:49 ` Tom Rini
2023-10-05 14:52 ` Tom Rini
1 sibling, 1 reply; 10+ messages in thread
From: Tom Rini @ 2023-10-05 14:49 UTC (permalink / raw)
To: Jan Kiszka
Cc: Nishanth Menon, Roger Quadros, vigneshr, m-chawdhry, sjg, jonas,
srk, afd, bb, praneeth, u-boot
[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]
On Thu, Oct 05, 2023 at 06:18:08AM +0200, Jan Kiszka wrote:
> On 04.10.23 14:15, Nishanth Menon wrote:
> > On 22:26-20231003, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Since commit [1] A53 u-boot proper is broken. This is because nodes
> >> marked as 'bootph-pre-ram' are not available at u-boot proper before
> >> relocation.
> >>
> >> To fix this we mark all nodes as 'bootph-all'.
> >>
> >> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>
> >> This may overshoot, but at least the board boots again. Could it be that
> >> [1] broke even more boards?
> >
> > Jan: https://lore.kernel.org/all/b1c62a7d-a90e-4212-8972-9b622e147975@kernel.org/
> >
> > I got boot without r5-beagleplay.dts modified. and it is in line with
> > the changes in linux-next commit 944adefc7f88 ("arm64: dts: ti:
> > k3-am625-beagleplay: Add boot phase tags marking")
> >
>
> Yeah, no problem, missed that.
>
> Meanwhile, I can fix our IOT2050 because I was unfortunatenly right:
> more havoc in sight. Did anyone tried to look at the fallouts
> systematically already? Is it only affecting the TI family?
Well, I'm pretty confused right now. The visible breakage has been
traced back to a commit that was in -next and is fine on my J721E EVM
and is fine on my AM65x EVM. I can't figure out where my Beagleplay
ended up, so I can't check that one as easily. But given how the
breakage is described, mine too should be failing. But they aren't. In
both cases, I have the GP versions of the chips, and am booting the
unsigned files.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] arm: dts: k3-am625-beagleplay: Fix boot
2023-10-05 14:49 ` Tom Rini
@ 2023-10-05 14:52 ` Tom Rini
0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2023-10-05 14:52 UTC (permalink / raw)
To: Jan Kiszka
Cc: Nishanth Menon, Roger Quadros, vigneshr, m-chawdhry, sjg, jonas,
srk, afd, bb, praneeth, u-boot
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
On Thu, Oct 05, 2023 at 10:49:19AM -0400, Tom Rini wrote:
> On Thu, Oct 05, 2023 at 06:18:08AM +0200, Jan Kiszka wrote:
> > On 04.10.23 14:15, Nishanth Menon wrote:
> > > On 22:26-20231003, Jan Kiszka wrote:
> > >> From: Jan Kiszka <jan.kiszka@siemens.com>
> > >>
> > >> Since commit [1] A53 u-boot proper is broken. This is because nodes
> > >> marked as 'bootph-pre-ram' are not available at u-boot proper before
> > >> relocation.
> > >>
> > >> To fix this we mark all nodes as 'bootph-all'.
> > >>
> > >> [1] 9e644284ab812 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation")
> > >>
> > >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > >> ---
> > >>
> > >> This may overshoot, but at least the board boots again. Could it be that
> > >> [1] broke even more boards?
> > >
> > > Jan: https://lore.kernel.org/all/b1c62a7d-a90e-4212-8972-9b622e147975@kernel.org/
> > >
> > > I got boot without r5-beagleplay.dts modified. and it is in line with
> > > the changes in linux-next commit 944adefc7f88 ("arm64: dts: ti:
> > > k3-am625-beagleplay: Add boot phase tags marking")
> > >
> >
> > Yeah, no problem, missed that.
> >
> > Meanwhile, I can fix our IOT2050 because I was unfortunatenly right:
> > more havoc in sight. Did anyone tried to look at the fallouts
> > systematically already? Is it only affecting the TI family?
>
> Well, I'm pretty confused right now. The visible breakage has been
> traced back to a commit that was in -next and is fine on my J721E EVM
> and is fine on my AM65x EVM. I can't figure out where my Beagleplay
> ended up, so I can't check that one as easily. But given how the
> breakage is described, mine too should be failing. But they aren't. In
> both cases, I have the GP versions of the chips, and am booting the
> unsigned files.
OK, I think I might have solved my own unexpected success here in that
it seems like I had the wrong files being copied to the device and so
that somehow ended up working. I have replicated failure finally.
>
> --
> Tom
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-10-05 14:52 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 15:00 [PATCH] arm: dts: k3-am625-beagleplay: Fix Boot Nishanth Menon
2023-10-03 9:07 ` Roger Quadros
2023-10-05 14:49 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2023-09-29 13:46 [RESEND PATCH 0/6] arm: dts: k3-am64 / k3-am62: Fix boot Roger Quadros
2023-10-03 20:26 ` [PATCH] arm: dts: k3-am625-beagleplay: " Jan Kiszka
2023-10-04 10:01 ` Roger Quadros
2023-10-04 12:15 ` Nishanth Menon
2023-10-05 4:18 ` Jan Kiszka
2023-10-05 11:27 ` Nishanth Menon
2023-10-05 14:49 ` Tom Rini
2023-10-05 14:52 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox