U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Markus Niebel <Markus.Niebel@ew.tq-group.com>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	thomas.petazzoni@bootlin.com, u-boot@ew.tq-group.com
Subject: Re: [PATCH] tqma6: Fix DDR configuration
Date: Thu, 23 Nov 2023 14:54:00 +0100	[thread overview]
Message-ID: <20231123145400.029cb46d@xps-13> (raw)
In-Reply-To: <12328531.O9o76ZdvQC@steina-w>

Hi Alexander,

> > > > --- a/board/tq/tqma6/tqma6q.cfg
> > > > +++ b/board/tq/tqma6/tqma6q.cfg
> > > > @@ -36,7 +36,7 @@ DATA 4, MX6_IOM_DRAM_SDCLK_1, 0x00008030
> > > > 
> > > >  DATA 4, MX6_IOM_DRAM_CAS, 0x00008030
> > > >  DATA 4, MX6_IOM_DRAM_RAS, 0x00008030
> > > >  DATA 4, MX6_IOM_GRP_ADDDS, 0x00000030
> > > > 
> > > > -DATA 4, MX6_IOM_DRAM_RESET, 0x000C3030
> > > > +DATA 4, MX6_IOM_DRAM_RESET, 0x00003030  
> > > 
> > > Thank you for pointing this out. Originally this error came from an
> > > older/ancient reference manual. Sorry that we missed to bring this
> > > upstream. We will send the changes for DCD data in the next days.  
> > 
> > No problem, I'm glad this can now be solved. By any chance, could you
> > point to the relevant location of the manual (ddr or imx6 ?) explaining
> > what this is actually about? Because I failed to bring any real
> > explanation to my observations so far.  
> 
> It's a bit hidden but the comment above that list indicates these settings are 
> iomuxc configurations. In this case the register 
> IOMUXC_SW_PAD_CTL_PAD_DRAM_RESET. See i.MX6Q RM Rev.6 05/2020 section 
> 36.4.347.
> Your patch configures the field "DDR Select Field" from reserved3 to 
> DDR3_LPDDR2. It seems this field has to be set to 0 in every case.

Yes, that's also what I get from reading the iMX6Q manual. But I'm
sorry I don't understand why a runtime change of a reset pin
configuration can be so impacting. It's not like it only affects the
power-on sequence because I can reproduce the strange QoS/NIC issues
with a devmem once the kernel has started. I  believe there is a bit
more than just a pad configuration behind this field.

Thanks,
Miquèl

  reply	other threads:[~2023-11-23 13:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.3902.1700255720.703.u-boot@lists.denx.de>
2023-11-23 13:04 ` [PATCH] tqma6: Fix DDR configuration Markus Niebel
2023-11-23 13:12   ` Miquel Raynal
2023-11-23 13:44     ` Alexander Stein
2023-11-23 13:54       ` Miquel Raynal [this message]
2023-11-17 15:00 Miquel Raynal
2023-11-29 18:21 ` Fabio Estevam
2023-12-12 16:11 ` Fabio Estevam
2023-12-12 16:21   ` Miquel Raynal
2023-12-12 16:31     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123145400.029cb46d@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Markus.Niebel@ew.tq-group.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@ew.tq-group.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox