U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Orlov <ivan.orlov@codethink.co.uk>
To: trini@konsulko.com
Cc: Ivan Orlov <ivan.orlov@codethink.co.uk>, u-boot@lists.denx.de
Subject: [PATCH v2] cmd: eeprom: Fix config dependency
Date: Fri, 23 Feb 2024 17:14:20 +0000	[thread overview]
Message-ID: <20240223171420.9492-1-ivan.orlov@codethink.co.uk> (raw)

We should have CONFIG_DM_I2C or CONFIG_SYS_I2C_LEGACY enabled in
order for `cmd/eeprom.c` to compile as it depends on the i2c functions
which are not compiled otherwise. Update the Kconfig entry for the
'eeprom' command correspondingly.

Signed-off-by: Ivan Orlov <ivan.orlov@codethink.co.uk>
---
V1 -> V2:
- Remove redundant SYS_SPL_I2C_LEGACY dependency as we can't realy
enable commands in the SPL mode

 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index a86b570517..5d68a461cf 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -740,6 +740,7 @@ config CRC32_VERIFY
 
 config CMD_EEPROM
 	bool "eeprom - EEPROM subsystem"
+	depends on DM_I2C || SYS_I2C_LEGACY
 	help
 	  (deprecated, needs conversion to driver model)
 	  Provides commands to read and write EEPROM (Electrically Erasable
-- 
2.34.1


             reply	other threads:[~2024-02-23 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 17:14 Ivan Orlov [this message]
2024-02-23 20:38 ` [PATCH v2] cmd: eeprom: Fix config dependency Tom Rini
2024-03-04 15:29 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223171420.9492-1-ivan.orlov@codethink.co.uk \
    --to=ivan.orlov@codethink.co.uk \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox