* [PATCH v2] cmd: eeprom: Fix config dependency
@ 2024-02-23 17:14 Ivan Orlov
2024-02-23 20:38 ` Tom Rini
2024-03-04 15:29 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Ivan Orlov @ 2024-02-23 17:14 UTC (permalink / raw)
To: trini; +Cc: Ivan Orlov, u-boot
We should have CONFIG_DM_I2C or CONFIG_SYS_I2C_LEGACY enabled in
order for `cmd/eeprom.c` to compile as it depends on the i2c functions
which are not compiled otherwise. Update the Kconfig entry for the
'eeprom' command correspondingly.
Signed-off-by: Ivan Orlov <ivan.orlov@codethink.co.uk>
---
V1 -> V2:
- Remove redundant SYS_SPL_I2C_LEGACY dependency as we can't realy
enable commands in the SPL mode
cmd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index a86b570517..5d68a461cf 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -740,6 +740,7 @@ config CRC32_VERIFY
config CMD_EEPROM
bool "eeprom - EEPROM subsystem"
+ depends on DM_I2C || SYS_I2C_LEGACY
help
(deprecated, needs conversion to driver model)
Provides commands to read and write EEPROM (Electrically Erasable
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cmd: eeprom: Fix config dependency
2024-02-23 17:14 [PATCH v2] cmd: eeprom: Fix config dependency Ivan Orlov
@ 2024-02-23 20:38 ` Tom Rini
2024-03-04 15:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2024-02-23 20:38 UTC (permalink / raw)
To: Ivan Orlov; +Cc: u-boot
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Fri, Feb 23, 2024 at 05:14:20PM +0000, Ivan Orlov wrote:
> We should have CONFIG_DM_I2C or CONFIG_SYS_I2C_LEGACY enabled in
> order for `cmd/eeprom.c` to compile as it depends on the i2c functions
> which are not compiled otherwise. Update the Kconfig entry for the
> 'eeprom' command correspondingly.
>
> Signed-off-by: Ivan Orlov <ivan.orlov@codethink.co.uk>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cmd: eeprom: Fix config dependency
2024-02-23 17:14 [PATCH v2] cmd: eeprom: Fix config dependency Ivan Orlov
2024-02-23 20:38 ` Tom Rini
@ 2024-03-04 15:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2024-03-04 15:29 UTC (permalink / raw)
To: Ivan Orlov; +Cc: u-boot
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Fri, Feb 23, 2024 at 05:14:20PM +0000, Ivan Orlov wrote:
> We should have CONFIG_DM_I2C or CONFIG_SYS_I2C_LEGACY enabled in
> order for `cmd/eeprom.c` to compile as it depends on the i2c functions
> which are not compiled otherwise. Update the Kconfig entry for the
> 'eeprom' command correspondingly.
>
> Signed-off-by: Ivan Orlov <ivan.orlov@codethink.co.uk>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-04 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 17:14 [PATCH v2] cmd: eeprom: Fix config dependency Ivan Orlov
2024-02-23 20:38 ` Tom Rini
2024-03-04 15:29 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox