U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <foss+uboot@0leil.net>
To: Klaus Goger <klaus.goger@cherry.de>, Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>
Subject: [PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s
Date: Wed, 19 Jun 2024 11:55:52 +0200	[thread overview]
Message-ID: <20240619-puma-eth-timeout-v1-1-db5c17153f82@cherry.de> (raw)

From: Quentin Schulz <quentin.schulz@cherry.de>

On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the
link in the 4-second default timeout.

After some boot-loop test for about a thousand boots, 70% were below
10s, 90% below 15s and 100% below 30s. Let's play it safe and make it
30s so that hopefully all links that should be detected are.

Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 include/configs/puma_rk3399.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/configs/puma_rk3399.h b/include/configs/puma_rk3399.h
index 969acc89b93..2056a5eb2e4 100644
--- a/include/configs/puma_rk3399.h
+++ b/include/configs/puma_rk3399.h
@@ -6,6 +6,9 @@
 #ifndef __PUMA_RK3399_H
 #define __PUMA_RK3399_H
 
+/* Highly variable timeout in getting a link on Puma v2.1 with KSZ9031 */
+#define PHY_ANEG_TIMEOUT                30000
+
 #include <configs/rk3399_common.h>
 
 #endif

---
base-commit: fe2ce09a0753634543c32cafe85eb87a625f76ca
change-id: 20240619-puma-eth-timeout-41be9c243ed7

Best regards,
-- 
Quentin Schulz <quentin.schulz@cherry.de>


             reply	other threads:[~2024-06-19  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:55 Quentin Schulz [this message]
2024-06-19 15:22 ` [PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s Tom Rini
2024-06-19 15:43   ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240619-puma-eth-timeout-v1-1-db5c17153f82@cherry.de \
    --to=foss+uboot@0leil.net \
    --cc=klaus.goger@cherry.de \
    --cc=quentin.schulz@cherry.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox