U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Tom Rini <trini@konsulko.com>, Quentin Schulz <foss+uboot@0leil.net>
Cc: Klaus Goger <klaus.goger@cherry.de>,
	u-boot@lists.denx.de, Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s
Date: Wed, 19 Jun 2024 17:43:28 +0200	[thread overview]
Message-ID: <47cc860d-46c7-4258-b1fa-307c2ba1f54e@cherry.de> (raw)
In-Reply-To: <20240619152208.GC68077@bill-the-cat>

Hi Tom,

On 6/19/24 5:22 PM, Tom Rini wrote:
> On Wed, Jun 19, 2024 at 11:55:52AM +0200, Quentin Schulz wrote:
> 
>> From: Quentin Schulz <quentin.schulz@cherry.de>
>>
>> On Puma v2.1 with a KSZ9031, the Ethernet PHY often doesn't detect the
>> link in the 4-second default timeout.
>>
>> After some boot-loop test for about a thousand boots, 70% were below
>> 10s, 90% below 15s and 100% below 30s. Let's play it safe and make it
>> 30s so that hopefully all links that should be detected are.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
>> ---
>>   include/configs/puma_rk3399.h | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> Please rebase on -next where this is now in Kconfig.
> 

It's technically a bug fix, but well... we've had it forever so one more 
release is probably not gonna hurt us :) Thanks for the heads up.

BTW, I believe 
https://source.denx.de/u-boot/u-boot/-/commit/40f5046c221a7b2719c49b51acefe12914b213e5?page=2 
made it through this net and should be migrated to defconfig as well in 
next? SO adding Michal in Cc here to trigger something if required :)

Cheers,
Quentin

      reply	other threads:[~2024-06-19 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:55 [PATCH] rockchip: puma-rk3399: increase Ethernet PHY timeout to 30s Quentin Schulz
2024-06-19 15:22 ` Tom Rini
2024-06-19 15:43   ` Quentin Schulz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47cc860d-46c7-4258-b1fa-307c2ba1f54e@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=foss+uboot@0leil.net \
    --cc=klaus.goger@cherry.de \
    --cc=michal.simek@amd.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox