U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zixun LI <admin@hifiphile.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
	Lukasz Majewski <lukma@denx.de>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Marek Vasut <marex@denx.de>
Cc: Zixun LI <admin@hifiphile.com>, u-boot@lists.denx.de
Subject: [RFC PATCH 2/4] dm: core: Show device sequence instead in dm_dump_tree()
Date: Wed, 31 Jul 2024 15:42:17 +0200	[thread overview]
Message-ID: <20240731134257.686017-3-admin@hifiphile.com> (raw)
In-Reply-To: <20240731134257.686017-1-admin@hifiphile.com>

Currently uclass index is shown in DM tree dump which ignores alias
sequence numbering. The result could be confusing since these 2 numbers
could be different. Show device sequence number instead.

Signed-off-by: Zixun LI <admin@hifiphile.com>
---
 drivers/core/dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/core/dump.c b/drivers/core/dump.c
index 5ec30d5b3c..c812d87fa4 100644
--- a/drivers/core/dump.c
+++ b/drivers/core/dump.c
@@ -40,7 +40,7 @@ static void show_devices(struct udevice *dev, int depth, int last_flag,
 	/* print the first 20 characters to not break the tree-format. */
 	printf(CONFIG_IS_ENABLED(USE_TINY_PRINTF) ? " %s  %d  [ %c ]   %s  " :
 	       " %-10.10s  %3d  [ %c ]   %-20.20s  ", dev->uclass->uc_drv->name,
-	       dev_get_uclass_index(dev, NULL),
+	       dev->seq_,
 	       flags & DM_FLAG_ACTIVATED ? '+' : ' ', dev->driver->name);
 
 	for (i = depth; i >= 0; i--) {
-- 
2.45.2


  parent reply	other threads:[~2024-07-31 21:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 13:42 [RFC PATCH 0/4] dm: Duplicate uclass name fix and alias improvements Zixun LI
2024-07-31 13:42 ` [RFC PATCH 1/4] dm: core: Add a way to specify an alt name for alias sequence numbering Zixun LI
2024-07-31 13:42 ` Zixun LI [this message]
2024-08-01 14:42   ` [RFC PATCH 2/4] dm: core: Show device sequence instead in dm_dump_tree() Simon Glass
2024-07-31 13:42 ` [RFC PATCH 3/4] cmd: bind: Use device sequence instead for driver bind/unbind Zixun LI
2024-08-01 14:42   ` Simon Glass
2024-07-31 13:42 ` [RFC PATCH 4/4] usb: gadget: udc: Fix duplicate uclass name Zixun LI
2024-08-01 14:42 ` [RFC PATCH 0/4] dm: Duplicate uclass name fix and alias improvements Simon Glass
2024-08-01 18:37   ` Zixun LI
2024-08-01 19:28     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731134257.686017-3-admin@hifiphile.com \
    --to=admin@hifiphile.com \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=mkorpershoek@baylibre.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox