From: Zixun LI <admin@hifiphile.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
Lukasz Majewski <lukma@denx.de>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Marek Vasut <marex@denx.de>
Cc: Zixun LI <admin@hifiphile.com>, u-boot@lists.denx.de
Subject: [RFC PATCH 4/4] usb: gadget: udc: Fix duplicate uclass name
Date: Wed, 31 Jul 2024 15:42:19 +0200 [thread overview]
Message-ID: <20240731134257.686017-5-admin@hifiphile.com> (raw)
In-Reply-To: <20240731134257.686017-1-admin@hifiphile.com>
Currently both USB host uclass and USB gadget uclass are using the same
name "usb" which break uclass functions like uclass_get_by_name().
Rename the uclass to "usb_gadget" while using "usb" as sequence alias
naming to keep the alias function working.
Signed-off-by: Zixun LI <admin@hifiphile.com>
---
drivers/usb/gadget/udc/udc-uclass.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/udc-uclass.c b/drivers/usb/gadget/udc/udc-uclass.c
index fbe62bbce4..b14f84e818 100644
--- a/drivers/usb/gadget/udc/udc-uclass.c
+++ b/drivers/usb/gadget/udc/udc-uclass.c
@@ -83,7 +83,8 @@ __weak int dm_usb_gadget_handle_interrupts(struct udevice *dev)
#if CONFIG_IS_ENABLED(DM)
UCLASS_DRIVER(usb_gadget_generic) = {
.id = UCLASS_USB_GADGET_GENERIC,
- .name = "usb",
+ .name = "usb_gadget",
+ .name_seq_alias = "usb",
.flags = DM_UC_FLAG_SEQ_ALIAS,
};
#endif
--
2.45.2
next prev parent reply other threads:[~2024-07-31 21:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:42 [RFC PATCH 0/4] dm: Duplicate uclass name fix and alias improvements Zixun LI
2024-07-31 13:42 ` [RFC PATCH 1/4] dm: core: Add a way to specify an alt name for alias sequence numbering Zixun LI
2024-07-31 13:42 ` [RFC PATCH 2/4] dm: core: Show device sequence instead in dm_dump_tree() Zixun LI
2024-08-01 14:42 ` Simon Glass
2024-07-31 13:42 ` [RFC PATCH 3/4] cmd: bind: Use device sequence instead for driver bind/unbind Zixun LI
2024-08-01 14:42 ` Simon Glass
2024-07-31 13:42 ` Zixun LI [this message]
2024-08-01 14:42 ` [RFC PATCH 0/4] dm: Duplicate uclass name fix and alias improvements Simon Glass
2024-08-01 18:37 ` Zixun LI
2024-08-01 19:28 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731134257.686017-5-admin@hifiphile.com \
--to=admin@hifiphile.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=mkorpershoek@baylibre.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox