U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
@ 2024-09-09 19:30 Fabio Estevam
  2024-09-10  0:43 ` Peng Fan
  2024-09-10  1:59 ` Fabio Estevam
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-09-09 19:30 UTC (permalink / raw)
  To: marex; +Cc: u-boot, uboot-imx, otavio, Fabio Estevam

Since commit 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin
image generation to binman") the imx8mq-evk fails to boot:

U-Boot SPL 2024.10-rc4 (Sep 09 2024 - 16:08:22 -0300)
PMIC:  PFUZE100 ID=0x10
SEC0:  RNG instantiated
Normal Boot
Trying to boot from MMC2

Fix it by passing the offset property for the FIT image, just like
it is done on i.MX8MM.

Fixes: 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image generation to binman")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/dts/imx8mq-u-boot.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi
index e1cd6f8996dc..9b895a63857a 100644
--- a/arch/arm/dts/imx8mq-u-boot.dtsi
+++ b/arch/arm/dts/imx8mq-u-boot.dtsi
@@ -111,6 +111,8 @@
 #endif
 				#address-cells = <1>;
 
+				offset = <0x57c00>;
+
 				images {
 					uboot {
 						arch = "arm64";
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
  2024-09-09 19:30 [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression Fabio Estevam
@ 2024-09-10  0:43 ` Peng Fan
  2024-09-10  0:47   ` Marek Vasut
  2024-09-10  1:59 ` Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2024-09-10  0:43 UTC (permalink / raw)
  To: Fabio Estevam, marex@denx.de
  Cc: u-boot@lists.denx.de, dl-uboot-imx, otavio@ossystems.com.br

> Subject: [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
> 
> Since commit 37e50627efac ("ARM: dts: imx: Convert i.MX8M
> flash.bin image generation to binman") the imx8mq-evk fails to boot:
> 
> U-Boot SPL 2024.10-rc4 (Sep 09 2024 - 16:08:22 -0300)
> PMIC:  PFUZE100 ID=0x10
> SEC0:  RNG instantiated
> Normal Boot
> Trying to boot from MMC2
> 
> Fix it by passing the offset property for the FIT image, just like it is done
> on i.MX8MM.
> 
> Fixes: 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image
> generation to binman")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
  2024-09-10  0:43 ` Peng Fan
@ 2024-09-10  0:47   ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2024-09-10  0:47 UTC (permalink / raw)
  To: Peng Fan, Fabio Estevam
  Cc: u-boot@lists.denx.de, dl-uboot-imx, otavio@ossystems.com.br

On 9/10/24 2:43 AM, Peng Fan wrote:
>> Subject: [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
>>
>> Since commit 37e50627efac ("ARM: dts: imx: Convert i.MX8M
>> flash.bin image generation to binman") the imx8mq-evk fails to boot:
>>
>> U-Boot SPL 2024.10-rc4 (Sep 09 2024 - 16:08:22 -0300)
>> PMIC:  PFUZE100 ID=0x10
>> SEC0:  RNG instantiated
>> Normal Boot
>> Trying to boot from MMC2
>>
>> Fix it by passing the offset property for the FIT image, just like it is done
>> on i.MX8MM.
>>
>> Fixes: 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image
>> generation to binman")
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marek Vasut <marex@denx.de>

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
  2024-09-09 19:30 [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression Fabio Estevam
  2024-09-10  0:43 ` Peng Fan
@ 2024-09-10  1:59 ` Fabio Estevam
  1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2024-09-10  1:59 UTC (permalink / raw)
  To: marex; +Cc: u-boot, uboot-imx, otavio

On Mon, Sep 9, 2024 at 4:30 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Since commit 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin
> image generation to binman") the imx8mq-evk fails to boot:
>
> U-Boot SPL 2024.10-rc4 (Sep 09 2024 - 16:08:22 -0300)
> PMIC:  PFUZE100 ID=0x10
> SEC0:  RNG instantiated
> Normal Boot
> Trying to boot from MMC2
>
> Fix it by passing the offset property for the FIT image, just like
> it is done on i.MX8MM.
>
> Fixes: 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image generation to binman")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-10  1:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09 19:30 [PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression Fabio Estevam
2024-09-10  0:43 ` Peng Fan
2024-09-10  0:47   ` Marek Vasut
2024-09-10  1:59 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox