From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Johan Jonker <jbx6244@gmail.com>
Subject: [PATCH 11/27] led: Drop the legacy LED command
Date: Thu, 26 Sep 2024 22:44:31 +0200 [thread overview]
Message-ID: <20240926204455.963584-12-sjg@chromium.org> (raw)
In-Reply-To: <20240926204455.963584-1-sjg@chromium.org>
This is not used by any board. Drop it.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
cmd/Makefile | 1 -
cmd/legacy_led.c | 145 -----------------------------------------------
2 files changed, 146 deletions(-)
delete mode 100644 cmd/legacy_led.c
diff --git a/cmd/Makefile b/cmd/Makefile
index 91227f1249c..ca57ac86b79 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -102,7 +102,6 @@ obj-$(CONFIG_CMD_IRQ) += irq.o
obj-$(CONFIG_CMD_ITEST) += itest.o
obj-$(CONFIG_CMD_JFFS2) += jffs2.o
obj-$(CONFIG_CMD_CRAMFS) += cramfs.o
-obj-$(CONFIG_LED_STATUS_CMD) += legacy_led.o
obj-$(CONFIG_CMD_LED) += led.o
obj-$(CONFIG_CMD_LICENSE) += license.o
obj-y += load.o
diff --git a/cmd/legacy_led.c b/cmd/legacy_led.c
deleted file mode 100644
index ef2135e0dba..00000000000
--- a/cmd/legacy_led.c
+++ /dev/null
@@ -1,145 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * (C) Copyright 2010
- * Jason Kridner <jkridner@beagleboard.org>
- *
- * Based on cmd_led.c patch from:
- * http://www.mail-archive.com/u-boot@lists.denx.de/msg06873.html
- * (C) Copyright 2008
- * Ulf Samuelsson <ulf.samuelsson@atmel.com>
- */
-
-#include <command.h>
-#include <status_led.h>
-#include <vsprintf.h>
-
-struct led_tbl_s {
- char *string; /* String for use in the command */
- led_id_t mask; /* Mask used for calling __led_set() */
- void (*off)(void); /* Optional function for turning LED off */
- void (*on)(void); /* Optional function for turning LED on */
- void (*toggle)(void);/* Optional function for toggling LED */
-};
-
-typedef struct led_tbl_s led_tbl_t;
-
-static const led_tbl_t led_commands[] = {
-#ifdef CONFIG_LED_STATUS_GREEN
- { "green", CONFIG_LED_STATUS_GREEN, green_led_off, green_led_on, NULL },
-#endif
-#ifdef CONFIG_LED_STATUS_YELLOW
- { "yellow", CONFIG_LED_STATUS_YELLOW, yellow_led_off, yellow_led_on,
- NULL },
-#endif
-#ifdef CONFIG_LED_STATUS_RED
- { "red", CONFIG_LED_STATUS_RED, red_led_off, red_led_on, NULL },
-#endif
-#ifdef CONFIG_LED_STATUS_BLUE
- { "blue", CONFIG_LED_STATUS_BLUE, blue_led_off, blue_led_on, NULL },
-#endif
- { NULL, 0, NULL, NULL, NULL }
-};
-
-enum led_cmd { LED_ON, LED_OFF, LED_TOGGLE, LED_BLINK };
-
-enum led_cmd get_led_cmd(char *var)
-{
- if (strcmp(var, "off") == 0)
- return LED_OFF;
- if (strcmp(var, "on") == 0)
- return LED_ON;
- if (strcmp(var, "toggle") == 0)
- return LED_TOGGLE;
- if (strcmp(var, "blink") == 0)
- return LED_BLINK;
-
- return -1;
-}
-
-/*
- * LED drivers providing a blinking LED functionality, like the
- * PCA9551, can override this empty weak function
- */
-void __weak __led_blink(led_id_t mask, int freq)
-{
-}
-
-int do_legacy_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
-{
- int i, match = 0;
- enum led_cmd cmd;
- int freq;
-
- /* Validate arguments */
- if ((argc < 3) || (argc > 4))
- return CMD_RET_USAGE;
-
- cmd = get_led_cmd(argv[2]);
- if (cmd < 0) {
- return CMD_RET_USAGE;
- }
-
- for (i = 0; led_commands[i].string; i++) {
- if ((strcmp("all", argv[1]) == 0) ||
- (strcmp(led_commands[i].string, argv[1]) == 0)) {
- match = 1;
- switch (cmd) {
- case LED_ON:
- if (led_commands[i].on)
- led_commands[i].on();
- else
- __led_set(led_commands[i].mask,
- CONFIG_LED_STATUS_ON);
- break;
- case LED_OFF:
- if (led_commands[i].off)
- led_commands[i].off();
- else
- __led_set(led_commands[i].mask,
- CONFIG_LED_STATUS_OFF);
- break;
- case LED_TOGGLE:
- if (led_commands[i].toggle)
- led_commands[i].toggle();
- else
- __led_toggle(led_commands[i].mask);
- break;
- case LED_BLINK:
- if (argc != 4)
- return CMD_RET_USAGE;
-
- freq = dectoul(argv[3], NULL);
- __led_blink(led_commands[i].mask, freq);
- }
- /* Need to set only 1 led if led_name wasn't 'all' */
- if (strcmp("all", argv[1]) != 0)
- break;
- }
- }
-
- /* If we ran out of matches, print Usage */
- if (!match) {
- return CMD_RET_USAGE;
- }
-
- return 0;
-}
-
-U_BOOT_CMD(
- led, 4, 1, do_legacy_led,
- "["
-#ifdef CONFIG_LED_STATUS_GREEN
- "green|"
-#endif
-#ifdef CONFIG_LED_STATUS_YELLOW
- "yellow|"
-#endif
-#ifdef CONFIG_LED_STATUS_RED
- "red|"
-#endif
-#ifdef CONFIG_LED_STATUS_BLUE
- "blue|"
-#endif
- "all] [on|off|toggle|blink] [blink-freq in ms]",
- "[led_name] [on|off|toggle|blink] sets or clears led(s)"
-);
--
2.43.0
next prev parent reply other threads:[~2024-09-26 20:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 20:44 [PATCH 00/27] led: Remove old status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 01/27] led: Drop LED_STATUS_BOARD_SPECIFIC Simon Glass
2024-09-26 20:44 ` [PATCH 02/27] arm: Drop old LED support Simon Glass
2024-09-26 20:44 ` [PATCH 03/27] common: doc: " Simon Glass
2024-09-26 20:44 ` [PATCH 04/27] st: stm32f429: Drop old LED code Simon Glass
2024-09-26 20:44 ` [PATCH 05/27] led: Make the LED config common Simon Glass
2024-09-26 20:44 ` [PATCH 06/27] eb_cpu5282: Drop STATUS_LED Simon Glass
2024-09-26 20:44 ` [PATCH 07/27] mx23_olinuxino: " Simon Glass
2024-09-26 20:44 ` [PATCH 08/27] pinephone: " Simon Glass
2024-09-26 20:44 ` [PATCH 09/27] socfpga_vining_fpga: " Simon Glass
2024-09-26 20:44 ` [PATCH 10/27] led: Drop LED_STATUS from Kconfig Simon Glass
2024-09-26 20:44 ` Simon Glass [this message]
2024-09-26 20:44 ` [PATCH 12/27] misc: Drop gpio_led driver Simon Glass
2024-09-26 20:44 ` [PATCH 13/27] pca9551_led: Delete driver Simon Glass
2024-09-26 20:44 ` [PATCH 14/27] misc: status_led: " Simon Glass
2024-09-26 20:44 ` [PATCH 15/27] m68k: Drop unused status_led.h header file Simon Glass
2024-10-01 7:21 ` Acked Angelo Dureghello
2024-09-26 20:44 ` [PATCH 16/27] powerpc: Drop status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 17/27] eb_cpu5282: " Simon Glass
2024-09-26 20:44 ` [PATCH 18/27] igep00x0: Drop unused status_led.h header file Simon Glass
2024-09-26 21:30 ` Javier Martinez Canillas
2024-09-26 20:44 ` [PATCH 19/27] mx23_olinuxino: Drop status-LED code Simon Glass
2024-09-26 21:39 ` Marek Vasut
2024-09-26 22:10 ` Simon Glass
2024-09-26 22:19 ` Marek Vasut
2024-09-27 10:43 ` Simon Glass
2024-09-27 10:51 ` Marek Vasut
2024-09-26 20:44 ` [PATCH 20/27] vining_fpga: " Simon Glass
2024-09-26 20:44 ` [PATCH 21/27] sunxi: " Simon Glass
2024-09-26 20:44 ` [PATCH 22/27] common: Drop status-LED code in board_r Simon Glass
2024-09-26 20:44 ` [PATCH 23/27] image: Drop unused status_led.h header file Simon Glass
2024-09-26 20:44 ` [PATCH 24/27] ide: " Simon Glass
2024-09-26 20:44 ` [PATCH 25/27] mpc83xx: Drop status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 26/27] net: " Simon Glass
2024-09-26 20:44 ` [PATCH 27/27] led: Drop status_led header file Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926204455.963584-12-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=akashi.tkhro@gmail.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jbx6244@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox