U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
	Devarsh Thakkar <devarsht@ti.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Raymond Mao <raymond.mao@linaro.org>,
	Richard Weinberger <richard@nod.at>,
	This contributor prefers not to receive mails
	<noreply@example.com>
Subject: [PATCH 03/27] common: doc: Drop old LED support
Date: Thu, 26 Sep 2024 22:44:23 +0200	[thread overview]
Message-ID: <20240926204455.963584-4-sjg@chromium.org> (raw)
In-Reply-To: <20240926204455.963584-1-sjg@chromium.org>

This has been replaced with a new LED framework, so drop this old code
and documentation.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/board_f.c | 22 --------------
 doc/README.LED   | 77 ------------------------------------------------
 2 files changed, 99 deletions(-)
 delete mode 100644 doc/README.LED

diff --git a/common/board_f.c b/common/board_f.c
index 154675d0e40..f161a690ec0 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -36,7 +36,6 @@
 #include <relocate.h>
 #include <serial.h>
 #include <spl.h>
-#include <status_led.h>
 #include <sysreset.h>
 #include <timer.h>
 #include <trace.h>
@@ -53,27 +52,6 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-/*
- * TODO(sjg@chromium.org): IMO this code should be
- * refactored to a single function, something like:
- *
- * void led_set_state(enum led_colour_t colour, int on);
- */
-/************************************************************************
- * Coloured LED functionality
- ************************************************************************
- * May be supplied by boards if desired
- */
-__weak void coloured_LED_init(void) {}
-__weak void red_led_on(void) {}
-__weak void red_led_off(void) {}
-__weak void green_led_on(void) {}
-__weak void green_led_off(void) {}
-__weak void yellow_led_on(void) {}
-__weak void yellow_led_off(void) {}
-__weak void blue_led_on(void) {}
-__weak void blue_led_off(void) {}
-
 /*
  * Why is gd allocated a register? Prior to reloc it might be better to
  * just pass it around to each function in this file?
diff --git a/doc/README.LED b/doc/README.LED
deleted file mode 100644
index c21c9d53ec3..00000000000
--- a/doc/README.LED
+++ /dev/null
@@ -1,77 +0,0 @@
-Status LED
-========================================
-
-This README describes the status LED API.
-
-The API is defined by the include file include/status_led.h
-
-The first step is to enable CONFIG_LED_STATUS in menuconfig:
-> Device Drivers > LED Support.
-
-If the LED support is only for specific board, enable
-CONFIG_LED_STATUS_BOARD_SPECIFIC in the menuconfig.
-
-Status LEDS 0 to 5 are enabled by the following configurations at menuconfig:
-CONFIG_STATUS_LED0, CONFIG_STATUS_LED1, ... CONFIG_STATUS_LED5
-
-The following should be configured for each of the enabled LEDs:
-CONFIG_STATUS_LED_BIT<n>
-CONFIG_STATUS_LED_STATE<n>
-CONFIG_STATUS_LED_FREQ<n>
-Where <n> is an integer 1 through 5 (empty for 0).
-
-CONFIG_STATUS_LED_BIT is passed into the __led_* functions to identify which LED
-is being acted on. As such, the value choose must be unique with with respect to
-the other CONFIG_STATUS_LED_BIT's. Mapping the value to a physical LED is the
-reponsiblity of the __led_* function.
-
-CONFIG_STATUS_LED_STATE is the initial state of the LED. It should be set to one
-of these values: CONFIG_LED_STATUS_OFF or CONFIG_LED_STATUS_ON.
-
-CONFIG_STATUS_LED_FREQ determines the LED blink frequency.
-Values range from 2 to 10.
-
-Some other LED macros
----------------------
-
-CONFIG_STATUS_LED_BOOT is the LED to light when the board is booting.
-This must be a valid LED number (0-5).
-
-CONFIG_STATUS_LED_RED is the red LED. It is used to signal errors. This must be
-a valid LED number (0-5). Other similar color LED's macros are
-CONFIG_STATUS_LED_GREEN, CONFIG_STATUS_LED_YELLOW and CONFIG_STATUS_LED_BLUE.
-
-General LED functions
----------------------
-The following functions should be defined:
-
-__led_init is called once to initialize the LED to CONFIG_STATUS_LED_STATE.
-One time start up code should be placed here.
-
-__led_set is called to change the state of the LED.
-
-__led_toggle is called to toggle the current state of the LED.
-
-Colour LED
-========================================
-
-Colour LED's are at present only used by ARM.
-
-The functions names explain their purpose.
-
-coloured_LED_init
-red_LED_on
-red_LED_off
-green_LED_on
-green_LED_off
-yellow_LED_on
-yellow_LED_off
-blue_LED_on
-blue_LED_off
-
-These are weakly defined in arch/arm/lib/board.c to noops. Where applicable, define
-these functions in the board specific source.
-
-TBD : Describe older board dependent macros similar to what is done for
-
-TBD : Describe general support via asm/status_led.h
-- 
2.43.0


  parent reply	other threads:[~2024-09-26 20:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 20:44 [PATCH 00/27] led: Remove old status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 01/27] led: Drop LED_STATUS_BOARD_SPECIFIC Simon Glass
2024-09-26 20:44 ` [PATCH 02/27] arm: Drop old LED support Simon Glass
2024-09-26 20:44 ` Simon Glass [this message]
2024-09-26 20:44 ` [PATCH 04/27] st: stm32f429: Drop old LED code Simon Glass
2024-09-26 20:44 ` [PATCH 05/27] led: Make the LED config common Simon Glass
2024-09-26 20:44 ` [PATCH 06/27] eb_cpu5282: Drop STATUS_LED Simon Glass
2024-09-26 20:44 ` [PATCH 07/27] mx23_olinuxino: " Simon Glass
2024-09-26 20:44 ` [PATCH 08/27] pinephone: " Simon Glass
2024-09-26 20:44 ` [PATCH 09/27] socfpga_vining_fpga: " Simon Glass
2024-09-26 20:44 ` [PATCH 10/27] led: Drop LED_STATUS from Kconfig Simon Glass
2024-09-26 20:44 ` [PATCH 11/27] led: Drop the legacy LED command Simon Glass
2024-09-26 20:44 ` [PATCH 12/27] misc: Drop gpio_led driver Simon Glass
2024-09-26 20:44 ` [PATCH 13/27] pca9551_led: Delete driver Simon Glass
2024-09-26 20:44 ` [PATCH 14/27] misc: status_led: " Simon Glass
2024-09-26 20:44 ` [PATCH 15/27] m68k: Drop unused status_led.h header file Simon Glass
2024-10-01  7:21   ` Acked Angelo Dureghello
2024-09-26 20:44 ` [PATCH 16/27] powerpc: Drop status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 17/27] eb_cpu5282: " Simon Glass
2024-09-26 20:44 ` [PATCH 18/27] igep00x0: Drop unused status_led.h header file Simon Glass
2024-09-26 21:30   ` Javier Martinez Canillas
2024-09-26 20:44 ` [PATCH 19/27] mx23_olinuxino: Drop status-LED code Simon Glass
2024-09-26 21:39   ` Marek Vasut
2024-09-26 22:10     ` Simon Glass
2024-09-26 22:19       ` Marek Vasut
2024-09-27 10:43         ` Simon Glass
2024-09-27 10:51           ` Marek Vasut
2024-09-26 20:44 ` [PATCH 20/27] vining_fpga: " Simon Glass
2024-09-26 20:44 ` [PATCH 21/27] sunxi: " Simon Glass
2024-09-26 20:44 ` [PATCH 22/27] common: Drop status-LED code in board_r Simon Glass
2024-09-26 20:44 ` [PATCH 23/27] image: Drop unused status_led.h header file Simon Glass
2024-09-26 20:44 ` [PATCH 24/27] ide: " Simon Glass
2024-09-26 20:44 ` [PATCH 25/27] mpc83xx: Drop status-LED code Simon Glass
2024-09-26 20:44 ` [PATCH 26/27] net: " Simon Glass
2024-09-26 20:44 ` [PATCH 27/27] led: Drop status_led header file Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240926204455.963584-4-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=devarsht@ti.com \
    --cc=jonas@kwiboo.se \
    --cc=noreply@example.com \
    --cc=raymond.mao@linaro.org \
    --cc=richard@nod.at \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox