Re: [PATCH 00/27] led: Remove old status-LED code

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Sat, Sep 28, 2024 at 04:14:00PM +0100, Peter Robinson wrote:
> Hi Simon,
> 
> > > > There has been an LED framework in U-Boot which uses driver model for
> > > > about 9 years now. Recent work is underway to improve it and provide
> > > > more features. It is probably a good time to drop the old code, which
> > > > is only used by 5 boards:
> > > >
> > > >    ./tools/qconfig.py -f LED_STATUS
> > > >    5 matches
> > > >    eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
> > > >    socfpga_vining_fpga
> > >
> > > Why aren't these boards being migrated to what ever the new frame work
> > > is rather than dropping quite useful functionality on these devices?
> >
> > I don't have any of those boards, but perhaps their maintainers might
> > like to weigh in?
> 
> So? I mean I can test the pinephone at least if you convert it, but I
> don't think the functionality should be just dropped.

As Marek noted on the mx23_olinuxino one, the conversion is to turn on
the new options. This will either (a) work or (b) gracefully fail as the
DT is missing information but an update by the maintainer to OF_UPSTREAM
will fix that. So yes, this is just like other blind conversions we've
done in the past, please do and we'll see if anyone else can test on the
relevant platforms.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]