* [PATCH 00/27] led: Remove old status-LED code
@ 2024-09-26 22:29 Simon Glass
2024-09-27 15:50 ` Peter Robinson
0 siblings, 1 reply; 7+ messages in thread
From: Simon Glass @ 2024-09-26 22:29 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Angelo Dureghello,
Doug Zobel, Etienne Carriere, Igor Opaniuk, Ilias Apalodimas,
Joe Hershberger, Johan Jonker, Kamil Lulko, Marek Behún,
Marek Vasut, Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau
There has been an LED framework in U-Boot which uses driver model for
about 9 years now. Recent work is underway to improve it and provide
more features. It is probably a good time to drop the old code, which
is only used by 5 boards:
./tools/qconfig.py -f LED_STATUS
5 matches
eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
socfpga_vining_fpga
This series attempts that.
Simon Glass (27):
led: Drop LED_STATUS_BOARD_SPECIFIC
arm: Drop old LED support
common: doc: Drop old LED support
st: stm32f429: Drop old LED code
led: Make the LED config common
eb_cpu5282: Drop STATUS_LED
mx23_olinuxino: Drop STATUS_LED
pinephone: Drop STATUS_LED
socfpga_vining_fpga: Drop STATUS_LED
led: Drop LED_STATUS from Kconfig
led: Drop the legacy LED command
misc: Drop gpio_led driver
pca9551_led: Delete driver
misc: status_led: Delete driver
m68k: Drop unused status_led.h header file
powerpc: Drop status-LED code
eb_cpu5282: Drop status-LED code
igep00x0: Drop unused status_led.h header file
mx23_olinuxino: Drop status-LED code
vining_fpga: Drop status-LED code
sunxi: Drop status-LED code
common: Drop status-LED code in board_r
image: Drop unused status_led.h header file
ide: Drop unused status_led.h header file
mpc83xx: Drop status-LED code
net: Drop status-LED code
led: Drop status_led header file
arch/arm/lib/crt0.S | 4 -
arch/m68k/lib/bootm.c | 3 -
arch/powerpc/lib/interrupts.c | 6 -
board/BuS/eb_cpu5282/eb_cpu5282.c | 20 --
board/isee/igep00x0/igep00x0.c | 1 -
board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 -
board/softing/vining_fpga/socfpga.c | 4 -
board/st/stm32f429-discovery/Makefile | 1 -
board/st/stm32f429-discovery/led.c | 39 ---
board/sunxi/board.c | 6 -
boot/image.c | 4 -
cmd/Makefile | 1 -
cmd/ide.c | 4 -
cmd/legacy_led.c | 185 ----------
common/board_f.c | 22 --
common/board_r.c | 16 -
configs/eb_cpu5282_defconfig | 6 -
configs/eb_cpu5282_internal_defconfig | 6 -
configs/mx23_olinuxino_defconfig | 8 -
configs/pinephone_defconfig | 5 -
configs/socfpga_vining_fpga_defconfig | 11 -
doc/README.LED | 77 -----
drivers/led/Kconfig | 342 +------------------
drivers/misc/Kconfig | 13 -
drivers/misc/Makefile | 3 -
drivers/misc/gpio_led.c | 106 ------
drivers/misc/pca9551_led.c | 170 ---------
drivers/misc/status_led.c | 124 -------
drivers/timer/mpc83xx_timer.c | 5 -
include/configs/eb_cpu5282.h | 6 -
include/status_led.h | 102 ------
net/bootp.c | 7 -
net/net.c | 33 --
33 files changed, 11 insertions(+), 1336 deletions(-)
delete mode 100644 board/st/stm32f429-discovery/led.c
delete mode 100644 cmd/legacy_led.c
delete mode 100644 doc/README.LED
delete mode 100644 drivers/misc/gpio_led.c
delete mode 100644 drivers/misc/pca9551_led.c
delete mode 100644 drivers/misc/status_led.c
delete mode 100644 include/status_led.h
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/27] led: Remove old status-LED code
2024-09-26 22:29 [PATCH 00/27] led: Remove old status-LED code Simon Glass
@ 2024-09-27 15:50 ` Peter Robinson
2024-09-27 16:52 ` Simon Glass
0 siblings, 1 reply; 7+ messages in thread
From: Peter Robinson @ 2024-09-27 15:50 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, Tom Rini, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Angelo Dureghello,
Doug Zobel, Etienne Carriere, Igor Opaniuk, Ilias Apalodimas,
Joe Hershberger, Johan Jonker, Kamil Lulko, Marek Behún,
Marek Vasut, Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau
Hi Simon,
> There has been an LED framework in U-Boot which uses driver model for
> about 9 years now. Recent work is underway to improve it and provide
> more features. It is probably a good time to drop the old code, which
> is only used by 5 boards:
>
> ./tools/qconfig.py -f LED_STATUS
> 5 matches
> eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
> socfpga_vining_fpga
Why aren't these boards being migrated to what ever the new frame work
is rather than dropping quite useful functionality on these devices?
> This series attempts that.
>
>
> Simon Glass (27):
> led: Drop LED_STATUS_BOARD_SPECIFIC
> arm: Drop old LED support
> common: doc: Drop old LED support
> st: stm32f429: Drop old LED code
> led: Make the LED config common
> eb_cpu5282: Drop STATUS_LED
> mx23_olinuxino: Drop STATUS_LED
> pinephone: Drop STATUS_LED
> socfpga_vining_fpga: Drop STATUS_LED
> led: Drop LED_STATUS from Kconfig
> led: Drop the legacy LED command
> misc: Drop gpio_led driver
> pca9551_led: Delete driver
> misc: status_led: Delete driver
> m68k: Drop unused status_led.h header file
> powerpc: Drop status-LED code
> eb_cpu5282: Drop status-LED code
> igep00x0: Drop unused status_led.h header file
> mx23_olinuxino: Drop status-LED code
> vining_fpga: Drop status-LED code
> sunxi: Drop status-LED code
> common: Drop status-LED code in board_r
> image: Drop unused status_led.h header file
> ide: Drop unused status_led.h header file
> mpc83xx: Drop status-LED code
> net: Drop status-LED code
> led: Drop status_led header file
>
> arch/arm/lib/crt0.S | 4 -
> arch/m68k/lib/bootm.c | 3 -
> arch/powerpc/lib/interrupts.c | 6 -
> board/BuS/eb_cpu5282/eb_cpu5282.c | 20 --
> board/isee/igep00x0/igep00x0.c | 1 -
> board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 -
> board/softing/vining_fpga/socfpga.c | 4 -
> board/st/stm32f429-discovery/Makefile | 1 -
> board/st/stm32f429-discovery/led.c | 39 ---
> board/sunxi/board.c | 6 -
> boot/image.c | 4 -
> cmd/Makefile | 1 -
> cmd/ide.c | 4 -
> cmd/legacy_led.c | 185 ----------
> common/board_f.c | 22 --
> common/board_r.c | 16 -
> configs/eb_cpu5282_defconfig | 6 -
> configs/eb_cpu5282_internal_defconfig | 6 -
> configs/mx23_olinuxino_defconfig | 8 -
> configs/pinephone_defconfig | 5 -
> configs/socfpga_vining_fpga_defconfig | 11 -
> doc/README.LED | 77 -----
> drivers/led/Kconfig | 342 +------------------
> drivers/misc/Kconfig | 13 -
> drivers/misc/Makefile | 3 -
> drivers/misc/gpio_led.c | 106 ------
> drivers/misc/pca9551_led.c | 170 ---------
> drivers/misc/status_led.c | 124 -------
> drivers/timer/mpc83xx_timer.c | 5 -
> include/configs/eb_cpu5282.h | 6 -
> include/status_led.h | 102 ------
> net/bootp.c | 7 -
> net/net.c | 33 --
> 33 files changed, 11 insertions(+), 1336 deletions(-)
> delete mode 100644 board/st/stm32f429-discovery/led.c
> delete mode 100644 cmd/legacy_led.c
> delete mode 100644 doc/README.LED
> delete mode 100644 drivers/misc/gpio_led.c
> delete mode 100644 drivers/misc/pca9551_led.c
> delete mode 100644 drivers/misc/status_led.c
> delete mode 100644 include/status_led.h
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/27] led: Remove old status-LED code
2024-09-27 15:50 ` Peter Robinson
@ 2024-09-27 16:52 ` Simon Glass
2024-09-28 15:14 ` Peter Robinson
2024-10-01 7:19 ` Angelo Dureghello
0 siblings, 2 replies; 7+ messages in thread
From: Simon Glass @ 2024-09-27 16:52 UTC (permalink / raw)
To: Peter Robinson
Cc: U-Boot Mailing List, Tom Rini, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Angelo Dureghello,
Doug Zobel, Etienne Carriere, Igor Opaniuk, Ilias Apalodimas,
Joe Hershberger, Johan Jonker, Kamil Lulko, Marek Behún,
Marek Vasut, Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau
Hi Peter,
On Fri, 27 Sept 2024 at 09:52, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Hi Simon,
>
> > There has been an LED framework in U-Boot which uses driver model for
> > about 9 years now. Recent work is underway to improve it and provide
> > more features. It is probably a good time to drop the old code, which
> > is only used by 5 boards:
> >
> > ./tools/qconfig.py -f LED_STATUS
> > 5 matches
> > eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
> > socfpga_vining_fpga
>
> Why aren't these boards being migrated to what ever the new frame work
> is rather than dropping quite useful functionality on these devices?
I don't have any of those boards, but perhaps their maintainers might
like to weigh in?
Regards,
Simon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/27] led: Remove old status-LED code
2024-09-27 16:52 ` Simon Glass
@ 2024-09-28 15:14 ` Peter Robinson
2024-09-28 16:03 ` Tom Rini
2024-10-01 7:19 ` Angelo Dureghello
1 sibling, 1 reply; 7+ messages in thread
From: Peter Robinson @ 2024-09-28 15:14 UTC (permalink / raw)
To: Simon Glass
Cc: U-Boot Mailing List, Tom Rini, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Angelo Dureghello,
Doug Zobel, Etienne Carriere, Igor Opaniuk, Ilias Apalodimas,
Joe Hershberger, Johan Jonker, Kamil Lulko, Marek Behún,
Marek Vasut, Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau
Hi Simon,
> > > There has been an LED framework in U-Boot which uses driver model for
> > > about 9 years now. Recent work is underway to improve it and provide
> > > more features. It is probably a good time to drop the old code, which
> > > is only used by 5 boards:
> > >
> > > ./tools/qconfig.py -f LED_STATUS
> > > 5 matches
> > > eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
> > > socfpga_vining_fpga
> >
> > Why aren't these boards being migrated to what ever the new frame work
> > is rather than dropping quite useful functionality on these devices?
>
> I don't have any of those boards, but perhaps their maintainers might
> like to weigh in?
So? I mean I can test the pinephone at least if you convert it, but I
don't think the functionality should be just dropped.
P
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/27] led: Remove old status-LED code
2024-09-28 15:14 ` Peter Robinson
@ 2024-09-28 16:03 ` Tom Rini
0 siblings, 0 replies; 7+ messages in thread
From: Tom Rini @ 2024-09-28 16:03 UTC (permalink / raw)
To: Peter Robinson, Simon Glass
Cc: U-Boot Mailing List, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Angelo Dureghello,
Doug Zobel, Etienne Carriere, Igor Opaniuk, Ilias Apalodimas,
Joe Hershberger, Johan Jonker, Kamil Lulko, Marek Behún,
Marek Vasut, Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu, Wan Yee Lau
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
On Sat, Sep 28, 2024 at 04:14:00PM +0100, Peter Robinson wrote:
> Hi Simon,
>
> > > > There has been an LED framework in U-Boot which uses driver model for
> > > > about 9 years now. Recent work is underway to improve it and provide
> > > > more features. It is probably a good time to drop the old code, which
> > > > is only used by 5 boards:
> > > >
> > > > ./tools/qconfig.py -f LED_STATUS
> > > > 5 matches
> > > > eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
> > > > socfpga_vining_fpga
> > >
> > > Why aren't these boards being migrated to what ever the new frame work
> > > is rather than dropping quite useful functionality on these devices?
> >
> > I don't have any of those boards, but perhaps their maintainers might
> > like to weigh in?
>
> So? I mean I can test the pinephone at least if you convert it, but I
> don't think the functionality should be just dropped.
As Marek noted on the mx23_olinuxino one, the conversion is to turn on
the new options. This will either (a) work or (b) gracefully fail as the
DT is missing information but an update by the maintainer to OF_UPSTREAM
will fix that. So yes, this is just like other blind conversions we've
done in the past, please do and we'll see if anyone else can test on the
relevant platforms.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/27] led: Remove old status-LED code
2024-09-27 16:52 ` Simon Glass
2024-09-28 15:14 ` Peter Robinson
@ 2024-10-01 7:19 ` Angelo Dureghello
1 sibling, 0 replies; 7+ messages in thread
From: Angelo Dureghello @ 2024-10-01 7:19 UTC (permalink / raw)
To: Simon Glass, Peter Robinson
Cc: U-Boot Mailing List, Tom Rini, AKASHI Takahiro, Albert Aribaud,
Alexander Gendin, Alison Wang, Andy Fleming, Doug Zobel,
Etienne Carriere, Igor Opaniuk, Ilias Apalodimas, Joe Hershberger,
Johan Jonker, Kamil Lulko, Marek Behún, Marek Vasut,
Mario Six, Mattijs Korpershoek, Michael Polyntsov,
Mikhail Kshevetskiy, Patrice Chotard, Priyanka Jain, Ramon Fried,
Raymond Mao, Sean Anderson, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau
Hi,
On 27/09/24 6:52 PM, Simon Glass wrote:
> Hi Peter,
>
> On Fri, 27 Sept 2024 at 09:52, Peter Robinson <pbrobinson@gmail.com> wrote:
>> Hi Simon,
>>
>>> There has been an LED framework in U-Boot which uses driver model for
>>> about 9 years now. Recent work is underway to improve it and provide
>>> more features. It is probably a good time to drop the old code, which
>>> is only used by 5 boards:
>>>
>>> ./tools/qconfig.py -f LED_STATUS
>>> 5 matches
>>> eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
>>> socfpga_vining_fpga
>> Why aren't these boards being migrated to what ever the new frame work
>> is rather than dropping quite useful functionality on these devices?
> I don't have any of those boards, but perhaps their maintainers might
> like to weigh in?
i have the 5282 evb, but seems to have some issues executing code with
a recent toolchain, i am working to revive it so i can perform tests
eventually.
>
> Regards,
> Simon
Regards,
Angelo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 00/27] led: Remove old status-LED code
@ 2024-09-26 20:44 Simon Glass
0 siblings, 0 replies; 7+ messages in thread
From: Simon Glass @ 2024-09-26 20:44 UTC (permalink / raw)
To: U-Boot Mailing List
Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Alexander Gendin,
Andre Przywara, Andy Fleming, Angelo Dureghello, Caleb Connolly,
Charles Hardin, Devarsh Thakkar, Francis Laniel,
Heinrich Schuchardt, Huan Wang, Igor Opaniuk, Ilias Apalodimas,
Javier Martinez Canillas, Jens Scharsig, Jerome Forissier,
Johan Jonker, Kamil Lulko, Kever Yang, Mattijs Korpershoek,
Maxim Moskalets, Michael Polyntsov, Mikhail Kshevetskiy,
Okhunjon Sobirjonov, Patrick Delaunay, Priyanka Jain, Ramon Fried,
Rasmus Villemoes, Raymond Mao, Richard Weinberger, Samuel Holland,
Sean Anderson, Sean Anderson, Stefan Roese, Sughosh Ganu,
This contributor prefers not to receive mails, Wan Yee Lau,
uboot-stm32
There has been an LED framework in U-Boot which uses driver model for
about 9 years now. Recent work is underway to improve it and provide
more features. It is probably a good time to drop the old code, which
is only used by 5 boards:
./tools/qconfig.py -f LED_STATUS
5 matches
eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
socfpga_vining_fpga
This series attempts that.
Simon Glass (27):
led: Drop LED_STATUS_BOARD_SPECIFIC
arm: Drop old LED support
common: doc: Drop old LED support
st: stm32f429: Drop old LED code
led: Make the LED config common
eb_cpu5282: Drop STATUS_LED
mx23_olinuxino: Drop STATUS_LED
pinephone: Drop STATUS_LED
socfpga_vining_fpga: Drop STATUS_LED
led: Drop LED_STATUS from Kconfig
led: Drop the legacy LED command
misc: Drop gpio_led driver
pca9551_led: Delete driver
misc: status_led: Delete driver
m68k: Drop unused status_led.h header file
powerpc: Drop status-LED code
eb_cpu5282: Drop status-LED code
igep00x0: Drop unused status_led.h header file
mx23_olinuxino: Drop status-LED code
vining_fpga: Drop status-LED code
sunxi: Drop status-LED code
common: Drop status-LED code in board_r
image: Drop unused status_led.h header file
ide: Drop unused status_led.h header file
mpc83xx: Drop status-LED code
net: Drop status-LED code
led: Drop status_led header file
arch/arm/lib/crt0.S | 4 -
arch/m68k/lib/bootm.c | 3 -
arch/powerpc/lib/interrupts.c | 6 -
board/BuS/eb_cpu5282/eb_cpu5282.c | 20 --
board/isee/igep00x0/igep00x0.c | 1 -
board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 -
board/softing/vining_fpga/socfpga.c | 4 -
board/st/stm32f429-discovery/Makefile | 1 -
board/st/stm32f429-discovery/led.c | 39 ---
board/sunxi/board.c | 6 -
boot/image.c | 4 -
cmd/Makefile | 1 -
cmd/ide.c | 4 -
cmd/legacy_led.c | 185 ----------
common/board_f.c | 22 --
common/board_r.c | 16 -
configs/eb_cpu5282_defconfig | 6 -
configs/eb_cpu5282_internal_defconfig | 6 -
configs/mx23_olinuxino_defconfig | 8 -
configs/pinephone_defconfig | 5 -
configs/socfpga_vining_fpga_defconfig | 11 -
doc/README.LED | 77 -----
drivers/led/Kconfig | 342 +------------------
drivers/misc/Kconfig | 13 -
drivers/misc/Makefile | 3 -
drivers/misc/gpio_led.c | 106 ------
drivers/misc/pca9551_led.c | 170 ---------
drivers/misc/status_led.c | 124 -------
drivers/timer/mpc83xx_timer.c | 5 -
include/configs/eb_cpu5282.h | 6 -
include/status_led.h | 102 ------
net/bootp.c | 7 -
net/net.c | 33 --
33 files changed, 11 insertions(+), 1336 deletions(-)
delete mode 100644 board/st/stm32f429-discovery/led.c
delete mode 100644 cmd/legacy_led.c
delete mode 100644 doc/README.LED
delete mode 100644 drivers/misc/gpio_led.c
delete mode 100644 drivers/misc/pca9551_led.c
delete mode 100644 drivers/misc/status_led.c
delete mode 100644 include/status_led.h
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-01 7:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 22:29 [PATCH 00/27] led: Remove old status-LED code Simon Glass
2024-09-27 15:50 ` Peter Robinson
2024-09-27 16:52 ` Simon Glass
2024-09-28 15:14 ` Peter Robinson
2024-09-28 16:03 ` Tom Rini
2024-10-01 7:19 ` Angelo Dureghello
-- strict thread matches above, loose matches on Subject: below --
2024-09-26 20:44 Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox