From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: u-boot@lists.denx.de
Cc: Jonas Jelonek <jelonek.jonas@gmail.com>, Tom Rini <trini@konsulko.com>
Subject: [PATCH 0/1] arm: provide noncached_set_region prototype to fix build
Date: Wed, 16 Oct 2024 13:24:54 +0200 [thread overview]
Message-ID: <20241016112455.35700-1-jelonek.jonas@gmail.com> (raw)
In OpenWrt project, an issue recently occured after updating u-boot for
mediatek to v2024.10. When building with GCC-14 toolchain, it fails
with:
cmd/cache.c: In function 'do_dcache':
cmd/cache.c:57:25: error: implicit declaration of function
'noncached_set_region' [-Wimplicit-function-declaration]
It is presumably caused by commit 7d6cee2cd0 ("cmd: cache: Remove weak
functions") which removes the prototypes. Arm architecture provides an
implementation for 'noncached_set_region', however it is not available
to 'cmd/cache.c'.
The issue was already discussed in
https://github.com/openwrt/openwrt/issues/16697
and temporarily fixed downstream in
https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295.
Another user reported the issue in u-boot too, and confirmed the
solution working (https://source.denx.de/u-boot/u-boot/-/issues/42).
I'd like to discuss here if this is a proper solution to the issue or if
there is a better proposal. Since this is my first contribution, I have
barely an overview of the u-boot internals.
Please give also hints regarding any wording or explanations in the
commit message.
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
---
Jonas Jelonek (1):
arm: provide noncached_set_region prototype to fix build
arch/arm/include/asm/system.h | 1 +
cmd/cache.c | 1 +
2 files changed, 2 insertions(+)
--
2.39.5 (Apple Git-154)
next reply other threads:[~2024-10-16 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 11:24 Jonas Jelonek [this message]
2024-10-16 11:24 ` [PATCH 1/1] arm: provide noncached_set_region prototype to fix build Jonas Jelonek
2024-10-16 17:44 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016112455.35700-1-jelonek.jonas@gmail.com \
--to=jelonek.jonas@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox