From: Tom Rini <trini@konsulko.com>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] arm: provide noncached_set_region prototype to fix build
Date: Wed, 16 Oct 2024 11:44:59 -0600 [thread overview]
Message-ID: <20241016174459.GA4959@bill-the-cat> (raw)
In-Reply-To: <20241016112455.35700-2-jelonek.jonas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]
On Wed, Oct 16, 2024 at 01:24:55PM +0200, Jonas Jelonek wrote:
> Due to the removal of weak functions in 7d6cee2cd0 ("cmd: cache: Remove
> weak function"), uboot fails to compile after updating to v2024.10 for
Should be "U-Boot" but I can fix that on applying.
> mediatek target in OpenWrt with GCC-14 with error:
> cmd/cache.c: In function 'do_dcache':
> cmd/cache.c:57:25: error: implicit declaration of function
> 'noncached_set_region' [-Wimplicit-function-declaration]
>
> Thus, provide a prototype in arm's include/asm/system.h to fix a build
> error in cmd/cache.c, since related prototypes are also located there.
> Also add an include of asm/system.h in cmd/cache.c to have the function
> available there.
>
> The issue occured after the update of uboot-mediatek in OpenWrt to
> v2024.10, in combination with GCC-14 toolchain. It was reported and
> discussed in https://github.com/openwrt/openwrt/issues/16697, and
> temporarily fixed with
> https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295.
>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
Thanks!
Reviewed-by: Tom Rini <trini@konsulko.com>
Link: https://github.com/openwrt/openwrt/issues/16697
Link: https://github.com/openwrt/openwrt/commit/92ca322dd1f48158b8829fec59319a12e4ae4295
Fixes: 7d6cee2cd0 ("cmd: cache: Remove weak function")
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-10-16 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 11:24 [PATCH 0/1] arm: provide noncached_set_region prototype to fix build Jonas Jelonek
2024-10-16 11:24 ` [PATCH 1/1] " Jonas Jelonek
2024-10-16 17:44 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016174459.GA4959@bill-the-cat \
--to=trini@konsulko.com \
--cc=jelonek.jonas@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox