public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de, kever.yang@rock-chips.com,
	philipp.tomsich@vrull.eu, sjg@chromium.org
Cc: heiko@sntech.de, ukleinek@debian.org, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v3 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433
Date: Mon, 28 Oct 2024 20:00:31 +0100	[thread overview]
Message-ID: <20241028190034.143122-16-heiko@sntech.de> (raw)
In-Reply-To: <20241028190034.143122-1-heiko@sntech.de>

From: Uwe Kleine-König <ukleinek@debian.org>

While it requires to have the right phy driver loaded (i.e. motorcomm)
to make the phy asserting the right delays, this is generally the
preferred way to define the MAC <-> PHY connection.

Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20240304084612.711678-2-ukleinek@debian.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

[ upstream commit: e8d45544f806f3b55c30345de84262cbb9504902 ]

(cherry picked from commit e0bbe061fd537bd7b113c53eb046bbcbf0e6597d)
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
 dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
index 6c4269b3d95..20e4fa6c185 100644
--- a/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
+++ b/dts/upstream/src/arm64/rockchip/rk3568-qnap-ts433.dts
@@ -198,15 +198,13 @@
 	assigned-clock-rates = <0>, <125000000>;
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
 		     &gmac0_rx_bus2
 		     &gmac0_rgmii_clk
 		     &gmac0_rgmii_bus>;
-	rx_delay = <0x2f>;
-	tx_delay = <0x3c>;
 	status = "okay";
 };
 
-- 
2.45.2


  parent reply	other threads:[~2024-10-28 19:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 19:00 [PATCH v3 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
2024-10-28 19:00 ` Heiko Stuebner [this message]
2024-10-28 19:00 ` [PATCH v3 16/18] arm64: dts: rockchip: actually enable pmu-io-domains on qnap-ts433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
2024-10-28 19:00 ` [PATCH v3 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
2024-10-30  6:23   ` Kever Yang
2024-11-08 10:32   ` Kever Yang
2024-11-11 10:12     ` Kever Yang
2024-11-11 10:16       ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028190034.143122-16-heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=andrew@lunn.ch \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=ukleinek@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox