From: Christian Marangi <ansuelsmth@gmail.com>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Sean Anderson <seanga2@gmail.com>,
Julien Masson <jmasson@baylibre.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Yang Xiwen <forbidden405@outlook.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Caleb Connolly <caleb.connolly@linaro.org>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Marek Vasut <marex@denx.de>,
Michael Polyntsov <michael.polyntsov@iopsys.eu>,
u-boot@lists.denx.de
Subject: [PATCH 8/8] test: dm: Update test for LED activity and boot
Date: Sat, 9 Nov 2024 19:00:33 +0100 [thread overview]
Message-ID: <20241109180038.10344-9-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20241109180038.10344-1-ansuelsmth@gmail.com>
Update test for LED activity and boot to follow new implementation with
property set to the LED node phandle.
Also update a copy-paste error in the function name for the activity
tests and actually enable the test with the DM_TEST macro.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
arch/sandbox/dts/test.dts | 8 ++++----
test/dm/led.c | 18 +++++++++++-------
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index 1ffa64a43e2..e9b3b151e10 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -101,8 +101,8 @@
bootscr-ram-offset = /bits/ 64 <0x12345678>;
bootscr-flash-offset = /bits/ 64 <0>;
bootscr-flash-size = /bits/ 64 <0x2000>;
- boot-led = "sandbox:green";
- activity-led = "sandbox:red";
+ boot-led = <&sandbox_led_green>;
+ activity-led = <&sandbox_led_red>;
testing-bool;
testing-int = <123>;
testing-str = "testing";
@@ -988,12 +988,12 @@
leds {
compatible = "gpio-leds";
- iracibble {
+ sandbox_led_red: iracibble {
gpios = <&gpio_a 1 0>;
label = "sandbox:red";
};
- martinet {
+ sandbox_led_green: martinet {
gpios = <&gpio_a 2 0>;
label = "sandbox:green";
};
diff --git a/test/dm/led.c b/test/dm/led.c
index 884f6410b70..e5b86326c3a 100644
--- a/test/dm/led.c
+++ b/test/dm/led.c
@@ -144,7 +144,7 @@ static int dm_test_led_boot(struct unit_test_state *uts)
{
struct udevice *dev
- /* options/u-boot/boot-led is set to "sandbox:green" */
+ /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
ut_assertok(led_get_by_label("sandbox:green", &dev));
ut_asserteq(LEDST_OFF, led_get_state(dev));
ut_assertok(led_boot_on());
@@ -154,14 +154,15 @@ static int dm_test_led_boot(struct unit_test_state *uts)
return 0;
}
+DM_TEST(dm_test_led_boot, UTF_SCAN_PDATA | UTF_SCAN_FDT);
/* Test LED boot blink fallback */
#ifndef CONFIG_LED_BLINK
-static int dm_test_led_boot(struct unit_test_state *uts)
+static int dm_test_led_boot_blink(struct unit_test_state *uts)
{
struct udevice *dev
- /* options/u-boot/boot-led is set to "sandbox:green" */
+ /* options/u-boot/boot-led is set to phandle to "sandbox:green" */
ut_assertok(led_get_by_label("sandbox:green", &dev));
ut_asserteq(LEDST_OFF, led_get_state(dev));
ut_assertok(led_boot_blink());
@@ -171,16 +172,17 @@ static int dm_test_led_boot(struct unit_test_state *uts)
return 0;
}
+DM_TEST(dm_test_led_boot_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#endif
#endif
/* Test LED activity */
#ifdef CONFIG_LED_ACTIVITY
-static int dm_test_led_boot(struct unit_test_state *uts)
+static int dm_test_led_activity(struct unit_test_state *uts)
{
struct udevice *dev
- /* options/u-boot/activity-led is set to "sandbox:red" */
+ /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
ut_assertok(led_get_by_label("sandbox:red", &dev));
ut_asserteq(LEDST_OFF, led_get_state(dev));
ut_assertok(led_activity_on());
@@ -190,14 +192,15 @@ static int dm_test_led_boot(struct unit_test_state *uts)
return 0;
}
+DM_TEST(dm_test_led_activity, UTF_SCAN_PDATA | UTF_SCAN_FDT);
/* Test LED activity blink fallback */
#ifndef CONFIG_LED_BLINK
-static int dm_test_led_boot(struct unit_test_state *uts)
+static int dm_test_led_activityt_blink(struct unit_test_state *uts)
{
struct udevice *dev
- /* options/u-boot/activity-led is set to "sandbox:red" */
+ /* options/u-boot/activity-led is set to phandle to "sandbox:red" */
ut_assertok(led_get_by_label("sandbox:red", &dev));
ut_asserteq(LEDST_OFF, led_get_state(dev));
ut_assertok(led_activity_blink());
@@ -207,5 +210,6 @@ static int dm_test_led_boot(struct unit_test_state *uts)
return 0;
}
+DM_TEST(dm_test_led_activityt_blink, UTF_SCAN_PDATA | UTF_SCAN_FDT);
#endif
#endif
--
2.45.2
next prev parent reply other threads:[~2024-11-09 18:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 18:00 [PATCH 0/8] led: update LED boot/activity to new property implementation Christian Marangi
2024-11-09 18:00 ` [PATCH 1/8] dm: core: implement oftree variant of parse_phandle OPs Christian Marangi
2024-11-09 18:00 ` [PATCH 2/8] test: dm: fix broken dm_test_ofnode_phandle_ot Christian Marangi
2024-11-09 18:00 ` [PATCH 3/8] dm: core: implement ofnode/tree_parse_phandle() helper Christian Marangi
2024-11-09 18:00 ` [PATCH 4/8] test: dm: Expand dm_test_ofnode_phandle(_ot) with new ofnode/tree_parse_phandle Christian Marangi
2024-11-09 18:00 ` [PATCH 5/8] dm: core: implement phandle ofnode_options helper Christian Marangi
2024-11-09 18:00 ` [PATCH 6/8] test: dm: Add test for ofnode options phandle helper Christian Marangi
2024-11-09 18:00 ` [PATCH 7/8] led: update LED boot/activity to new property implementation Christian Marangi
2024-11-09 18:00 ` Christian Marangi [this message]
2024-11-09 20:29 ` [PATCH 0/8] " Christian Marangi
2024-11-20 13:46 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109180038.10344-9-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=forbidden405@outlook.com \
--cc=jmasson@baylibre.com \
--cc=marex@denx.de \
--cc=michael.polyntsov@iopsys.eu \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=mkorpershoek@baylibre.com \
--cc=patrick.rudolph@9elements.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox