Re: [PATCH 0/8] led: update LED boot/activity to new property implementation

[Christian Marangi <ansuelsmth@gmail.com>]

On Sat, Nov 09, 2024 at 07:00:25PM +0100, Christian Marangi wrote:
> This series is split in 2 part.
> 
> While adapting the LED boot and activity code to the new property
> accepted by Rob in dt-schema repository, a big BUG was discovered.
> 
> The reason wasn't clear at start and took me some days to figure it
> out.
> 
> This was triggered by adding a new phandle in the test.dts to
> introduce test for the new OPs.
> 
> This single addition caused the sandbox CI test to fail in the
> dm_test_ofnode_phandle_ot test.
> 
> This doesn't make sense as reverting the change made the CI test
> to correctly finish. Also moving the uboot node down
> after the first phandle (in test.dts the gpio one) also made
> the CI test to correctly finish.
> 
> A little bit of searching and debugging made me realize the
> parse phandle OPs didn't support other.dts at all and they
> were still referencing phandle index from test.dts.
> (more info in the related commit)
> 
> In short the test was broken all along and was working by
> pure luck. The first 4 patch address and fix the problem for good.
> 
> The other 4 patch expand and address the property change for
> LED boot/activity.
> 
> Posting in a single series as changes are trivial and just
> to speedup review process. (and also because the second
> part depends on the first)
>

For everyone checking this, tomorrow I will push v2 of this series since
CI catched additional BUGs for flat tree scenario. (I didn't test this
with sandbox)

I also handle this and everything should be ok.

-- 
	Ansuel