public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v2 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()
@ 2024-11-13 10:10 Zixun LI
  2024-11-19 15:44 ` Eugen Hristev
  0 siblings, 1 reply; 2+ messages in thread
From: Zixun LI @ 2024-11-13 10:10 UTC (permalink / raw)
  To: Eugen Hristev, Tom Rini, Heiko Schocher, Sean Anderson,
	Peter Robinson
  Cc: u-boot, Zixun LI

This patch adds support for determining whether a gpio pin is mapped as
peripheral function.

Signed-off-by: Zixun LI <admin@hifiphile.com>
---
Changes in v2:
- Rename function
---
 drivers/gpio/at91_gpio.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c
index 1409db5dc1..173315d45f 100644
--- a/drivers/gpio/at91_gpio.c
+++ b/drivers/gpio/at91_gpio.c
@@ -220,6 +220,15 @@ static bool at91_get_port_output(struct at91_port *at91_port, int offset)
 	val = readl(&at91_port->osr);
 	return val & mask;
 }
+
+static bool at91_is_port_gpio(struct at91_port *at91_port, int offset)
+{
+	u32 mask, val;
+
+	mask = 1 << offset;
+	val = readl(&at91_port->psr);
+	return !!(val & mask);
+}
 #endif

 static void at91_set_port_input(struct at91_port *at91_port, int offset,
@@ -550,7 +559,9 @@ static int at91_gpio_get_function(struct udevice *dev, unsigned offset)
 {
 	struct at91_port_priv *port = dev_get_priv(dev);

-	/* GPIOF_FUNC is not implemented yet */
+	if (!at91_is_port_gpio(port->regs, offset))
+		return GPIOF_FUNC;
+
 	if (at91_get_port_output(port->regs, offset))
 		return GPIOF_OUTPUT;
 	else
--
2.46.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()
  2024-11-13 10:10 [PATCH v2 1/3] gpio: at91: Implement GPIOF_FUNC in get_function() Zixun LI
@ 2024-11-19 15:44 ` Eugen Hristev
  0 siblings, 0 replies; 2+ messages in thread
From: Eugen Hristev @ 2024-11-19 15:44 UTC (permalink / raw)
  To: Zixun LI, Tom Rini, Heiko Schocher, Sean Anderson, Peter Robinson; +Cc: u-boot

Applied patches to u-boot-at91/next, thanks !

Eugen

On 11/13/24 12:10, Zixun LI wrote:
> This patch adds support for determining whether a gpio pin is mapped as
> peripheral function.
> 
> Signed-off-by: Zixun LI <admin@hifiphile.com>
> ---
> Changes in v2:
> - Rename function
> ---
>  drivers/gpio/at91_gpio.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c
> index 1409db5dc1..173315d45f 100644
> --- a/drivers/gpio/at91_gpio.c
> +++ b/drivers/gpio/at91_gpio.c
> @@ -220,6 +220,15 @@ static bool at91_get_port_output(struct at91_port *at91_port, int offset)
>  	val = readl(&at91_port->osr);
>  	return val & mask;
>  }
> +
> +static bool at91_is_port_gpio(struct at91_port *at91_port, int offset)
> +{
> +	u32 mask, val;
> +
> +	mask = 1 << offset;
> +	val = readl(&at91_port->psr);
> +	return !!(val & mask);
> +}
>  #endif
> 
>  static void at91_set_port_input(struct at91_port *at91_port, int offset,
> @@ -550,7 +559,9 @@ static int at91_gpio_get_function(struct udevice *dev, unsigned offset)
>  {
>  	struct at91_port_priv *port = dev_get_priv(dev);
> 
> -	/* GPIOF_FUNC is not implemented yet */
> +	if (!at91_is_port_gpio(port->regs, offset))
> +		return GPIOF_FUNC;
> +
>  	if (at91_get_port_output(port->regs, offset))
>  		return GPIOF_OUTPUT;
>  	else
> --
> 2.46.2
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-19 15:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-13 10:10 [PATCH v2 1/3] gpio: at91: Implement GPIOF_FUNC in get_function() Zixun LI
2024-11-19 15:44 ` Eugen Hristev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox